Thread: pgAdmin 4 commit: Update the runtime to properly support Windows.

pgAdmin 4 commit: Update the runtime to properly support Windows.

From
Dave Page
Date:
Update the runtime to properly support Windows.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efc8815ecb78b20318d18ba50588e63e554f053a
Author: Neel Patel <neel.patel@enterprisedb.com>

Modified Files
--------------
runtime/Server.cpp   | 13 +++++++++++--
runtime/pgAdmin4.pro | 54 +++++++++++++++++++++++++++++++++++++++++-----------
2 files changed, 54 insertions(+), 13 deletions(-)


Re: pgAdmin 4 commit: Update the runtime to properly support Windows.

From
Neel Patel
Date:
Hi Dave,

Below two minor changes.

  - We have added below statement two times in Qt project files so removed the duplicate entry.
    PY2_VERSION = $$find(PY_VERSION, "^2")
  
  - Added some instructions in README file for the Windows system.

Can you please review attached patch file and let us know for any comments.

Thanks,
Neel Patel

On Tue, Feb 2, 2016 at 6:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Update the runtime to properly support Windows.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efc8815ecb78b20318d18ba50588e63e554f053a
Author: Neel Patel <neel.patel@enterprisedb.com>

Modified Files
--------------
runtime/Server.cpp   | 13 +++++++++++--
runtime/pgAdmin4.pro | 54 +++++++++++++++++++++++++++++++++++++++++-----------
2 files changed, 54 insertions(+), 13 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Attachment

Re: pgAdmin 4 commit: Update the runtime to properly support Windows.

From
Dave Page
Date:
Hi

On Wed, Feb 3, 2016 at 5:24 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi Dave,
>
> Below two minor changes.
>
>   - We have added below statement two times in Qt project files so removed
> the duplicate entry.
>     PY2_VERSION = $$find(PY_VERSION, "^2")

Oops - my bad.

>   - Added some instructions in README file for the Windows system.

Thanks - I've tweaked the wording a touch.

> Can you please review attached patch file and let us know for any comments.

Reviewed and applied!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company