Thread: PATCH: fix size check in dlgProperty

PATCH: fix size check in dlgProperty

From

Dmitriy Olshevskiy

Date:

04 July 2015, 14:37:01

hello again.
method dlgDefaultSecurityProperty::OnChangeSize contains the repeated
expressions with l_size.GetWidth() in the conditional operator. I guess the second
expression must by l_size.GetHeight() > 25.
I have attached the file with the correction. could you review it?
thank you.

-- 
Dmitriy Olshevskiy

Attachment

t.33.patch

Re: PATCH: fix size check in dlgProperty

From

Sanket Mehta

Date:

06 July 2015, 15:41:53

Hi,

Patch looks good to me.

Regards,

Sanket Mehta

Sr Software engineer

Enterprisedb

On Sat, Jul 4, 2015 at 4:07 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:

hello again.
method dlgDefaultSecurityProperty::OnChangeSize contains the repeated
expressions with l_size.GetWidth() in the conditional operator. I guess the second
expression must by l_size.GetHeight() > 25.
I have attached the file with the correction. could you review it?
thank you.
-- Dmitriy Olshevskiy
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: PATCH: fix size check in dlgProperty

From

Ashesh Vashi

Date:

08 July 2015, 08:18:05

On Mon, Jul 6, 2015 at 6:11 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:

Hi,

Patch looks good to me.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Sat, Jul 4, 2015 at 4:07 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:
hello again.
method dlgDefaultSecurityProperty::OnChangeSize contains the repeated
expressions with l_size.GetWidth() in the conditional operator. I guess the second
expression must by l_size.GetHeight() > 25.
I have attached the file with the correction. could you review it?
thank you.

Thanks Dmitriy Oleshevskiy for the patch.

Commited to the master branch.

-- Dmitriy Olshevskiy
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers