Thread: PATCH: remove redundant local variables

PATCH: remove redundant local variables

From
Dmitriy Olshevskiy
Date:
Hello.
Please, take a look at this patch. There are
several local variables, that obviously may be
removed.

--
Dmitriy Olshevskiy


Attachment

Re: PATCH: remove redundant local variables

From
Dave Page
Date:
Sanket, could you review this please?

Thanks.

On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:
> Hello.
> Please, take a look at this patch. There are several local variables, that
> obviously may be removed.
>
> --
> Dmitriy Olshevskiy
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: PATCH: remove redundant local variables

From
Sanket Mehta
Date:
Hi Dave,

Sure I will.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
Sanket, could you review this please?

Thanks.

On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:
> Hello.
> Please, take a look at this patch. There are several local variables, that
> obviously may be removed.
>
> --
> Dmitriy Olshevskiy
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: remove redundant local variables

From
Sanket Mehta
Date:
Hi Dave,

Patch looks good to me.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi Dave,

Sure I will.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
Sanket, could you review this please?

Thanks.

On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:
> Hello.
> Please, take a look at this patch. There are several local variables, that
> obviously may be removed.
>
> --
> Dmitriy Olshevskiy
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: PATCH: remove redundant local variables

From
Dave Page
Date:
Ashesh, can you commit this please (if you agree it looks OK)? I don't
have a working dev environment right now.

On Thu, May 21, 2015 at 11:47 AM, Sanket Mehta
<sanket.mehta@enterprisedb.com> wrote:
> Hi Dave,
>
> Patch looks good to me.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta
> <sanket.mehta@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> Sure I will.
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Sanket, could you review this please?
>>>
>>> Thanks.
>>>
>>> On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru>
>>> wrote:
>>> > Hello.
>>> > Please, take a look at this patch. There are several local variables,
>>> > that
>>> > obviously may be removed.
>>> >
>>> > --
>>> > Dmitriy Olshevskiy
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: PATCH: remove redundant local variables

From
Ashesh Vashi
Date:
Sure.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Fri, May 22, 2015 at 5:18 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you commit this please (if you agree it looks OK)? I don't
have a working dev environment right now.

On Thu, May 21, 2015 at 11:47 AM, Sanket Mehta
<sanket.mehta@enterprisedb.com> wrote:
> Hi Dave,
>
> Patch looks good to me.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta
> <sanket.mehta@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> Sure I will.
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Sanket, could you review this please?
>>>
>>> Thanks.
>>>
>>> On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru>
>>> wrote:
>>> > Hello.
>>> > Please, take a look at this patch. There are several local variables,
>>> > that
>>> > obviously may be removed.
>>> >
>>> > --
>>> > Dmitriy Olshevskiy
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: remove redundant local variables

From
Ashesh Vashi
Date:
On Fri, May 22, 2015 at 5:30 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Sure.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Fri, May 22, 2015 at 5:18 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you commit this please (if you agree it looks OK)? I don't
have a working dev environment right now.
Done.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

 

On Thu, May 21, 2015 at 11:47 AM, Sanket Mehta
<sanket.mehta@enterprisedb.com> wrote:
> Hi Dave,
>
> Patch looks good to me.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta
> <sanket.mehta@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> Sure I will.
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Sanket, could you review this please?
>>>
>>> Thanks.
>>>
>>> On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru>
>>> wrote:
>>> > Hello.
>>> > Please, take a look at this patch. There are several local variables,
>>> > that
>>> > obviously may be removed.
>>> >
>>> > --
>>> > Dmitriy Olshevskiy
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company