Thread: PATCH: Fix Explain data output column not auto-sizing
Hello! There is a small bug with Explain data output. Steps to reproduce: 1. Open a new Query window. 2. Perform Explain of any query. Switch to "Data output" tab. Column was auto-sized, ok. 3. Execute the query. 4. Perform Explain again. Switch to "Data output" tab. Column wasn't auto-sized this time, it is too narrow and user has to resize it manually. Here is a fix, please see attachment. -- Best regards, J.F.
Attachment
Ashesh, can you review/commit this please? On Fri, Oct 24, 2014 at 6:02 PM, J.F. Oster <jinfroster@mail.ru> wrote: > Hello! > > There is a small bug with Explain data output. > > Steps to reproduce: > > 1. Open a new Query window. > 2. Perform Explain of any query. Switch to "Data output" tab. Column > was auto-sized, ok. > 3. Execute the query. > 4. Perform Explain again. Switch to "Data output" tab. Column wasn't > auto-sized this time, it is too narrow and user has to resize it > manually. > > Here is a fix, please see attachment. > > -- > Best regards, > J.F. > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Hi,
I have reviewed the patch.
It looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Oct 27, 2014 at 4:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit this please?> --
On Fri, Oct 24, 2014 at 6:02 PM, J.F. Oster <jinfroster@mail.ru> wrote:
> Hello!
>
> There is a small bug with Explain data output.
>
> Steps to reproduce:
>
> 1. Open a new Query window.
> 2. Perform Explain of any query. Switch to "Data output" tab. Column
> was auto-sized, ok.
> 3. Execute the query.
> 4. Perform Explain again. Switch to "Data output" tab. Column wasn't
> auto-sized this time, it is too narrow and user has to resize it
> manually.
>
> Here is a fix, please see attachment.
>
> --
> Best regards,
> J.F.
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Committed to the master branch.
Thanks for the patch
Thanks for the patch
On Mon, Oct 27, 2014 at 6:29 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,I have reviewed the patch.It looks good to me.Regards,Sanket MehtaSr Software engineerEnterprisedbOn Mon, Oct 27, 2014 at 4:14 PM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please?> --
On Fri, Oct 24, 2014 at 6:02 PM, J.F. Oster <jinfroster@mail.ru> wrote:
> Hello!
>
> There is a small bug with Explain data output.
>
> Steps to reproduce:
>
> 1. Open a new Query window.
> 2. Perform Explain of any query. Switch to "Data output" tab. Column
> was auto-sized, ok.
> 3. Execute the query.
> 4. Perform Explain again. Switch to "Data output" tab. Column wasn't
> auto-sized this time, it is too narrow and user has to resize it
> manually.
>
> Here is a fix, please see attachment.
>
> --
> Best regards,
> J.F.
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers