Thread: Patch for closing frmEditGrid dialog using accelerator

Hi,

I've been using pgadmin3 for some time, and while I really appreciate
the tool, I've found it to be a *slight* nuisance that there is no
accelerator defined for closing the "View Data" dialog ("frmEditGrid").
While I agree this is a trivial issue, adding this feature would improve
the user experience as well as make it more consistent (the query dialog
has this feature). Please see the attached patch for details.

I also noticed that there *is* an accelerator defined for saving, but
it's not shown in the menu element. This is included in the patch.

I hope you will consider the patch.


Thanks for a great tool,


°Fredrik

Hello Fredrik,

+1 for Ctrl-W.

I've made the same change :)
Didn't post it because of another patch in review queue.

Saturday, June 7, 2014, 1:58:55 AM, Fredrik de Vibe wrote:

FdV> I've been using pgadmin3 for some time, and while I really appreciate
FdV> the tool, I've found it to be a *slight* nuisance that there is no
FdV> accelerator defined for closing the "View Data" dialog ("frmEditGrid").
FdV> While I agree this is a trivial issue, adding this feature would improve
FdV> the user experience as well as make it more consistent (the query dialog
FdV> has this feature). Please see the attached patch for details.

FdV> I also noticed that there *is* an accelerator defined for saving, but
FdV> it's not shown in the menu element. This is included in the patch.



--
Best regards,
 J.F.

Thanks - patch applied.

On Fri, Jun 6, 2014 at 10:58 PM, Fredrik de Vibe <fdv@ifi.uio.no> wrote:
> Hi,
>
> I've been using pgadmin3 for some time, and while I really appreciate
> the tool, I've found it to be a *slight* nuisance that there is no
> accelerator defined for closing the "View Data" dialog ("frmEditGrid").
> While I agree this is a trivial issue, adding this feature would improve
> the user experience as well as make it more consistent (the query dialog
> has this feature). Please see the attached patch for details.
>
> I also noticed that there *is* an accelerator defined for saving, but
> it's not shown in the menu element. This is included in the patch.
>
> I hope you will consider the patch.
>
>
> Thanks for a great tool,
>
>
> °Fredrik
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company