Thread: Re: [pgadmin-support] Support for non standard SSH port

Re: [pgadmin-support] Support for non standard SSH port

From
Akshay Joshi
Date:
Hi Dave

I have added support for non standard remote SSH port. I have added one control to take input for "Default SSH port" from the user in SSH Tunnel tab, by default it is 22, but user can modify it.

Attached is the patch file, can you please review it. If it looks good to you can you please commit it.  


On Fri, Nov 15, 2013 at 2:29 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Fri, Nov 15, 2013 at 6:38 AM, Dave Page <dpage@pgadmin.org> wrote:
On Thu, Nov 14, 2013 at 10:06 PM, Alex Grechko <alex.grechko@rambler.ru> wrote:
> Hello,
>
> It's very often that a default SSH port is changed to a non standard value.
> In that case native SSH tunnels in pgAdmin are absolutely useless and so we
> have to use old inconvenient methods for SSH tunnels.
>
>
> Would it be possible to add support for non standart remote SSH port?

I thought we had that - guess I must have overlooked it when
reviewing. Akshay, how much effort would it be to add? I assume not
much. This seems like a usability bug.

   I am working on it. We will take the default SSH port as input from the user in "SSH Tunnel" tab of New Server Registration dialog. It will
   take couple of hours to do that.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

Re: [pgadmin-support] Support for non standard SSH port

From
Dave Page
Date:
Hi


On Mon, Nov 18, 2013 at 11:06 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

I have added support for non standard remote SSH port. I have added one control to take input for "Default SSH port" from the user in SSH Tunnel tab, by default it is 22, but user can modify it.

Attached is the patch file, can you please review it. If it looks good to you can you please commit it.  

Shouldn't it just be "SSH Port"?
 


On Fri, Nov 15, 2013 at 2:29 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Fri, Nov 15, 2013 at 6:38 AM, Dave Page <dpage@pgadmin.org> wrote:
On Thu, Nov 14, 2013 at 10:06 PM, Alex Grechko <alex.grechko@rambler.ru> wrote:
> Hello,
>
> It's very often that a default SSH port is changed to a non standard value.
> In that case native SSH tunnels in pgAdmin are absolutely useless and so we
> have to use old inconvenient methods for SSH tunnels.
>
>
> Would it be possible to add support for non standart remote SSH port?

I thought we had that - guess I must have overlooked it when
reviewing. Akshay, how much effort would it be to add? I assume not
much. This seems like a usability bug.

   I am working on it. We will take the default SSH port as input from the user in "SSH Tunnel" tab of New Server Registration dialog. It will
   take couple of hours to do that.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 





--
Akshay Joshi
Principal Software Engineer 





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-support] Support for non standard SSH port

From
Akshay Joshi
Date:



On Mon, Nov 18, 2013 at 5:24 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi


On Mon, Nov 18, 2013 at 11:06 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

I have added support for non standard remote SSH port. I have added one control to take input for "Default SSH port" from the user in SSH Tunnel tab, by default it is 22, but user can modify it.

Attached is the patch file, can you please review it. If it looks good to you can you please commit it.  

Shouldn't it just be "SSH Port"?
   OR "Remote SSH Port"? 
 


On Fri, Nov 15, 2013 at 2:29 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Fri, Nov 15, 2013 at 6:38 AM, Dave Page <dpage@pgadmin.org> wrote:
On Thu, Nov 14, 2013 at 10:06 PM, Alex Grechko <alex.grechko@rambler.ru> wrote:
> Hello,
>
> It's very often that a default SSH port is changed to a non standard value.
> In that case native SSH tunnels in pgAdmin are absolutely useless and so we
> have to use old inconvenient methods for SSH tunnels.
>
>
> Would it be possible to add support for non standart remote SSH port?

I thought we had that - guess I must have overlooked it when
reviewing. Akshay, how much effort would it be to add? I assume not
much. This seems like a usability bug.

   I am working on it. We will take the default SSH port as input from the user in "SSH Tunnel" tab of New Server Registration dialog. It will
   take couple of hours to do that.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 





--
Akshay Joshi
Principal Software Engineer 





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: [pgadmin-support] Support for non standard SSH port

From
Dave Page
Date:



On Mon, Nov 18, 2013 at 12:00 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Mon, Nov 18, 2013 at 5:24 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi


On Mon, Nov 18, 2013 at 11:06 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

I have added support for non standard remote SSH port. I have added one control to take input for "Default SSH port" from the user in SSH Tunnel tab, by default it is 22, but user can modify it.

Attached is the patch file, can you please review it. If it looks good to you can you please commit it.  

Shouldn't it just be "SSH Port"?
   OR "Remote SSH Port"? 

"Tunnel Port" seems like it would fit in with the existing UI a little better. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-support] Support for non standard SSH port

From
Akshay Joshi
Date:



On Mon, Nov 18, 2013 at 5:50 PM, Dave Page <dpage@pgadmin.org> wrote:



On Mon, Nov 18, 2013 at 12:00 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Mon, Nov 18, 2013 at 5:24 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi


On Mon, Nov 18, 2013 at 11:06 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

I have added support for non standard remote SSH port. I have added one control to take input for "Default SSH port" from the user in SSH Tunnel tab, by default it is 22, but user can modify it.

Attached is the patch file, can you please review it. If it looks good to you can you please commit it.  

Shouldn't it just be "SSH Port"?
   OR "Remote SSH Port"? 

"Tunnel Port" seems like it would fit in with the existing UI a little better. 

    Done. Attached is the new modified patch. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

Re: [pgadmin-support] Support for non standard SSH port

From
Dave Page
Date:
Thanks - applied with minor tweaks to the layout.


On Mon, Nov 18, 2013 at 1:16 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Mon, Nov 18, 2013 at 5:50 PM, Dave Page <dpage@pgadmin.org> wrote:



On Mon, Nov 18, 2013 at 12:00 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Mon, Nov 18, 2013 at 5:24 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi


On Mon, Nov 18, 2013 at 11:06 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

I have added support for non standard remote SSH port. I have added one control to take input for "Default SSH port" from the user in SSH Tunnel tab, by default it is 22, but user can modify it.

Attached is the patch file, can you please review it. If it looks good to you can you please commit it.  

Shouldn't it just be "SSH Port"?
   OR "Remote SSH Port"? 

"Tunnel Port" seems like it would fit in with the existing UI a little better. 

    Done. Attached is the new modified patch. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-support] Support for non standard SSH port

From
Akshay Joshi
Date:
Thanks Dave.


On Wed, Nov 20, 2013 at 4:53 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks - applied with minor tweaks to the layout.


On Mon, Nov 18, 2013 at 1:16 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Mon, Nov 18, 2013 at 5:50 PM, Dave Page <dpage@pgadmin.org> wrote:



On Mon, Nov 18, 2013 at 12:00 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:



On Mon, Nov 18, 2013 at 5:24 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi


On Mon, Nov 18, 2013 at 11:06 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

I have added support for non standard remote SSH port. I have added one control to take input for "Default SSH port" from the user in SSH Tunnel tab, by default it is 22, but user can modify it.

Attached is the patch file, can you please review it. If it looks good to you can you please commit it.  

Shouldn't it just be "SSH Port"?
   OR "Remote SSH Port"? 

"Tunnel Port" seems like it would fit in with the existing UI a little better. 

    Done. Attached is the new modified patch. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246