Postgres Pro
Downloads
Home   >   mailing lists

Thread: Indexed constraint comments not working

Indexed constraint comments not working

From
Thom Brown
Date:
Hi all,

Comments on indexed constraints (primary keys, exclusion constraints
etc.) are failing due to referencing the wrong alias of the relevant
pg_description join in the join clause.

Test case:

CREATE TABLE test (id int);

ALTER TABLE test
ADD CONSTRAINT cnt_x_test
EXCLUDE USING btree (id WITH =);

COMMENT ON CONSTRAINT cnt_x_test ON
COMMENT ON CONSTRAINT cnt_x_test
  ON test IS 'Hello';

Viewing the property list of the constraint, the SQL pane and the
constraint editor dialogue doesn't show the comment.

Fix attached.

--
Thom
Attachment

Re: Indexed constraint comments not working

From
Thom Brown
Date:
On 26 May 2013 18:20, Thom Brown <thom@linux.com> wrote:
> Hi all,
>
> Comments on indexed constraints (primary keys, exclusion constraints
> etc.) are failing due to referencing the wrong alias of the relevant
> pg_description join in the join clause.
>
> Test case:
>
> CREATE TABLE test (id int);
>
> ALTER TABLE test
> ADD CONSTRAINT cnt_x_test
> EXCLUDE USING btree (id WITH =);
>
> COMMENT ON CONSTRAINT cnt_x_test ON
> COMMENT ON CONSTRAINT cnt_x_test
>   ON test IS 'Hello';

Paste fail.  Please ignore the first "COMMENT ON..." line.

--
Thom

Re: Indexed constraint comments not working

From
Dave Page
Date:
Thanks - patch applied.

On Sun, May 26, 2013 at 10:20 PM, Thom Brown <thom@linux.com> wrote:
> Hi all,
>
> Comments on indexed constraints (primary keys, exclusion constraints
> etc.) are failing due to referencing the wrong alias of the relevant
> pg_description join in the join clause.
>
> Test case:
>
> CREATE TABLE test (id int);
>
> ALTER TABLE test
> ADD CONSTRAINT cnt_x_test
> EXCLUDE USING btree (id WITH =);
>
> COMMENT ON CONSTRAINT cnt_x_test ON
> COMMENT ON CONSTRAINT cnt_x_test
>   ON test IS 'Hello';
>
> Viewing the property list of the constraint, the SQL pane and the
> constraint editor dialogue doesn't show the comment.
>
> Fix attached.
>
> --
> Thom
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company