Thread: Fixed compilation issue on some Operating System

Fixed compilation issue on some Operating System

From
Akshay Joshi
Date:
Hi Dave

Some of us are facing compilation issue on some operating system due to the inclusion of SSH Tunnel code. I have tried a lot to figure it out, but not found the exact cause of the problem. 

Thanks to "Tim Wood" from salesforce for finding the cause of the problem. The problem is order of libssh2 dependent libraries is not correct in linker command. 

Resolution for the issue is to add the libssh2 dependent libraries in LIBS flags instead of LDFLAGS, because LDFLAGS were added ahead of the pgadmin3 objects and LIBS are added after, so because of that linker is able to find all the references from the dependent libraries.

Attached is the patch file to fix the issue. Please review it and if it looks good to you can you please commit it. 

--
Akshay Joshi
Senior Software Engineer 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246
Attachment

Re: Fixed compilation issue on some Operating System

From
Dave Page
Date:
Thanks - patch applied.

On Thu, May 16, 2013 at 10:04 AM, Akshay Joshi
<akshay.joshi@enterprisedb.com> wrote:
> Hi Dave
>
> Some of us are facing compilation issue on some operating system due to the
> inclusion of SSH Tunnel code. I have tried a lot to figure it out, but not
> found the exact cause of the problem.
>
> Thanks to "Tim Wood" from salesforce for finding the cause of the problem.
> The problem is order of libssh2 dependent libraries is not correct in linker
> command.
>
> Resolution for the issue is to add the libssh2 dependent libraries in LIBS
> flags instead of LDFLAGS, because LDFLAGS were added ahead of the pgadmin3
> objects and LIBS are added after, so because of that linker is able to find
> all the references from the dependent libraries.
>
> Attached is the patch file to fix the issue. Please review it and if it
> looks good to you can you please commit it.
>
> --
> Akshay Joshi
> Senior Software Engineer
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
> Phone: +91 20-3058-9522
> Mobile: +91 976-788-8246
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company