Thread: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Ashesh Vashi
Date:
Hi Dave,

When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

Attachment

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Dave Page
Date:
Thanks - patch applied.

When testing this, I noticed that the distclean target seems to be broken now. Can you (or one of the team) please take a look? Thanks.

viper:pgadmin3 dpage$ make distclean
Making distclean in xtra/png2c
make[1]: Nothing to be done for `distclean'.
Making distclean in branding
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in i18n
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in plugins.d
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in pgadmin
test -z "pgadmin3" || rm -f pgadmin3
rm -f include/images/*.pngc
rm -f *.o
rm -f *.tab.c
test -z "" || rm -f 
rm -f agent/*.o
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f 
rm -f ctl/*.o
rm -f agent/.deps/.dirstamp
rm -f agent/.dirstamp
rm -f ctl/.deps/.dirstamp
rm -f db/*.o
rm -f ctl/.dirstamp
rm -f db/.deps/.dirstamp
rm -f db/.dirstamp
rm -f dd/dditems/figures/*.o
rm -f dd/dditems/figures/.deps/.dirstamp
rm -f dd/dditems/figures/.dirstamp
rm -f dd/dditems/figures/xml/.deps/.dirstamp
rm -f dd/dditems/figures/xml/*.o
rm -f dd/dditems/figures/xml/.dirstamp
rm -f dd/dditems/handles/.deps/.dirstamp
rm -f dd/dditems/handles/*.o
rm -f dd/dditems/handles/.dirstamp
rm -f dd/dditems/locators/.deps/.dirstamp
rm -f dd/dditems/locators/.dirstamp
rm -f dd/dditems/locators/*.o
rm -f dd/dditems/tools/.deps/.dirstamp
rm -f dd/dditems/tools/.dirstamp
rm -f dd/dditems/utilities/.deps/.dirstamp
rm -f dd/dditems/tools/*.o
rm -f dd/dditems/utilities/.dirstamp
rm -f dd/ddmodel/.deps/.dirstamp
rm -f dd/dditems/utilities/*.o
rm -f dd/ddmodel/.dirstamp
rm -f debugger/.deps/.dirstamp
rm -f dd/ddmodel/*.o
rm -f debugger/.dirstamp
rm -f dlg/.deps/.dirstamp
rm -f dlg/.dirstamp
rm -f debugger/*.o
rm -f frm/.deps/.dirstamp
rm -f frm/.dirstamp
rm -f dlg/*.o
rm -f gqb/.deps/.dirstamp
rm -f gqb/.dirstamp
rm -f hotdraw/connectors/.deps/.dirstamp
rm -f hotdraw/connectors/.dirstamp
rm -f hotdraw/figures/.deps/.dirstamp
rm -f hotdraw/figures/.dirstamp
rm -f frm/*.o
rm -f hotdraw/figures/defaultAttributes/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/.dirstamp
rm -f hotdraw/figures/xml/.deps/.dirstamp
rm -f gqb/*.o
rm -f hotdraw/figures/xml/.dirstamp
rm -f hotdraw/handles/.deps/.dirstamp
rm -f hotdraw/handles/.dirstamp
rm -f hotdraw/connectors/*.o
rm -f hotdraw/locators/.deps/.dirstamp
rm -f hotdraw/locators/.dirstamp
rm -f hotdraw/figures/*.o
rm -f hotdraw/main/.deps/.dirstamp
rm -f hotdraw/main/.dirstamp
rm -f hotdraw/tools/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/*.o
rm -f hotdraw/tools/.dirstamp
rm -f hotdraw/utilities/.deps/.dirstamp
rm -f hotdraw/figures/xml/*.o
rm -f hotdraw/utilities/.dirstamp
rm -f libssh2/.deps/.dirstamp
rm -f libssh2/.dirstamp
rm -f hotdraw/handles/*.o
rm -f ogl/.deps/.dirstamp
rm -f ogl/.dirstamp
rm -f hotdraw/locators/*.o
rm -f pgscript/.deps/.dirstamp
rm -f pgscript/.dirstamp
rm -f hotdraw/main/*.o
rm -f pgscript/exceptions/.deps/.dirstamp
rm -f pgscript/exceptions/.dirstamp
rm -f pgscript/expressions/.deps/.dirstamp
rm -f hotdraw/tools/*.o
rm -f pgscript/expressions/.dirstamp
rm -f pgscript/generators/.deps/.dirstamp
rm -f hotdraw/utilities/*.o
rm -f pgscript/generators/.dirstamp
rm -f pgscript/objects/.deps/.dirstamp
rm -f pgscript/objects/.dirstamp
rm -f libssh2/*.o
rm -f pgscript/statements/.deps/.dirstamp
rm -f pgscript/statements/.dirstamp
rm -f pgscript/utilities/.deps/.dirstamp
rm -f ogl/*.o
rm -f pgscript/utilities/.dirstamp
rm -f pgscript/utilities/m_apm/.deps/.dirstamp
rm -f pgscript/utilities/m_apm/.dirstamp
rm -f pgscript/*.o
rm -f schema/.deps/.dirstamp
rm -f schema/.dirstamp
rm -f pgscript/exceptions/*.o
rm -f slony/.deps/.dirstamp
rm -f slony/.dirstamp
rm -f ui/.deps/.dirstamp
rm -f pgscript/expressions/*.o
rm -f ui/.dirstamp
rm -f utils/.deps/.dirstamp
rm -f utils/.dirstamp
rm -f pgscript/generators/*.o
rm -f pgscript/objects/*.o
rm -f pgscript/statements/*.o
rm -f pgscript/utilities/*.o
rm -f pgscript/utilities/m_apm/*.o
rm -f schema/*.o
rm -f slony/*.o
rm -f ui/*.o
rm -f utils/*.o
rm -rf ./.deps agent/.deps ctl/.deps db/.deps dd/dditems/figures/.deps dd/dditems/figures/xml/.deps dd/dditems/handles/.deps dd/dditems/locators/.deps dd/dditems/tools/.deps dd/dditems/utilities/.deps dd/ddmodel/.deps debugger/.deps dlg/.deps frm/.deps gqb/.deps hotdraw/connectors/.deps hotdraw/figures/.deps hotdraw/figures/defaultAttributes/.deps hotdraw/figures/xml/.deps hotdraw/handles/.deps hotdraw/locators/.deps hotdraw/main/.deps hotdraw/tools/.deps hotdraw/utilities/.deps libssh2/.deps ogl/.deps pgscript/.deps pgscript/exceptions/.deps pgscript/expressions/.deps pgscript/generators/.deps pgscript/objects/.deps pgscript/statements/.deps pgscript/utilities/.deps pgscript/utilities/m_apm/.deps schema/.deps slony/.deps ui/.deps utils/.deps
rm -f Makefile
Making distclean in xtra
Making distclean in png2c
make[2]: Nothing to be done for `distclean'.
Making distclean in pgscript
Making distclean in lib
Makefile:1032: ../../../pgadmin/db/.deps/keywords.Po: No such file or directory
Makefile:1033: ../../../pgadmin/db/.deps/pgConn.Po: No such file or directory
Makefile:1034: ../../../pgadmin/db/.deps/pgQueryThread.Po: No such file or directory
Makefile:1035: ../../../pgadmin/db/.deps/pgSet.Po: No such file or directory
Makefile:1036: ../../../pgadmin/pgscript/.deps/lex.pgs.Po: No such file or directory
Makefile:1037: ../../../pgadmin/pgscript/.deps/parser.tab.Po: No such file or directory
Makefile:1038: ../../../pgadmin/pgscript/.deps/pgsApplication.Po: No such file or directory
Makefile:1039: ../../../pgadmin/pgscript/exceptions/.deps/pgsArithmeticException.Po: No such file or directory
Makefile:1040: ../../../pgadmin/pgscript/exceptions/.deps/pgsAssertException.Po: No such file or directory
Makefile:1041: ../../../pgadmin/pgscript/exceptions/.deps/pgsBreakException.Po: No such file or directory
Makefile:1042: ../../../pgadmin/pgscript/exceptions/.deps/pgsCastException.Po: No such file or directory
Makefile:1043: ../../../pgadmin/pgscript/exceptions/.deps/pgsContinueException.Po: No such file or directory
Makefile:1044: ../../../pgadmin/pgscript/exceptions/.deps/pgsException.Po: No such file or directory
Makefile:1045: ../../../pgadmin/pgscript/exceptions/.deps/pgsInterruptException.Po: No such file or directory
Makefile:1046: ../../../pgadmin/pgscript/exceptions/.deps/pgsParameterException.Po: No such file or directory
Makefile:1047: ../../../pgadmin/pgscript/expressions/.deps/pgsAnd.Po: No such file or directory
Makefile:1048: ../../../pgadmin/pgscript/expressions/.deps/pgsAssign.Po: No such file or directory
Makefile:1049: ../../../pgadmin/pgscript/expressions/.deps/pgsAssignToRecord.Po: No such file or directory
Makefile:1050: ../../../pgadmin/pgscript/expressions/.deps/pgsCast.Po: No such file or directory
Makefile:1051: ../../../pgadmin/pgscript/expressions/.deps/pgsColumns.Po: No such file or directory
Makefile:1052: ../../../pgadmin/pgscript/expressions/.deps/pgsDifferent.Po: No such file or directory
Makefile:1053: ../../../pgadmin/pgscript/expressions/.deps/pgsEqual.Po: No such file or directory
Makefile:1054: ../../../pgadmin/pgscript/expressions/.deps/pgsExecute.Po: No such file or directory
Makefile:1055: ../../../pgadmin/pgscript/expressions/.deps/pgsExpression.Po: No such file or directory
Makefile:1056: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDate.Po: No such file or directory
Makefile:1057: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDateTime.Po: No such file or directory
Makefile:1058: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDictionary.Po: No such file or directory
Makefile:1059: ../../../pgadmin/pgscript/expressions/.deps/pgsGenInt.Po: No such file or directory
Makefile:1060: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReal.Po: No such file or directory
Makefile:1061: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReference.Po: No such file or directory
Makefile:1062: ../../../pgadmin/pgscript/expressions/.deps/pgsGenRegex.Po: No such file or directory
Makefile:1063: ../../../pgadmin/pgscript/expressions/.deps/pgsGenString.Po: No such file or directory
Makefile:1064: ../../../pgadmin/pgscript/expressions/.deps/pgsGenTime.Po: No such file or directory
Makefile:1065: ../../../pgadmin/pgscript/expressions/.deps/pgsGreater.Po: No such file or directory
Makefile:1066: ../../../pgadmin/pgscript/expressions/.deps/pgsGreaterEqual.Po: No such file or directory
Makefile:1067: ../../../pgadmin/pgscript/expressions/.deps/pgsIdent.Po: No such file or directory
Makefile:1068: ../../../pgadmin/pgscript/expressions/.deps/pgsIdentRecord.Po: No such file or directory
Makefile:1069: ../../../pgadmin/pgscript/expressions/.deps/pgsLines.Po: No such file or directory
Makefile:1070: ../../../pgadmin/pgscript/expressions/.deps/pgsLower.Po: No such file or directory
Makefile:1071: ../../../pgadmin/pgscript/expressions/.deps/pgsLowerEqual.Po: No such file or directory
Makefile:1072: ../../../pgadmin/pgscript/expressions/.deps/pgsMinus.Po: No such file or directory
Makefile:1073: ../../../pgadmin/pgscript/expressions/.deps/pgsModulo.Po: No such file or directory
Makefile:1074: ../../../pgadmin/pgscript/expressions/.deps/pgsNegate.Po: No such file or directory
Makefile:1075: ../../../pgadmin/pgscript/expressions/.deps/pgsNot.Po: No such file or directory
Makefile:1076: ../../../pgadmin/pgscript/expressions/.deps/pgsOperation.Po: No such file or directory
Makefile:1077: ../../../pgadmin/pgscript/expressions/.deps/pgsOr.Po: No such file or directory
Makefile:1078: ../../../pgadmin/pgscript/expressions/.deps/pgsOver.Po: No such file or directory
Makefile:1079: ../../../pgadmin/pgscript/expressions/.deps/pgsParenthesis.Po: No such file or directory
Makefile:1080: ../../../pgadmin/pgscript/expressions/.deps/pgsPlus.Po: No such file or directory
Makefile:1081: ../../../pgadmin/pgscript/expressions/.deps/pgsRemoveLine.Po: No such file or directory
Makefile:1082: ../../../pgadmin/pgscript/expressions/.deps/pgsTimes.Po: No such file or directory
Makefile:1083: ../../../pgadmin/pgscript/expressions/.deps/pgsTrim.Po: No such file or directory
Makefile:1084: ../../../pgadmin/pgscript/generators/.deps/pgsDateGen.Po: No such file or directory
Makefile:1085: ../../../pgadmin/pgscript/generators/.deps/pgsDateTimeGen.Po: No such file or directory
Makefile:1086: ../../../pgadmin/pgscript/generators/.deps/pgsDictionaryGen.Po: No such file or directory
Makefile:1087: ../../../pgadmin/pgscript/generators/.deps/pgsIntegerGen.Po: No such file or directory
Makefile:1088: ../../../pgadmin/pgscript/generators/.deps/pgsNumberGen.Po: No such file or directory
Makefile:1089: ../../../pgadmin/pgscript/generators/.deps/pgsObjectGen.Po: No such file or directory
Makefile:1090: ../../../pgadmin/pgscript/generators/.deps/pgsRealGen.Po: No such file or directory
Makefile:1091: ../../../pgadmin/pgscript/generators/.deps/pgsReferenceGen.Po: No such file or directory
Makefile:1092: ../../../pgadmin/pgscript/generators/.deps/pgsRegexGen.Po: No such file or directory
Makefile:1093: ../../../pgadmin/pgscript/generators/.deps/pgsStringGen.Po: No such file or directory
Makefile:1094: ../../../pgadmin/pgscript/generators/.deps/pgsTimeGen.Po: No such file or directory
Makefile:1095: ../../../pgadmin/pgscript/objects/.deps/pgsGenerator.Po: No such file or directory
Makefile:1096: ../../../pgadmin/pgscript/objects/.deps/pgsNumber.Po: No such file or directory
Makefile:1097: ../../../pgadmin/pgscript/objects/.deps/pgsRecord.Po: No such file or directory
Makefile:1098: ../../../pgadmin/pgscript/objects/.deps/pgsString.Po: No such file or directory
Makefile:1099: ../../../pgadmin/pgscript/objects/.deps/pgsVariable.Po: No such file or directory
Makefile:1100: ../../../pgadmin/pgscript/statements/.deps/pgsAssertStmt.Po: No such file or directory
Makefile:1101: ../../../pgadmin/pgscript/statements/.deps/pgsBreakStmt.Po: No such file or directory
Makefile:1102: ../../../pgadmin/pgscript/statements/.deps/pgsContinueStmt.Po: No such file or directory
Makefile:1103: ../../../pgadmin/pgscript/statements/.deps/pgsDeclareRecordStmt.Po: No such file or directory
Makefile:1104: ../../../pgadmin/pgscript/statements/.deps/pgsExpressionStmt.Po: No such file or directory
Makefile:1105: ../../../pgadmin/pgscript/statements/.deps/pgsIfStmt.Po: No such file or directory
Makefile:1106: ../../../pgadmin/pgscript/statements/.deps/pgsPrintStmt.Po: No such file or directory
Makefile:1107: ../../../pgadmin/pgscript/statements/.deps/pgsProgram.Po: No such file or directory
Makefile:1108: ../../../pgadmin/pgscript/statements/.deps/pgsStmt.Po: No such file or directory
Makefile:1109: ../../../pgadmin/pgscript/statements/.deps/pgsStmtList.Po: No such file or directory
Makefile:1110: ../../../pgadmin/pgscript/statements/.deps/pgsWhileStmt.Po: No such file or directory
Makefile:1111: ../../../pgadmin/pgscript/utilities/.deps/pgsAlloc.Po: No such file or directory
Makefile:1112: ../../../pgadmin/pgscript/utilities/.deps/pgsContext.Po: No such file or directory
Makefile:1113: ../../../pgadmin/pgscript/utilities/.deps/pgsDriver.Po: No such file or directory
Makefile:1114: ../../../pgadmin/pgscript/utilities/.deps/pgsMapm.Po: No such file or directory
Makefile:1115: ../../../pgadmin/pgscript/utilities/.deps/pgsThread.Po: No such file or directory
Makefile:1116: ../../../pgadmin/pgscript/utilities/.deps/pgsUtilities.Po: No such file or directory
Makefile:1117: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm5sin.Po: No such file or directory
Makefile:1118: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_add.Po: No such file or directory
Makefile:1119: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_cpi.Po: No such file or directory
Makefile:1120: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_div.Po: No such file or directory
Makefile:1121: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_exp.Po: No such file or directory
Makefile:1122: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fam.Po: No such file or directory
Makefile:1123: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fft.Po: No such file or directory
Makefile:1124: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_flr.Po: No such file or directory
Makefile:1125: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fpf.Po: No such file or directory
Makefile:1126: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_gcd.Po: No such file or directory
Makefile:1127: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg2.Po: No such file or directory
Makefile:1128: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg3.Po: No such file or directory
Makefile:1129: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg4.Po: No such file or directory
Makefile:1130: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_log.Po: No such file or directory
Makefile:1131: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_mul.Po: No such file or directory
Makefile:1132: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_pow.Po: No such file or directory
Makefile:1133: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rcp.Po: No such file or directory
Makefile:1134: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rnd.Po: No such file or directory
Makefile:1135: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_set.Po: No such file or directory
Makefile:1136: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_sin.Po: No such file or directory
Makefile:1137: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasin.Po: No such file or directory
Makefile:1138: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasn0.Po: No such file or directory
Makefile:1139: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcbrt.Po: No such file or directory
Makefile:1140: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcnst.Po: No such file or directory
Makefile:1141: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfact.Po: No such file or directory
Makefile:1142: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfmul.Po: No such file or directory
Makefile:1143: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmgues.Po: No such file or directory
Makefile:1144: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhasn.Po: No such file or directory
Makefile:1145: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhsin.Po: No such file or directory
Makefile:1146: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmipwr.Po: No such file or directory
Makefile:1147: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmistr.Po: No such file or directory
Makefile:1148: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmpwr2.Po: No such file or directory
Makefile:1149: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmrsin.Po: No such file or directory
Makefile:1150: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmsqrt.Po: No such file or directory
Makefile:1151: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmstck.Po: No such file or directory
Makefile:1152: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutil.Po: No such file or directory
Makefile:1153: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl1.Po: No such file or directory
Makefile:1154: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl2.Po: No such file or directory
Makefile:1155: ../../../pgadmin/utils/.deps/misc.Po: No such file or directory
Makefile:1156: ../../../pgadmin/utils/.deps/sysLogger.Po: No such file or directory
make[3]: *** No rule to make target `../../../pgadmin/utils/.deps/sysLogger.Po'.  Stop.
make[2]: *** [distclean-recursive] Error 1
make[1]: *** [distclean-recursive] Error 1
make: *** [distclean-recursive] Error 1


On Wed, May 8, 2013 at 10:24 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Ashesh Vashi
Date:
Hi Dave,

I needed to modify the configuration at quite a lot places to make it work properly.
And, looks like the pgscript has not been compiled by anyone from long time and I can say that because, it has been horribly broken.
If we're going to support the stand-alone pgscript application, we will need to modify the code accordingly.
There are many changes done in the pgadmin3 code, which are shared by pgscript. And, we've not taken care about pgscript affected areas.

Also - the subdir-object changes (in configuration) had introduced the dependency on the actual objects for each target (Here - pgscript and pgadmin3), because the objects are getting generated in the respective directories instead of target directory. And, that dependency leads to this distclean issue, because the source/object files are shared between this two targets, and that too in different Makefiles, and one of the target cleans those objects, other can not find it.
It is not able to identify two targets using the same objects (and, enable the renaming of objects never comes into picture, not even if we set the _SHORTNAME property for those targets. reference: http://www.gnu.org/software/automake/manual/html_node/Renamed-Objects.html)
And, because of the dependency on actual objects, they're not regenerating the objects, which they must because they do have different CXXFLAGS.

For the moment, I have fixed the 'make distclean' and cleaned up the configurations. Also - I've introduced the new object extension (.pgso) in pgscript Makefile.am to enable it to build separate object files from pgadmin3.

Though - need some more work to resolve the pgscript compilation issue.
We can do it later (if nobody is using it at the moment.)

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: 
Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

On Wed, May 8, 2013 at 5:09 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied.

When testing this, I noticed that the distclean target seems to be broken now. Can you (or one of the team) please take a look? Thanks.

viper:pgadmin3 dpage$ make distclean
Making distclean in xtra/png2c
make[1]: Nothing to be done for `distclean'.
Making distclean in branding
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in i18n
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in plugins.d
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in pgadmin
test -z "pgadmin3" || rm -f pgadmin3
rm -f include/images/*.pngc
rm -f *.o
rm -f *.tab.c
test -z "" || rm -f 
rm -f agent/*.o
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f 
rm -f ctl/*.o
rm -f agent/.deps/.dirstamp
rm -f agent/.dirstamp
rm -f ctl/.deps/.dirstamp
rm -f db/*.o
rm -f ctl/.dirstamp
rm -f db/.deps/.dirstamp
rm -f db/.dirstamp
rm -f dd/dditems/figures/*.o
rm -f dd/dditems/figures/.deps/.dirstamp
rm -f dd/dditems/figures/.dirstamp
rm -f dd/dditems/figures/xml/.deps/.dirstamp
rm -f dd/dditems/figures/xml/*.o
rm -f dd/dditems/figures/xml/.dirstamp
rm -f dd/dditems/handles/.deps/.dirstamp
rm -f dd/dditems/handles/*.o
rm -f dd/dditems/handles/.dirstamp
rm -f dd/dditems/locators/.deps/.dirstamp
rm -f dd/dditems/locators/.dirstamp
rm -f dd/dditems/locators/*.o
rm -f dd/dditems/tools/.deps/.dirstamp
rm -f dd/dditems/tools/.dirstamp
rm -f dd/dditems/utilities/.deps/.dirstamp
rm -f dd/dditems/tools/*.o
rm -f dd/dditems/utilities/.dirstamp
rm -f dd/ddmodel/.deps/.dirstamp
rm -f dd/dditems/utilities/*.o
rm -f dd/ddmodel/.dirstamp
rm -f debugger/.deps/.dirstamp
rm -f dd/ddmodel/*.o
rm -f debugger/.dirstamp
rm -f dlg/.deps/.dirstamp
rm -f dlg/.dirstamp
rm -f debugger/*.o
rm -f frm/.deps/.dirstamp
rm -f frm/.dirstamp
rm -f dlg/*.o
rm -f gqb/.deps/.dirstamp
rm -f gqb/.dirstamp
rm -f hotdraw/connectors/.deps/.dirstamp
rm -f hotdraw/connectors/.dirstamp
rm -f hotdraw/figures/.deps/.dirstamp
rm -f hotdraw/figures/.dirstamp
rm -f frm/*.o
rm -f hotdraw/figures/defaultAttributes/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/.dirstamp
rm -f hotdraw/figures/xml/.deps/.dirstamp
rm -f gqb/*.o
rm -f hotdraw/figures/xml/.dirstamp
rm -f hotdraw/handles/.deps/.dirstamp
rm -f hotdraw/handles/.dirstamp
rm -f hotdraw/connectors/*.o
rm -f hotdraw/locators/.deps/.dirstamp
rm -f hotdraw/locators/.dirstamp
rm -f hotdraw/figures/*.o
rm -f hotdraw/main/.deps/.dirstamp
rm -f hotdraw/main/.dirstamp
rm -f hotdraw/tools/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/*.o
rm -f hotdraw/tools/.dirstamp
rm -f hotdraw/utilities/.deps/.dirstamp
rm -f hotdraw/figures/xml/*.o
rm -f hotdraw/utilities/.dirstamp
rm -f libssh2/.deps/.dirstamp
rm -f libssh2/.dirstamp
rm -f hotdraw/handles/*.o
rm -f ogl/.deps/.dirstamp
rm -f ogl/.dirstamp
rm -f hotdraw/locators/*.o
rm -f pgscript/.deps/.dirstamp
rm -f pgscript/.dirstamp
rm -f hotdraw/main/*.o
rm -f pgscript/exceptions/.deps/.dirstamp
rm -f pgscript/exceptions/.dirstamp
rm -f pgscript/expressions/.deps/.dirstamp
rm -f hotdraw/tools/*.o
rm -f pgscript/expressions/.dirstamp
rm -f pgscript/generators/.deps/.dirstamp
rm -f hotdraw/utilities/*.o
rm -f pgscript/generators/.dirstamp
rm -f pgscript/objects/.deps/.dirstamp
rm -f pgscript/objects/.dirstamp
rm -f libssh2/*.o
rm -f pgscript/statements/.deps/.dirstamp
rm -f pgscript/statements/.dirstamp
rm -f pgscript/utilities/.deps/.dirstamp
rm -f ogl/*.o
rm -f pgscript/utilities/.dirstamp
rm -f pgscript/utilities/m_apm/.deps/.dirstamp
rm -f pgscript/utilities/m_apm/.dirstamp
rm -f pgscript/*.o
rm -f schema/.deps/.dirstamp
rm -f schema/.dirstamp
rm -f pgscript/exceptions/*.o
rm -f slony/.deps/.dirstamp
rm -f slony/.dirstamp
rm -f ui/.deps/.dirstamp
rm -f pgscript/expressions/*.o
rm -f ui/.dirstamp
rm -f utils/.deps/.dirstamp
rm -f utils/.dirstamp
rm -f pgscript/generators/*.o
rm -f pgscript/objects/*.o
rm -f pgscript/statements/*.o
rm -f pgscript/utilities/*.o
rm -f pgscript/utilities/m_apm/*.o
rm -f schema/*.o
rm -f slony/*.o
rm -f ui/*.o
rm -f utils/*.o
rm -rf ./.deps agent/.deps ctl/.deps db/.deps dd/dditems/figures/.deps dd/dditems/figures/xml/.deps dd/dditems/handles/.deps dd/dditems/locators/.deps dd/dditems/tools/.deps dd/dditems/utilities/.deps dd/ddmodel/.deps debugger/.deps dlg/.deps frm/.deps gqb/.deps hotdraw/connectors/.deps hotdraw/figures/.deps hotdraw/figures/defaultAttributes/.deps hotdraw/figures/xml/.deps hotdraw/handles/.deps hotdraw/locators/.deps hotdraw/main/.deps hotdraw/tools/.deps hotdraw/utilities/.deps libssh2/.deps ogl/.deps pgscript/.deps pgscript/exceptions/.deps pgscript/expressions/.deps pgscript/generators/.deps pgscript/objects/.deps pgscript/statements/.deps pgscript/utilities/.deps pgscript/utilities/m_apm/.deps schema/.deps slony/.deps ui/.deps utils/.deps
rm -f Makefile
Making distclean in xtra
Making distclean in png2c
make[2]: Nothing to be done for `distclean'.
Making distclean in pgscript
Making distclean in lib
Makefile:1032: ../../../pgadmin/db/.deps/keywords.Po: No such file or directory
Makefile:1033: ../../../pgadmin/db/.deps/pgConn.Po: No such file or directory
Makefile:1034: ../../../pgadmin/db/.deps/pgQueryThread.Po: No such file or directory
Makefile:1035: ../../../pgadmin/db/.deps/pgSet.Po: No such file or directory
Makefile:1036: ../../../pgadmin/pgscript/.deps/lex.pgs.Po: No such file or directory
Makefile:1037: ../../../pgadmin/pgscript/.deps/parser.tab.Po: No such file or directory
Makefile:1038: ../../../pgadmin/pgscript/.deps/pgsApplication.Po: No such file or directory
Makefile:1039: ../../../pgadmin/pgscript/exceptions/.deps/pgsArithmeticException.Po: No such file or directory
Makefile:1040: ../../../pgadmin/pgscript/exceptions/.deps/pgsAssertException.Po: No such file or directory
Makefile:1041: ../../../pgadmin/pgscript/exceptions/.deps/pgsBreakException.Po: No such file or directory
Makefile:1042: ../../../pgadmin/pgscript/exceptions/.deps/pgsCastException.Po: No such file or directory
Makefile:1043: ../../../pgadmin/pgscript/exceptions/.deps/pgsContinueException.Po: No such file or directory
Makefile:1044: ../../../pgadmin/pgscript/exceptions/.deps/pgsException.Po: No such file or directory
Makefile:1045: ../../../pgadmin/pgscript/exceptions/.deps/pgsInterruptException.Po: No such file or directory
Makefile:1046: ../../../pgadmin/pgscript/exceptions/.deps/pgsParameterException.Po: No such file or directory
Makefile:1047: ../../../pgadmin/pgscript/expressions/.deps/pgsAnd.Po: No such file or directory
Makefile:1048: ../../../pgadmin/pgscript/expressions/.deps/pgsAssign.Po: No such file or directory
Makefile:1049: ../../../pgadmin/pgscript/expressions/.deps/pgsAssignToRecord.Po: No such file or directory
Makefile:1050: ../../../pgadmin/pgscript/expressions/.deps/pgsCast.Po: No such file or directory
Makefile:1051: ../../../pgadmin/pgscript/expressions/.deps/pgsColumns.Po: No such file or directory
Makefile:1052: ../../../pgadmin/pgscript/expressions/.deps/pgsDifferent.Po: No such file or directory
Makefile:1053: ../../../pgadmin/pgscript/expressions/.deps/pgsEqual.Po: No such file or directory
Makefile:1054: ../../../pgadmin/pgscript/expressions/.deps/pgsExecute.Po: No such file or directory
Makefile:1055: ../../../pgadmin/pgscript/expressions/.deps/pgsExpression.Po: No such file or directory
Makefile:1056: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDate.Po: No such file or directory
Makefile:1057: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDateTime.Po: No such file or directory
Makefile:1058: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDictionary.Po: No such file or directory
Makefile:1059: ../../../pgadmin/pgscript/expressions/.deps/pgsGenInt.Po: No such file or directory
Makefile:1060: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReal.Po: No such file or directory
Makefile:1061: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReference.Po: No such file or directory
Makefile:1062: ../../../pgadmin/pgscript/expressions/.deps/pgsGenRegex.Po: No such file or directory
Makefile:1063: ../../../pgadmin/pgscript/expressions/.deps/pgsGenString.Po: No such file or directory
Makefile:1064: ../../../pgadmin/pgscript/expressions/.deps/pgsGenTime.Po: No such file or directory
Makefile:1065: ../../../pgadmin/pgscript/expressions/.deps/pgsGreater.Po: No such file or directory
Makefile:1066: ../../../pgadmin/pgscript/expressions/.deps/pgsGreaterEqual.Po: No such file or directory
Makefile:1067: ../../../pgadmin/pgscript/expressions/.deps/pgsIdent.Po: No such file or directory
Makefile:1068: ../../../pgadmin/pgscript/expressions/.deps/pgsIdentRecord.Po: No such file or directory
Makefile:1069: ../../../pgadmin/pgscript/expressions/.deps/pgsLines.Po: No such file or directory
Makefile:1070: ../../../pgadmin/pgscript/expressions/.deps/pgsLower.Po: No such file or directory
Makefile:1071: ../../../pgadmin/pgscript/expressions/.deps/pgsLowerEqual.Po: No such file or directory
Makefile:1072: ../../../pgadmin/pgscript/expressions/.deps/pgsMinus.Po: No such file or directory
Makefile:1073: ../../../pgadmin/pgscript/expressions/.deps/pgsModulo.Po: No such file or directory
Makefile:1074: ../../../pgadmin/pgscript/expressions/.deps/pgsNegate.Po: No such file or directory
Makefile:1075: ../../../pgadmin/pgscript/expressions/.deps/pgsNot.Po: No such file or directory
Makefile:1076: ../../../pgadmin/pgscript/expressions/.deps/pgsOperation.Po: No such file or directory
Makefile:1077: ../../../pgadmin/pgscript/expressions/.deps/pgsOr.Po: No such file or directory
Makefile:1078: ../../../pgadmin/pgscript/expressions/.deps/pgsOver.Po: No such file or directory
Makefile:1079: ../../../pgadmin/pgscript/expressions/.deps/pgsParenthesis.Po: No such file or directory
Makefile:1080: ../../../pgadmin/pgscript/expressions/.deps/pgsPlus.Po: No such file or directory
Makefile:1081: ../../../pgadmin/pgscript/expressions/.deps/pgsRemoveLine.Po: No such file or directory
Makefile:1082: ../../../pgadmin/pgscript/expressions/.deps/pgsTimes.Po: No such file or directory
Makefile:1083: ../../../pgadmin/pgscript/expressions/.deps/pgsTrim.Po: No such file or directory
Makefile:1084: ../../../pgadmin/pgscript/generators/.deps/pgsDateGen.Po: No such file or directory
Makefile:1085: ../../../pgadmin/pgscript/generators/.deps/pgsDateTimeGen.Po: No such file or directory
Makefile:1086: ../../../pgadmin/pgscript/generators/.deps/pgsDictionaryGen.Po: No such file or directory
Makefile:1087: ../../../pgadmin/pgscript/generators/.deps/pgsIntegerGen.Po: No such file or directory
Makefile:1088: ../../../pgadmin/pgscript/generators/.deps/pgsNumberGen.Po: No such file or directory
Makefile:1089: ../../../pgadmin/pgscript/generators/.deps/pgsObjectGen.Po: No such file or directory
Makefile:1090: ../../../pgadmin/pgscript/generators/.deps/pgsRealGen.Po: No such file or directory
Makefile:1091: ../../../pgadmin/pgscript/generators/.deps/pgsReferenceGen.Po: No such file or directory
Makefile:1092: ../../../pgadmin/pgscript/generators/.deps/pgsRegexGen.Po: No such file or directory
Makefile:1093: ../../../pgadmin/pgscript/generators/.deps/pgsStringGen.Po: No such file or directory
Makefile:1094: ../../../pgadmin/pgscript/generators/.deps/pgsTimeGen.Po: No such file or directory
Makefile:1095: ../../../pgadmin/pgscript/objects/.deps/pgsGenerator.Po: No such file or directory
Makefile:1096: ../../../pgadmin/pgscript/objects/.deps/pgsNumber.Po: No such file or directory
Makefile:1097: ../../../pgadmin/pgscript/objects/.deps/pgsRecord.Po: No such file or directory
Makefile:1098: ../../../pgadmin/pgscript/objects/.deps/pgsString.Po: No such file or directory
Makefile:1099: ../../../pgadmin/pgscript/objects/.deps/pgsVariable.Po: No such file or directory
Makefile:1100: ../../../pgadmin/pgscript/statements/.deps/pgsAssertStmt.Po: No such file or directory
Makefile:1101: ../../../pgadmin/pgscript/statements/.deps/pgsBreakStmt.Po: No such file or directory
Makefile:1102: ../../../pgadmin/pgscript/statements/.deps/pgsContinueStmt.Po: No such file or directory
Makefile:1103: ../../../pgadmin/pgscript/statements/.deps/pgsDeclareRecordStmt.Po: No such file or directory
Makefile:1104: ../../../pgadmin/pgscript/statements/.deps/pgsExpressionStmt.Po: No such file or directory
Makefile:1105: ../../../pgadmin/pgscript/statements/.deps/pgsIfStmt.Po: No such file or directory
Makefile:1106: ../../../pgadmin/pgscript/statements/.deps/pgsPrintStmt.Po: No such file or directory
Makefile:1107: ../../../pgadmin/pgscript/statements/.deps/pgsProgram.Po: No such file or directory
Makefile:1108: ../../../pgadmin/pgscript/statements/.deps/pgsStmt.Po: No such file or directory
Makefile:1109: ../../../pgadmin/pgscript/statements/.deps/pgsStmtList.Po: No such file or directory
Makefile:1110: ../../../pgadmin/pgscript/statements/.deps/pgsWhileStmt.Po: No such file or directory
Makefile:1111: ../../../pgadmin/pgscript/utilities/.deps/pgsAlloc.Po: No such file or directory
Makefile:1112: ../../../pgadmin/pgscript/utilities/.deps/pgsContext.Po: No such file or directory
Makefile:1113: ../../../pgadmin/pgscript/utilities/.deps/pgsDriver.Po: No such file or directory
Makefile:1114: ../../../pgadmin/pgscript/utilities/.deps/pgsMapm.Po: No such file or directory
Makefile:1115: ../../../pgadmin/pgscript/utilities/.deps/pgsThread.Po: No such file or directory
Makefile:1116: ../../../pgadmin/pgscript/utilities/.deps/pgsUtilities.Po: No such file or directory
Makefile:1117: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm5sin.Po: No such file or directory
Makefile:1118: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_add.Po: No such file or directory
Makefile:1119: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_cpi.Po: No such file or directory
Makefile:1120: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_div.Po: No such file or directory
Makefile:1121: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_exp.Po: No such file or directory
Makefile:1122: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fam.Po: No such file or directory
Makefile:1123: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fft.Po: No such file or directory
Makefile:1124: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_flr.Po: No such file or directory
Makefile:1125: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fpf.Po: No such file or directory
Makefile:1126: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_gcd.Po: No such file or directory
Makefile:1127: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg2.Po: No such file or directory
Makefile:1128: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg3.Po: No such file or directory
Makefile:1129: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg4.Po: No such file or directory
Makefile:1130: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_log.Po: No such file or directory
Makefile:1131: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_mul.Po: No such file or directory
Makefile:1132: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_pow.Po: No such file or directory
Makefile:1133: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rcp.Po: No such file or directory
Makefile:1134: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rnd.Po: No such file or directory
Makefile:1135: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_set.Po: No such file or directory
Makefile:1136: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_sin.Po: No such file or directory
Makefile:1137: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasin.Po: No such file or directory
Makefile:1138: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasn0.Po: No such file or directory
Makefile:1139: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcbrt.Po: No such file or directory
Makefile:1140: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcnst.Po: No such file or directory
Makefile:1141: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfact.Po: No such file or directory
Makefile:1142: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfmul.Po: No such file or directory
Makefile:1143: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmgues.Po: No such file or directory
Makefile:1144: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhasn.Po: No such file or directory
Makefile:1145: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhsin.Po: No such file or directory
Makefile:1146: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmipwr.Po: No such file or directory
Makefile:1147: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmistr.Po: No such file or directory
Makefile:1148: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmpwr2.Po: No such file or directory
Makefile:1149: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmrsin.Po: No such file or directory
Makefile:1150: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmsqrt.Po: No such file or directory
Makefile:1151: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmstck.Po: No such file or directory
Makefile:1152: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutil.Po: No such file or directory
Makefile:1153: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl1.Po: No such file or directory
Makefile:1154: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl2.Po: No such file or directory
Makefile:1155: ../../../pgadmin/utils/.deps/misc.Po: No such file or directory
Makefile:1156: ../../../pgadmin/utils/.deps/sysLogger.Po: No such file or directory
make[3]: *** No rule to make target `../../../pgadmin/utils/.deps/sysLogger.Po'.  Stop.
make[2]: *** [distclean-recursive] Error 1
make[1]: *** [distclean-recursive] Error 1
make: *** [distclean-recursive] Error 1


On Wed, May 8, 2013 at 10:24 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Dave Page
Date:
Hi



On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

I needed to modify the configuration at quite a lot places to make it work properly.
And, looks like the pgscript has not been compiled by anyone from long time and I can say that because, it has been horribly broken.
If we're going to support the stand-alone pgscript application, we will need to modify the code accordingly.
There are many changes done in the pgadmin3 code, which are shared by pgscript. And, we've not taken care about pgscript affected areas.

Honestly, I don't think we need to keep that there. pgScript was originally written as a GSOC project by Mickael Deloison, and later added to pgAdmin as a second project (iirc, Magnus mentored). We included the command line interpretor just to give it a home, but as it hasn't been touched since it was added and isn't used for anything it should probably go.

Any comments Magnus, Mickael?

How much would that cleanup the patch you've submitted Ashesh? At a quick glance I guess at least the last hunk would be redundant.
 

Also - the subdir-object changes (in configuration) had introduced the dependency on the actual objects for each target (Here - pgscript and pgadmin3), because the objects are getting generated in the respective directories instead of target directory. And, that dependency leads to this distclean issue, because the source/object files are shared between this two targets, and that too in different Makefiles, and one of the target cleans those objects, other can not find it.
It is not able to identify two targets using the same objects (and, enable the renaming of objects never comes into picture, not even if we set the _SHORTNAME property for those targets. reference: http://www.gnu.org/software/automake/manual/html_node/Renamed-Objects.html)
And, because of the dependency on actual objects, they're not regenerating the objects, which they must because they do have different CXXFLAGS.

For the moment, I have fixed the 'make distclean' and cleaned up the configurations. Also - I've introduced the new object extension (.pgso) in pgscript Makefile.am to enable it to build separate object files from pgadmin3.

Though - need some more work to resolve the pgscript compilation issue.
We can do it later (if nobody is using it at the moment.)

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: 
Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

On Wed, May 8, 2013 at 5:09 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied.

When testing this, I noticed that the distclean target seems to be broken now. Can you (or one of the team) please take a look? Thanks.

viper:pgadmin3 dpage$ make distclean
Making distclean in xtra/png2c
make[1]: Nothing to be done for `distclean'.
Making distclean in branding
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in i18n
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in plugins.d
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in pgadmin
test -z "pgadmin3" || rm -f pgadmin3
rm -f include/images/*.pngc
rm -f *.o
rm -f *.tab.c
test -z "" || rm -f 
rm -f agent/*.o
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f 
rm -f ctl/*.o
rm -f agent/.deps/.dirstamp
rm -f agent/.dirstamp
rm -f ctl/.deps/.dirstamp
rm -f db/*.o
rm -f ctl/.dirstamp
rm -f db/.deps/.dirstamp
rm -f db/.dirstamp
rm -f dd/dditems/figures/*.o
rm -f dd/dditems/figures/.deps/.dirstamp
rm -f dd/dditems/figures/.dirstamp
rm -f dd/dditems/figures/xml/.deps/.dirstamp
rm -f dd/dditems/figures/xml/*.o
rm -f dd/dditems/figures/xml/.dirstamp
rm -f dd/dditems/handles/.deps/.dirstamp
rm -f dd/dditems/handles/*.o
rm -f dd/dditems/handles/.dirstamp
rm -f dd/dditems/locators/.deps/.dirstamp
rm -f dd/dditems/locators/.dirstamp
rm -f dd/dditems/locators/*.o
rm -f dd/dditems/tools/.deps/.dirstamp
rm -f dd/dditems/tools/.dirstamp
rm -f dd/dditems/utilities/.deps/.dirstamp
rm -f dd/dditems/tools/*.o
rm -f dd/dditems/utilities/.dirstamp
rm -f dd/ddmodel/.deps/.dirstamp
rm -f dd/dditems/utilities/*.o
rm -f dd/ddmodel/.dirstamp
rm -f debugger/.deps/.dirstamp
rm -f dd/ddmodel/*.o
rm -f debugger/.dirstamp
rm -f dlg/.deps/.dirstamp
rm -f dlg/.dirstamp
rm -f debugger/*.o
rm -f frm/.deps/.dirstamp
rm -f frm/.dirstamp
rm -f dlg/*.o
rm -f gqb/.deps/.dirstamp
rm -f gqb/.dirstamp
rm -f hotdraw/connectors/.deps/.dirstamp
rm -f hotdraw/connectors/.dirstamp
rm -f hotdraw/figures/.deps/.dirstamp
rm -f hotdraw/figures/.dirstamp
rm -f frm/*.o
rm -f hotdraw/figures/defaultAttributes/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/.dirstamp
rm -f hotdraw/figures/xml/.deps/.dirstamp
rm -f gqb/*.o
rm -f hotdraw/figures/xml/.dirstamp
rm -f hotdraw/handles/.deps/.dirstamp
rm -f hotdraw/handles/.dirstamp
rm -f hotdraw/connectors/*.o
rm -f hotdraw/locators/.deps/.dirstamp
rm -f hotdraw/locators/.dirstamp
rm -f hotdraw/figures/*.o
rm -f hotdraw/main/.deps/.dirstamp
rm -f hotdraw/main/.dirstamp
rm -f hotdraw/tools/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/*.o
rm -f hotdraw/tools/.dirstamp
rm -f hotdraw/utilities/.deps/.dirstamp
rm -f hotdraw/figures/xml/*.o
rm -f hotdraw/utilities/.dirstamp
rm -f libssh2/.deps/.dirstamp
rm -f libssh2/.dirstamp
rm -f hotdraw/handles/*.o
rm -f ogl/.deps/.dirstamp
rm -f ogl/.dirstamp
rm -f hotdraw/locators/*.o
rm -f pgscript/.deps/.dirstamp
rm -f pgscript/.dirstamp
rm -f hotdraw/main/*.o
rm -f pgscript/exceptions/.deps/.dirstamp
rm -f pgscript/exceptions/.dirstamp
rm -f pgscript/expressions/.deps/.dirstamp
rm -f hotdraw/tools/*.o
rm -f pgscript/expressions/.dirstamp
rm -f pgscript/generators/.deps/.dirstamp
rm -f hotdraw/utilities/*.o
rm -f pgscript/generators/.dirstamp
rm -f pgscript/objects/.deps/.dirstamp
rm -f pgscript/objects/.dirstamp
rm -f libssh2/*.o
rm -f pgscript/statements/.deps/.dirstamp
rm -f pgscript/statements/.dirstamp
rm -f pgscript/utilities/.deps/.dirstamp
rm -f ogl/*.o
rm -f pgscript/utilities/.dirstamp
rm -f pgscript/utilities/m_apm/.deps/.dirstamp
rm -f pgscript/utilities/m_apm/.dirstamp
rm -f pgscript/*.o
rm -f schema/.deps/.dirstamp
rm -f schema/.dirstamp
rm -f pgscript/exceptions/*.o
rm -f slony/.deps/.dirstamp
rm -f slony/.dirstamp
rm -f ui/.deps/.dirstamp
rm -f pgscript/expressions/*.o
rm -f ui/.dirstamp
rm -f utils/.deps/.dirstamp
rm -f utils/.dirstamp
rm -f pgscript/generators/*.o
rm -f pgscript/objects/*.o
rm -f pgscript/statements/*.o
rm -f pgscript/utilities/*.o
rm -f pgscript/utilities/m_apm/*.o
rm -f schema/*.o
rm -f slony/*.o
rm -f ui/*.o
rm -f utils/*.o
rm -rf ./.deps agent/.deps ctl/.deps db/.deps dd/dditems/figures/.deps dd/dditems/figures/xml/.deps dd/dditems/handles/.deps dd/dditems/locators/.deps dd/dditems/tools/.deps dd/dditems/utilities/.deps dd/ddmodel/.deps debugger/.deps dlg/.deps frm/.deps gqb/.deps hotdraw/connectors/.deps hotdraw/figures/.deps hotdraw/figures/defaultAttributes/.deps hotdraw/figures/xml/.deps hotdraw/handles/.deps hotdraw/locators/.deps hotdraw/main/.deps hotdraw/tools/.deps hotdraw/utilities/.deps libssh2/.deps ogl/.deps pgscript/.deps pgscript/exceptions/.deps pgscript/expressions/.deps pgscript/generators/.deps pgscript/objects/.deps pgscript/statements/.deps pgscript/utilities/.deps pgscript/utilities/m_apm/.deps schema/.deps slony/.deps ui/.deps utils/.deps
rm -f Makefile
Making distclean in xtra
Making distclean in png2c
make[2]: Nothing to be done for `distclean'.
Making distclean in pgscript
Making distclean in lib
Makefile:1032: ../../../pgadmin/db/.deps/keywords.Po: No such file or directory
Makefile:1033: ../../../pgadmin/db/.deps/pgConn.Po: No such file or directory
Makefile:1034: ../../../pgadmin/db/.deps/pgQueryThread.Po: No such file or directory
Makefile:1035: ../../../pgadmin/db/.deps/pgSet.Po: No such file or directory
Makefile:1036: ../../../pgadmin/pgscript/.deps/lex.pgs.Po: No such file or directory
Makefile:1037: ../../../pgadmin/pgscript/.deps/parser.tab.Po: No such file or directory
Makefile:1038: ../../../pgadmin/pgscript/.deps/pgsApplication.Po: No such file or directory
Makefile:1039: ../../../pgadmin/pgscript/exceptions/.deps/pgsArithmeticException.Po: No such file or directory
Makefile:1040: ../../../pgadmin/pgscript/exceptions/.deps/pgsAssertException.Po: No such file or directory
Makefile:1041: ../../../pgadmin/pgscript/exceptions/.deps/pgsBreakException.Po: No such file or directory
Makefile:1042: ../../../pgadmin/pgscript/exceptions/.deps/pgsCastException.Po: No such file or directory
Makefile:1043: ../../../pgadmin/pgscript/exceptions/.deps/pgsContinueException.Po: No such file or directory
Makefile:1044: ../../../pgadmin/pgscript/exceptions/.deps/pgsException.Po: No such file or directory
Makefile:1045: ../../../pgadmin/pgscript/exceptions/.deps/pgsInterruptException.Po: No such file or directory
Makefile:1046: ../../../pgadmin/pgscript/exceptions/.deps/pgsParameterException.Po: No such file or directory
Makefile:1047: ../../../pgadmin/pgscript/expressions/.deps/pgsAnd.Po: No such file or directory
Makefile:1048: ../../../pgadmin/pgscript/expressions/.deps/pgsAssign.Po: No such file or directory
Makefile:1049: ../../../pgadmin/pgscript/expressions/.deps/pgsAssignToRecord.Po: No such file or directory
Makefile:1050: ../../../pgadmin/pgscript/expressions/.deps/pgsCast.Po: No such file or directory
Makefile:1051: ../../../pgadmin/pgscript/expressions/.deps/pgsColumns.Po: No such file or directory
Makefile:1052: ../../../pgadmin/pgscript/expressions/.deps/pgsDifferent.Po: No such file or directory
Makefile:1053: ../../../pgadmin/pgscript/expressions/.deps/pgsEqual.Po: No such file or directory
Makefile:1054: ../../../pgadmin/pgscript/expressions/.deps/pgsExecute.Po: No such file or directory
Makefile:1055: ../../../pgadmin/pgscript/expressions/.deps/pgsExpression.Po: No such file or directory
Makefile:1056: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDate.Po: No such file or directory
Makefile:1057: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDateTime.Po: No such file or directory
Makefile:1058: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDictionary.Po: No such file or directory
Makefile:1059: ../../../pgadmin/pgscript/expressions/.deps/pgsGenInt.Po: No such file or directory
Makefile:1060: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReal.Po: No such file or directory
Makefile:1061: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReference.Po: No such file or directory
Makefile:1062: ../../../pgadmin/pgscript/expressions/.deps/pgsGenRegex.Po: No such file or directory
Makefile:1063: ../../../pgadmin/pgscript/expressions/.deps/pgsGenString.Po: No such file or directory
Makefile:1064: ../../../pgadmin/pgscript/expressions/.deps/pgsGenTime.Po: No such file or directory
Makefile:1065: ../../../pgadmin/pgscript/expressions/.deps/pgsGreater.Po: No such file or directory
Makefile:1066: ../../../pgadmin/pgscript/expressions/.deps/pgsGreaterEqual.Po: No such file or directory
Makefile:1067: ../../../pgadmin/pgscript/expressions/.deps/pgsIdent.Po: No such file or directory
Makefile:1068: ../../../pgadmin/pgscript/expressions/.deps/pgsIdentRecord.Po: No such file or directory
Makefile:1069: ../../../pgadmin/pgscript/expressions/.deps/pgsLines.Po: No such file or directory
Makefile:1070: ../../../pgadmin/pgscript/expressions/.deps/pgsLower.Po: No such file or directory
Makefile:1071: ../../../pgadmin/pgscript/expressions/.deps/pgsLowerEqual.Po: No such file or directory
Makefile:1072: ../../../pgadmin/pgscript/expressions/.deps/pgsMinus.Po: No such file or directory
Makefile:1073: ../../../pgadmin/pgscript/expressions/.deps/pgsModulo.Po: No such file or directory
Makefile:1074: ../../../pgadmin/pgscript/expressions/.deps/pgsNegate.Po: No such file or directory
Makefile:1075: ../../../pgadmin/pgscript/expressions/.deps/pgsNot.Po: No such file or directory
Makefile:1076: ../../../pgadmin/pgscript/expressions/.deps/pgsOperation.Po: No such file or directory
Makefile:1077: ../../../pgadmin/pgscript/expressions/.deps/pgsOr.Po: No such file or directory
Makefile:1078: ../../../pgadmin/pgscript/expressions/.deps/pgsOver.Po: No such file or directory
Makefile:1079: ../../../pgadmin/pgscript/expressions/.deps/pgsParenthesis.Po: No such file or directory
Makefile:1080: ../../../pgadmin/pgscript/expressions/.deps/pgsPlus.Po: No such file or directory
Makefile:1081: ../../../pgadmin/pgscript/expressions/.deps/pgsRemoveLine.Po: No such file or directory
Makefile:1082: ../../../pgadmin/pgscript/expressions/.deps/pgsTimes.Po: No such file or directory
Makefile:1083: ../../../pgadmin/pgscript/expressions/.deps/pgsTrim.Po: No such file or directory
Makefile:1084: ../../../pgadmin/pgscript/generators/.deps/pgsDateGen.Po: No such file or directory
Makefile:1085: ../../../pgadmin/pgscript/generators/.deps/pgsDateTimeGen.Po: No such file or directory
Makefile:1086: ../../../pgadmin/pgscript/generators/.deps/pgsDictionaryGen.Po: No such file or directory
Makefile:1087: ../../../pgadmin/pgscript/generators/.deps/pgsIntegerGen.Po: No such file or directory
Makefile:1088: ../../../pgadmin/pgscript/generators/.deps/pgsNumberGen.Po: No such file or directory
Makefile:1089: ../../../pgadmin/pgscript/generators/.deps/pgsObjectGen.Po: No such file or directory
Makefile:1090: ../../../pgadmin/pgscript/generators/.deps/pgsRealGen.Po: No such file or directory
Makefile:1091: ../../../pgadmin/pgscript/generators/.deps/pgsReferenceGen.Po: No such file or directory
Makefile:1092: ../../../pgadmin/pgscript/generators/.deps/pgsRegexGen.Po: No such file or directory
Makefile:1093: ../../../pgadmin/pgscript/generators/.deps/pgsStringGen.Po: No such file or directory
Makefile:1094: ../../../pgadmin/pgscript/generators/.deps/pgsTimeGen.Po: No such file or directory
Makefile:1095: ../../../pgadmin/pgscript/objects/.deps/pgsGenerator.Po: No such file or directory
Makefile:1096: ../../../pgadmin/pgscript/objects/.deps/pgsNumber.Po: No such file or directory
Makefile:1097: ../../../pgadmin/pgscript/objects/.deps/pgsRecord.Po: No such file or directory
Makefile:1098: ../../../pgadmin/pgscript/objects/.deps/pgsString.Po: No such file or directory
Makefile:1099: ../../../pgadmin/pgscript/objects/.deps/pgsVariable.Po: No such file or directory
Makefile:1100: ../../../pgadmin/pgscript/statements/.deps/pgsAssertStmt.Po: No such file or directory
Makefile:1101: ../../../pgadmin/pgscript/statements/.deps/pgsBreakStmt.Po: No such file or directory
Makefile:1102: ../../../pgadmin/pgscript/statements/.deps/pgsContinueStmt.Po: No such file or directory
Makefile:1103: ../../../pgadmin/pgscript/statements/.deps/pgsDeclareRecordStmt.Po: No such file or directory
Makefile:1104: ../../../pgadmin/pgscript/statements/.deps/pgsExpressionStmt.Po: No such file or directory
Makefile:1105: ../../../pgadmin/pgscript/statements/.deps/pgsIfStmt.Po: No such file or directory
Makefile:1106: ../../../pgadmin/pgscript/statements/.deps/pgsPrintStmt.Po: No such file or directory
Makefile:1107: ../../../pgadmin/pgscript/statements/.deps/pgsProgram.Po: No such file or directory
Makefile:1108: ../../../pgadmin/pgscript/statements/.deps/pgsStmt.Po: No such file or directory
Makefile:1109: ../../../pgadmin/pgscript/statements/.deps/pgsStmtList.Po: No such file or directory
Makefile:1110: ../../../pgadmin/pgscript/statements/.deps/pgsWhileStmt.Po: No such file or directory
Makefile:1111: ../../../pgadmin/pgscript/utilities/.deps/pgsAlloc.Po: No such file or directory
Makefile:1112: ../../../pgadmin/pgscript/utilities/.deps/pgsContext.Po: No such file or directory
Makefile:1113: ../../../pgadmin/pgscript/utilities/.deps/pgsDriver.Po: No such file or directory
Makefile:1114: ../../../pgadmin/pgscript/utilities/.deps/pgsMapm.Po: No such file or directory
Makefile:1115: ../../../pgadmin/pgscript/utilities/.deps/pgsThread.Po: No such file or directory
Makefile:1116: ../../../pgadmin/pgscript/utilities/.deps/pgsUtilities.Po: No such file or directory
Makefile:1117: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm5sin.Po: No such file or directory
Makefile:1118: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_add.Po: No such file or directory
Makefile:1119: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_cpi.Po: No such file or directory
Makefile:1120: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_div.Po: No such file or directory
Makefile:1121: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_exp.Po: No such file or directory
Makefile:1122: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fam.Po: No such file or directory
Makefile:1123: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fft.Po: No such file or directory
Makefile:1124: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_flr.Po: No such file or directory
Makefile:1125: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fpf.Po: No such file or directory
Makefile:1126: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_gcd.Po: No such file or directory
Makefile:1127: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg2.Po: No such file or directory
Makefile:1128: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg3.Po: No such file or directory
Makefile:1129: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg4.Po: No such file or directory
Makefile:1130: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_log.Po: No such file or directory
Makefile:1131: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_mul.Po: No such file or directory
Makefile:1132: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_pow.Po: No such file or directory
Makefile:1133: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rcp.Po: No such file or directory
Makefile:1134: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rnd.Po: No such file or directory
Makefile:1135: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_set.Po: No such file or directory
Makefile:1136: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_sin.Po: No such file or directory
Makefile:1137: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasin.Po: No such file or directory
Makefile:1138: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasn0.Po: No such file or directory
Makefile:1139: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcbrt.Po: No such file or directory
Makefile:1140: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcnst.Po: No such file or directory
Makefile:1141: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfact.Po: No such file or directory
Makefile:1142: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfmul.Po: No such file or directory
Makefile:1143: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmgues.Po: No such file or directory
Makefile:1144: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhasn.Po: No such file or directory
Makefile:1145: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhsin.Po: No such file or directory
Makefile:1146: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmipwr.Po: No such file or directory
Makefile:1147: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmistr.Po: No such file or directory
Makefile:1148: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmpwr2.Po: No such file or directory
Makefile:1149: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmrsin.Po: No such file or directory
Makefile:1150: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmsqrt.Po: No such file or directory
Makefile:1151: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmstck.Po: No such file or directory
Makefile:1152: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutil.Po: No such file or directory
Makefile:1153: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl1.Po: No such file or directory
Makefile:1154: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl2.Po: No such file or directory
Makefile:1155: ../../../pgadmin/utils/.deps/misc.Po: No such file or directory
Makefile:1156: ../../../pgadmin/utils/.deps/sysLogger.Po: No such file or directory
make[3]: *** No rule to make target `../../../pgadmin/utils/.deps/sysLogger.Po'.  Stop.
make[2]: *** [distclean-recursive] Error 1
make[1]: *** [distclean-recursive] Error 1
make: *** [distclean-recursive] Error 1


On Wed, May 8, 2013 at 10:24 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Mickael Deloison
Date:

Dear all,

I will see if I can do anything next week-end (not at home until next Thursday).
For info, I have not been a developer anymore for almost 3 years, so cannot guarantee that I will succeed.

Regards,
Mickael

Le 9 mai 2013 12:14, "Dave Page" <dpage@pgadmin.org> a écrit :
Hi



On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

I needed to modify the configuration at quite a lot places to make it work properly.
And, looks like the pgscript has not been compiled by anyone from long time and I can say that because, it has been horribly broken.
If we're going to support the stand-alone pgscript application, we will need to modify the code accordingly.
There are many changes done in the pgadmin3 code, which are shared by pgscript. And, we've not taken care about pgscript affected areas.

Honestly, I don't think we need to keep that there. pgScript was originally written as a GSOC project by Mickael Deloison, and later added to pgAdmin as a second project (iirc, Magnus mentored). We included the command line interpretor just to give it a home, but as it hasn't been touched since it was added and isn't used for anything it should probably go.

Any comments Magnus, Mickael?

How much would that cleanup the patch you've submitted Ashesh? At a quick glance I guess at least the last hunk would be redundant.
 

Also - the subdir-object changes (in configuration) had introduced the dependency on the actual objects for each target (Here - pgscript and pgadmin3), because the objects are getting generated in the respective directories instead of target directory. And, that dependency leads to this distclean issue, because the source/object files are shared between this two targets, and that too in different Makefiles, and one of the target cleans those objects, other can not find it.
It is not able to identify two targets using the same objects (and, enable the renaming of objects never comes into picture, not even if we set the _SHORTNAME property for those targets. reference: http://www.gnu.org/software/automake/manual/html_node/Renamed-Objects.html)
And, because of the dependency on actual objects, they're not regenerating the objects, which they must because they do have different CXXFLAGS.

For the moment, I have fixed the 'make distclean' and cleaned up the configurations. Also - I've introduced the new object extension (.pgso) in pgscript Makefile.am to enable it to build separate object files from pgadmin3.

Though - need some more work to resolve the pgscript compilation issue.
We can do it later (if nobody is using it at the moment.)

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: 
Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

On Wed, May 8, 2013 at 5:09 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied.

When testing this, I noticed that the distclean target seems to be broken now. Can you (or one of the team) please take a look? Thanks.

viper:pgadmin3 dpage$ make distclean
Making distclean in xtra/png2c
make[1]: Nothing to be done for `distclean'.
Making distclean in branding
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in i18n
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in plugins.d
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in pgadmin
test -z "pgadmin3" || rm -f pgadmin3
rm -f include/images/*.pngc
rm -f *.o
rm -f *.tab.c
test -z "" || rm -f 
rm -f agent/*.o
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f 
rm -f ctl/*.o
rm -f agent/.deps/.dirstamp
rm -f agent/.dirstamp
rm -f ctl/.deps/.dirstamp
rm -f db/*.o
rm -f ctl/.dirstamp
rm -f db/.deps/.dirstamp
rm -f db/.dirstamp
rm -f dd/dditems/figures/*.o
rm -f dd/dditems/figures/.deps/.dirstamp
rm -f dd/dditems/figures/.dirstamp
rm -f dd/dditems/figures/xml/.deps/.dirstamp
rm -f dd/dditems/figures/xml/*.o
rm -f dd/dditems/figures/xml/.dirstamp
rm -f dd/dditems/handles/.deps/.dirstamp
rm -f dd/dditems/handles/*.o
rm -f dd/dditems/handles/.dirstamp
rm -f dd/dditems/locators/.deps/.dirstamp
rm -f dd/dditems/locators/.dirstamp
rm -f dd/dditems/locators/*.o
rm -f dd/dditems/tools/.deps/.dirstamp
rm -f dd/dditems/tools/.dirstamp
rm -f dd/dditems/utilities/.deps/.dirstamp
rm -f dd/dditems/tools/*.o
rm -f dd/dditems/utilities/.dirstamp
rm -f dd/ddmodel/.deps/.dirstamp
rm -f dd/dditems/utilities/*.o
rm -f dd/ddmodel/.dirstamp
rm -f debugger/.deps/.dirstamp
rm -f dd/ddmodel/*.o
rm -f debugger/.dirstamp
rm -f dlg/.deps/.dirstamp
rm -f dlg/.dirstamp
rm -f debugger/*.o
rm -f frm/.deps/.dirstamp
rm -f frm/.dirstamp
rm -f dlg/*.o
rm -f gqb/.deps/.dirstamp
rm -f gqb/.dirstamp
rm -f hotdraw/connectors/.deps/.dirstamp
rm -f hotdraw/connectors/.dirstamp
rm -f hotdraw/figures/.deps/.dirstamp
rm -f hotdraw/figures/.dirstamp
rm -f frm/*.o
rm -f hotdraw/figures/defaultAttributes/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/.dirstamp
rm -f hotdraw/figures/xml/.deps/.dirstamp
rm -f gqb/*.o
rm -f hotdraw/figures/xml/.dirstamp
rm -f hotdraw/handles/.deps/.dirstamp
rm -f hotdraw/handles/.dirstamp
rm -f hotdraw/connectors/*.o
rm -f hotdraw/locators/.deps/.dirstamp
rm -f hotdraw/locators/.dirstamp
rm -f hotdraw/figures/*.o
rm -f hotdraw/main/.deps/.dirstamp
rm -f hotdraw/main/.dirstamp
rm -f hotdraw/tools/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/*.o
rm -f hotdraw/tools/.dirstamp
rm -f hotdraw/utilities/.deps/.dirstamp
rm -f hotdraw/figures/xml/*.o
rm -f hotdraw/utilities/.dirstamp
rm -f libssh2/.deps/.dirstamp
rm -f libssh2/.dirstamp
rm -f hotdraw/handles/*.o
rm -f ogl/.deps/.dirstamp
rm -f ogl/.dirstamp
rm -f hotdraw/locators/*.o
rm -f pgscript/.deps/.dirstamp
rm -f pgscript/.dirstamp
rm -f hotdraw/main/*.o
rm -f pgscript/exceptions/.deps/.dirstamp
rm -f pgscript/exceptions/.dirstamp
rm -f pgscript/expressions/.deps/.dirstamp
rm -f hotdraw/tools/*.o
rm -f pgscript/expressions/.dirstamp
rm -f pgscript/generators/.deps/.dirstamp
rm -f hotdraw/utilities/*.o
rm -f pgscript/generators/.dirstamp
rm -f pgscript/objects/.deps/.dirstamp
rm -f pgscript/objects/.dirstamp
rm -f libssh2/*.o
rm -f pgscript/statements/.deps/.dirstamp
rm -f pgscript/statements/.dirstamp
rm -f pgscript/utilities/.deps/.dirstamp
rm -f ogl/*.o
rm -f pgscript/utilities/.dirstamp
rm -f pgscript/utilities/m_apm/.deps/.dirstamp
rm -f pgscript/utilities/m_apm/.dirstamp
rm -f pgscript/*.o
rm -f schema/.deps/.dirstamp
rm -f schema/.dirstamp
rm -f pgscript/exceptions/*.o
rm -f slony/.deps/.dirstamp
rm -f slony/.dirstamp
rm -f ui/.deps/.dirstamp
rm -f pgscript/expressions/*.o
rm -f ui/.dirstamp
rm -f utils/.deps/.dirstamp
rm -f utils/.dirstamp
rm -f pgscript/generators/*.o
rm -f pgscript/objects/*.o
rm -f pgscript/statements/*.o
rm -f pgscript/utilities/*.o
rm -f pgscript/utilities/m_apm/*.o
rm -f schema/*.o
rm -f slony/*.o
rm -f ui/*.o
rm -f utils/*.o
rm -rf ./.deps agent/.deps ctl/.deps db/.deps dd/dditems/figures/.deps dd/dditems/figures/xml/.deps dd/dditems/handles/.deps dd/dditems/locators/.deps dd/dditems/tools/.deps dd/dditems/utilities/.deps dd/ddmodel/.deps debugger/.deps dlg/.deps frm/.deps gqb/.deps hotdraw/connectors/.deps hotdraw/figures/.deps hotdraw/figures/defaultAttributes/.deps hotdraw/figures/xml/.deps hotdraw/handles/.deps hotdraw/locators/.deps hotdraw/main/.deps hotdraw/tools/.deps hotdraw/utilities/.deps libssh2/.deps ogl/.deps pgscript/.deps pgscript/exceptions/.deps pgscript/expressions/.deps pgscript/generators/.deps pgscript/objects/.deps pgscript/statements/.deps pgscript/utilities/.deps pgscript/utilities/m_apm/.deps schema/.deps slony/.deps ui/.deps utils/.deps
rm -f Makefile
Making distclean in xtra
Making distclean in png2c
make[2]: Nothing to be done for `distclean'.
Making distclean in pgscript
Making distclean in lib
Makefile:1032: ../../../pgadmin/db/.deps/keywords.Po: No such file or directory
Makefile:1033: ../../../pgadmin/db/.deps/pgConn.Po: No such file or directory
Makefile:1034: ../../../pgadmin/db/.deps/pgQueryThread.Po: No such file or directory
Makefile:1035: ../../../pgadmin/db/.deps/pgSet.Po: No such file or directory
Makefile:1036: ../../../pgadmin/pgscript/.deps/lex.pgs.Po: No such file or directory
Makefile:1037: ../../../pgadmin/pgscript/.deps/parser.tab.Po: No such file or directory
Makefile:1038: ../../../pgadmin/pgscript/.deps/pgsApplication.Po: No such file or directory
Makefile:1039: ../../../pgadmin/pgscript/exceptions/.deps/pgsArithmeticException.Po: No such file or directory
Makefile:1040: ../../../pgadmin/pgscript/exceptions/.deps/pgsAssertException.Po: No such file or directory
Makefile:1041: ../../../pgadmin/pgscript/exceptions/.deps/pgsBreakException.Po: No such file or directory
Makefile:1042: ../../../pgadmin/pgscript/exceptions/.deps/pgsCastException.Po: No such file or directory
Makefile:1043: ../../../pgadmin/pgscript/exceptions/.deps/pgsContinueException.Po: No such file or directory
Makefile:1044: ../../../pgadmin/pgscript/exceptions/.deps/pgsException.Po: No such file or directory
Makefile:1045: ../../../pgadmin/pgscript/exceptions/.deps/pgsInterruptException.Po: No such file or directory
Makefile:1046: ../../../pgadmin/pgscript/exceptions/.deps/pgsParameterException.Po: No such file or directory
Makefile:1047: ../../../pgadmin/pgscript/expressions/.deps/pgsAnd.Po: No such file or directory
Makefile:1048: ../../../pgadmin/pgscript/expressions/.deps/pgsAssign.Po: No such file or directory
Makefile:1049: ../../../pgadmin/pgscript/expressions/.deps/pgsAssignToRecord.Po: No such file or directory
Makefile:1050: ../../../pgadmin/pgscript/expressions/.deps/pgsCast.Po: No such file or directory
Makefile:1051: ../../../pgadmin/pgscript/expressions/.deps/pgsColumns.Po: No such file or directory
Makefile:1052: ../../../pgadmin/pgscript/expressions/.deps/pgsDifferent.Po: No such file or directory
Makefile:1053: ../../../pgadmin/pgscript/expressions/.deps/pgsEqual.Po: No such file or directory
Makefile:1054: ../../../pgadmin/pgscript/expressions/.deps/pgsExecute.Po: No such file or directory
Makefile:1055: ../../../pgadmin/pgscript/expressions/.deps/pgsExpression.Po: No such file or directory
Makefile:1056: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDate.Po: No such file or directory
Makefile:1057: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDateTime.Po: No such file or directory
Makefile:1058: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDictionary.Po: No such file or directory
Makefile:1059: ../../../pgadmin/pgscript/expressions/.deps/pgsGenInt.Po: No such file or directory
Makefile:1060: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReal.Po: No such file or directory
Makefile:1061: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReference.Po: No such file or directory
Makefile:1062: ../../../pgadmin/pgscript/expressions/.deps/pgsGenRegex.Po: No such file or directory
Makefile:1063: ../../../pgadmin/pgscript/expressions/.deps/pgsGenString.Po: No such file or directory
Makefile:1064: ../../../pgadmin/pgscript/expressions/.deps/pgsGenTime.Po: No such file or directory
Makefile:1065: ../../../pgadmin/pgscript/expressions/.deps/pgsGreater.Po: No such file or directory
Makefile:1066: ../../../pgadmin/pgscript/expressions/.deps/pgsGreaterEqual.Po: No such file or directory
Makefile:1067: ../../../pgadmin/pgscript/expressions/.deps/pgsIdent.Po: No such file or directory
Makefile:1068: ../../../pgadmin/pgscript/expressions/.deps/pgsIdentRecord.Po: No such file or directory
Makefile:1069: ../../../pgadmin/pgscript/expressions/.deps/pgsLines.Po: No such file or directory
Makefile:1070: ../../../pgadmin/pgscript/expressions/.deps/pgsLower.Po: No such file or directory
Makefile:1071: ../../../pgadmin/pgscript/expressions/.deps/pgsLowerEqual.Po: No such file or directory
Makefile:1072: ../../../pgadmin/pgscript/expressions/.deps/pgsMinus.Po: No such file or directory
Makefile:1073: ../../../pgadmin/pgscript/expressions/.deps/pgsModulo.Po: No such file or directory
Makefile:1074: ../../../pgadmin/pgscript/expressions/.deps/pgsNegate.Po: No such file or directory
Makefile:1075: ../../../pgadmin/pgscript/expressions/.deps/pgsNot.Po: No such file or directory
Makefile:1076: ../../../pgadmin/pgscript/expressions/.deps/pgsOperation.Po: No such file or directory
Makefile:1077: ../../../pgadmin/pgscript/expressions/.deps/pgsOr.Po: No such file or directory
Makefile:1078: ../../../pgadmin/pgscript/expressions/.deps/pgsOver.Po: No such file or directory
Makefile:1079: ../../../pgadmin/pgscript/expressions/.deps/pgsParenthesis.Po: No such file or directory
Makefile:1080: ../../../pgadmin/pgscript/expressions/.deps/pgsPlus.Po: No such file or directory
Makefile:1081: ../../../pgadmin/pgscript/expressions/.deps/pgsRemoveLine.Po: No such file or directory
Makefile:1082: ../../../pgadmin/pgscript/expressions/.deps/pgsTimes.Po: No such file or directory
Makefile:1083: ../../../pgadmin/pgscript/expressions/.deps/pgsTrim.Po: No such file or directory
Makefile:1084: ../../../pgadmin/pgscript/generators/.deps/pgsDateGen.Po: No such file or directory
Makefile:1085: ../../../pgadmin/pgscript/generators/.deps/pgsDateTimeGen.Po: No such file or directory
Makefile:1086: ../../../pgadmin/pgscript/generators/.deps/pgsDictionaryGen.Po: No such file or directory
Makefile:1087: ../../../pgadmin/pgscript/generators/.deps/pgsIntegerGen.Po: No such file or directory
Makefile:1088: ../../../pgadmin/pgscript/generators/.deps/pgsNumberGen.Po: No such file or directory
Makefile:1089: ../../../pgadmin/pgscript/generators/.deps/pgsObjectGen.Po: No such file or directory
Makefile:1090: ../../../pgadmin/pgscript/generators/.deps/pgsRealGen.Po: No such file or directory
Makefile:1091: ../../../pgadmin/pgscript/generators/.deps/pgsReferenceGen.Po: No such file or directory
Makefile:1092: ../../../pgadmin/pgscript/generators/.deps/pgsRegexGen.Po: No such file or directory
Makefile:1093: ../../../pgadmin/pgscript/generators/.deps/pgsStringGen.Po: No such file or directory
Makefile:1094: ../../../pgadmin/pgscript/generators/.deps/pgsTimeGen.Po: No such file or directory
Makefile:1095: ../../../pgadmin/pgscript/objects/.deps/pgsGenerator.Po: No such file or directory
Makefile:1096: ../../../pgadmin/pgscript/objects/.deps/pgsNumber.Po: No such file or directory
Makefile:1097: ../../../pgadmin/pgscript/objects/.deps/pgsRecord.Po: No such file or directory
Makefile:1098: ../../../pgadmin/pgscript/objects/.deps/pgsString.Po: No such file or directory
Makefile:1099: ../../../pgadmin/pgscript/objects/.deps/pgsVariable.Po: No such file or directory
Makefile:1100: ../../../pgadmin/pgscript/statements/.deps/pgsAssertStmt.Po: No such file or directory
Makefile:1101: ../../../pgadmin/pgscript/statements/.deps/pgsBreakStmt.Po: No such file or directory
Makefile:1102: ../../../pgadmin/pgscript/statements/.deps/pgsContinueStmt.Po: No such file or directory
Makefile:1103: ../../../pgadmin/pgscript/statements/.deps/pgsDeclareRecordStmt.Po: No such file or directory
Makefile:1104: ../../../pgadmin/pgscript/statements/.deps/pgsExpressionStmt.Po: No such file or directory
Makefile:1105: ../../../pgadmin/pgscript/statements/.deps/pgsIfStmt.Po: No such file or directory
Makefile:1106: ../../../pgadmin/pgscript/statements/.deps/pgsPrintStmt.Po: No such file or directory
Makefile:1107: ../../../pgadmin/pgscript/statements/.deps/pgsProgram.Po: No such file or directory
Makefile:1108: ../../../pgadmin/pgscript/statements/.deps/pgsStmt.Po: No such file or directory
Makefile:1109: ../../../pgadmin/pgscript/statements/.deps/pgsStmtList.Po: No such file or directory
Makefile:1110: ../../../pgadmin/pgscript/statements/.deps/pgsWhileStmt.Po: No such file or directory
Makefile:1111: ../../../pgadmin/pgscript/utilities/.deps/pgsAlloc.Po: No such file or directory
Makefile:1112: ../../../pgadmin/pgscript/utilities/.deps/pgsContext.Po: No such file or directory
Makefile:1113: ../../../pgadmin/pgscript/utilities/.deps/pgsDriver.Po: No such file or directory
Makefile:1114: ../../../pgadmin/pgscript/utilities/.deps/pgsMapm.Po: No such file or directory
Makefile:1115: ../../../pgadmin/pgscript/utilities/.deps/pgsThread.Po: No such file or directory
Makefile:1116: ../../../pgadmin/pgscript/utilities/.deps/pgsUtilities.Po: No such file or directory
Makefile:1117: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm5sin.Po: No such file or directory
Makefile:1118: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_add.Po: No such file or directory
Makefile:1119: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_cpi.Po: No such file or directory
Makefile:1120: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_div.Po: No such file or directory
Makefile:1121: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_exp.Po: No such file or directory
Makefile:1122: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fam.Po: No such file or directory
Makefile:1123: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fft.Po: No such file or directory
Makefile:1124: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_flr.Po: No such file or directory
Makefile:1125: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fpf.Po: No such file or directory
Makefile:1126: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_gcd.Po: No such file or directory
Makefile:1127: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg2.Po: No such file or directory
Makefile:1128: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg3.Po: No such file or directory
Makefile:1129: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg4.Po: No such file or directory
Makefile:1130: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_log.Po: No such file or directory
Makefile:1131: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_mul.Po: No such file or directory
Makefile:1132: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_pow.Po: No such file or directory
Makefile:1133: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rcp.Po: No such file or directory
Makefile:1134: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rnd.Po: No such file or directory
Makefile:1135: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_set.Po: No such file or directory
Makefile:1136: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_sin.Po: No such file or directory
Makefile:1137: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasin.Po: No such file or directory
Makefile:1138: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasn0.Po: No such file or directory
Makefile:1139: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcbrt.Po: No such file or directory
Makefile:1140: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcnst.Po: No such file or directory
Makefile:1141: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfact.Po: No such file or directory
Makefile:1142: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfmul.Po: No such file or directory
Makefile:1143: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmgues.Po: No such file or directory
Makefile:1144: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhasn.Po: No such file or directory
Makefile:1145: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhsin.Po: No such file or directory
Makefile:1146: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmipwr.Po: No such file or directory
Makefile:1147: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmistr.Po: No such file or directory
Makefile:1148: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmpwr2.Po: No such file or directory
Makefile:1149: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmrsin.Po: No such file or directory
Makefile:1150: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmsqrt.Po: No such file or directory
Makefile:1151: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmstck.Po: No such file or directory
Makefile:1152: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutil.Po: No such file or directory
Makefile:1153: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl1.Po: No such file or directory
Makefile:1154: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl2.Po: No such file or directory
Makefile:1155: ../../../pgadmin/utils/.deps/misc.Po: No such file or directory
Makefile:1156: ../../../pgadmin/utils/.deps/sysLogger.Po: No such file or directory
make[3]: *** No rule to make target `../../../pgadmin/utils/.deps/sysLogger.Po'.  Stop.
make[2]: *** [distclean-recursive] Error 1
make[1]: *** [distclean-recursive] Error 1
make: *** [distclean-recursive] Error 1


On Wed, May 8, 2013 at 10:24 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Dave Page
Date:
Hi Mickael


On Thu, May 9, 2013 at 12:32 PM, Mickael Deloison <mdeloison@gmail.com> wrote:

Dear all,

I will see if I can do anything next week-end (not at home until next Thursday).
For info, I have not been a developer anymore for almost 3 years, so cannot guarantee that I will succeed.


Thanks - but is it worth it? We really only included that code in the source tree for your benefit (if my memory serves), so if you're not even developing any more, I don't see any reason to keep it there at all.
 

Regards,
Mickael

Le 9 mai 2013 12:14, "Dave Page" <dpage@pgadmin.org> a écrit :

Hi



On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

I needed to modify the configuration at quite a lot places to make it work properly.
And, looks like the pgscript has not been compiled by anyone from long time and I can say that because, it has been horribly broken.
If we're going to support the stand-alone pgscript application, we will need to modify the code accordingly.
There are many changes done in the pgadmin3 code, which are shared by pgscript. And, we've not taken care about pgscript affected areas.

Honestly, I don't think we need to keep that there. pgScript was originally written as a GSOC project by Mickael Deloison, and later added to pgAdmin as a second project (iirc, Magnus mentored). We included the command line interpretor just to give it a home, but as it hasn't been touched since it was added and isn't used for anything it should probably go.

Any comments Magnus, Mickael?

How much would that cleanup the patch you've submitted Ashesh? At a quick glance I guess at least the last hunk would be redundant.
 

Also - the subdir-object changes (in configuration) had introduced the dependency on the actual objects for each target (Here - pgscript and pgadmin3), because the objects are getting generated in the respective directories instead of target directory. And, that dependency leads to this distclean issue, because the source/object files are shared between this two targets, and that too in different Makefiles, and one of the target cleans those objects, other can not find it.
It is not able to identify two targets using the same objects (and, enable the renaming of objects never comes into picture, not even if we set the _SHORTNAME property for those targets. reference: http://www.gnu.org/software/automake/manual/html_node/Renamed-Objects.html)
And, because of the dependency on actual objects, they're not regenerating the objects, which they must because they do have different CXXFLAGS.

For the moment, I have fixed the 'make distclean' and cleaned up the configurations. Also - I've introduced the new object extension (.pgso) in pgscript Makefile.am to enable it to build separate object files from pgadmin3.

Though - need some more work to resolve the pgscript compilation issue.
We can do it later (if nobody is using it at the moment.)

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: 
Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

On Wed, May 8, 2013 at 5:09 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied.

When testing this, I noticed that the distclean target seems to be broken now. Can you (or one of the team) please take a look? Thanks.

viper:pgadmin3 dpage$ make distclean
Making distclean in xtra/png2c
make[1]: Nothing to be done for `distclean'.
Making distclean in branding
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in i18n
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in plugins.d
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in pgadmin
test -z "pgadmin3" || rm -f pgadmin3
rm -f include/images/*.pngc
rm -f *.o
rm -f *.tab.c
test -z "" || rm -f 
rm -f agent/*.o
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f 
rm -f ctl/*.o
rm -f agent/.deps/.dirstamp
rm -f agent/.dirstamp
rm -f ctl/.deps/.dirstamp
rm -f db/*.o
rm -f ctl/.dirstamp
rm -f db/.deps/.dirstamp
rm -f db/.dirstamp
rm -f dd/dditems/figures/*.o
rm -f dd/dditems/figures/.deps/.dirstamp
rm -f dd/dditems/figures/.dirstamp
rm -f dd/dditems/figures/xml/.deps/.dirstamp
rm -f dd/dditems/figures/xml/*.o
rm -f dd/dditems/figures/xml/.dirstamp
rm -f dd/dditems/handles/.deps/.dirstamp
rm -f dd/dditems/handles/*.o
rm -f dd/dditems/handles/.dirstamp
rm -f dd/dditems/locators/.deps/.dirstamp
rm -f dd/dditems/locators/.dirstamp
rm -f dd/dditems/locators/*.o
rm -f dd/dditems/tools/.deps/.dirstamp
rm -f dd/dditems/tools/.dirstamp
rm -f dd/dditems/utilities/.deps/.dirstamp
rm -f dd/dditems/tools/*.o
rm -f dd/dditems/utilities/.dirstamp
rm -f dd/ddmodel/.deps/.dirstamp
rm -f dd/dditems/utilities/*.o
rm -f dd/ddmodel/.dirstamp
rm -f debugger/.deps/.dirstamp
rm -f dd/ddmodel/*.o
rm -f debugger/.dirstamp
rm -f dlg/.deps/.dirstamp
rm -f dlg/.dirstamp
rm -f debugger/*.o
rm -f frm/.deps/.dirstamp
rm -f frm/.dirstamp
rm -f dlg/*.o
rm -f gqb/.deps/.dirstamp
rm -f gqb/.dirstamp
rm -f hotdraw/connectors/.deps/.dirstamp
rm -f hotdraw/connectors/.dirstamp
rm -f hotdraw/figures/.deps/.dirstamp
rm -f hotdraw/figures/.dirstamp
rm -f frm/*.o
rm -f hotdraw/figures/defaultAttributes/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/.dirstamp
rm -f hotdraw/figures/xml/.deps/.dirstamp
rm -f gqb/*.o
rm -f hotdraw/figures/xml/.dirstamp
rm -f hotdraw/handles/.deps/.dirstamp
rm -f hotdraw/handles/.dirstamp
rm -f hotdraw/connectors/*.o
rm -f hotdraw/locators/.deps/.dirstamp
rm -f hotdraw/locators/.dirstamp
rm -f hotdraw/figures/*.o
rm -f hotdraw/main/.deps/.dirstamp
rm -f hotdraw/main/.dirstamp
rm -f hotdraw/tools/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/*.o
rm -f hotdraw/tools/.dirstamp
rm -f hotdraw/utilities/.deps/.dirstamp
rm -f hotdraw/figures/xml/*.o
rm -f hotdraw/utilities/.dirstamp
rm -f libssh2/.deps/.dirstamp
rm -f libssh2/.dirstamp
rm -f hotdraw/handles/*.o
rm -f ogl/.deps/.dirstamp
rm -f ogl/.dirstamp
rm -f hotdraw/locators/*.o
rm -f pgscript/.deps/.dirstamp
rm -f pgscript/.dirstamp
rm -f hotdraw/main/*.o
rm -f pgscript/exceptions/.deps/.dirstamp
rm -f pgscript/exceptions/.dirstamp
rm -f pgscript/expressions/.deps/.dirstamp
rm -f hotdraw/tools/*.o
rm -f pgscript/expressions/.dirstamp
rm -f pgscript/generators/.deps/.dirstamp
rm -f hotdraw/utilities/*.o
rm -f pgscript/generators/.dirstamp
rm -f pgscript/objects/.deps/.dirstamp
rm -f pgscript/objects/.dirstamp
rm -f libssh2/*.o
rm -f pgscript/statements/.deps/.dirstamp
rm -f pgscript/statements/.dirstamp
rm -f pgscript/utilities/.deps/.dirstamp
rm -f ogl/*.o
rm -f pgscript/utilities/.dirstamp
rm -f pgscript/utilities/m_apm/.deps/.dirstamp
rm -f pgscript/utilities/m_apm/.dirstamp
rm -f pgscript/*.o
rm -f schema/.deps/.dirstamp
rm -f schema/.dirstamp
rm -f pgscript/exceptions/*.o
rm -f slony/.deps/.dirstamp
rm -f slony/.dirstamp
rm -f ui/.deps/.dirstamp
rm -f pgscript/expressions/*.o
rm -f ui/.dirstamp
rm -f utils/.deps/.dirstamp
rm -f utils/.dirstamp
rm -f pgscript/generators/*.o
rm -f pgscript/objects/*.o
rm -f pgscript/statements/*.o
rm -f pgscript/utilities/*.o
rm -f pgscript/utilities/m_apm/*.o
rm -f schema/*.o
rm -f slony/*.o
rm -f ui/*.o
rm -f utils/*.o
rm -rf ./.deps agent/.deps ctl/.deps db/.deps dd/dditems/figures/.deps dd/dditems/figures/xml/.deps dd/dditems/handles/.deps dd/dditems/locators/.deps dd/dditems/tools/.deps dd/dditems/utilities/.deps dd/ddmodel/.deps debugger/.deps dlg/.deps frm/.deps gqb/.deps hotdraw/connectors/.deps hotdraw/figures/.deps hotdraw/figures/defaultAttributes/.deps hotdraw/figures/xml/.deps hotdraw/handles/.deps hotdraw/locators/.deps hotdraw/main/.deps hotdraw/tools/.deps hotdraw/utilities/.deps libssh2/.deps ogl/.deps pgscript/.deps pgscript/exceptions/.deps pgscript/expressions/.deps pgscript/generators/.deps pgscript/objects/.deps pgscript/statements/.deps pgscript/utilities/.deps pgscript/utilities/m_apm/.deps schema/.deps slony/.deps ui/.deps utils/.deps
rm -f Makefile
Making distclean in xtra
Making distclean in png2c
make[2]: Nothing to be done for `distclean'.
Making distclean in pgscript
Making distclean in lib
Makefile:1032: ../../../pgadmin/db/.deps/keywords.Po: No such file or directory
Makefile:1033: ../../../pgadmin/db/.deps/pgConn.Po: No such file or directory
Makefile:1034: ../../../pgadmin/db/.deps/pgQueryThread.Po: No such file or directory
Makefile:1035: ../../../pgadmin/db/.deps/pgSet.Po: No such file or directory
Makefile:1036: ../../../pgadmin/pgscript/.deps/lex.pgs.Po: No such file or directory
Makefile:1037: ../../../pgadmin/pgscript/.deps/parser.tab.Po: No such file or directory
Makefile:1038: ../../../pgadmin/pgscript/.deps/pgsApplication.Po: No such file or directory
Makefile:1039: ../../../pgadmin/pgscript/exceptions/.deps/pgsArithmeticException.Po: No such file or directory
Makefile:1040: ../../../pgadmin/pgscript/exceptions/.deps/pgsAssertException.Po: No such file or directory
Makefile:1041: ../../../pgadmin/pgscript/exceptions/.deps/pgsBreakException.Po: No such file or directory
Makefile:1042: ../../../pgadmin/pgscript/exceptions/.deps/pgsCastException.Po: No such file or directory
Makefile:1043: ../../../pgadmin/pgscript/exceptions/.deps/pgsContinueException.Po: No such file or directory
Makefile:1044: ../../../pgadmin/pgscript/exceptions/.deps/pgsException.Po: No such file or directory
Makefile:1045: ../../../pgadmin/pgscript/exceptions/.deps/pgsInterruptException.Po: No such file or directory
Makefile:1046: ../../../pgadmin/pgscript/exceptions/.deps/pgsParameterException.Po: No such file or directory
Makefile:1047: ../../../pgadmin/pgscript/expressions/.deps/pgsAnd.Po: No such file or directory
Makefile:1048: ../../../pgadmin/pgscript/expressions/.deps/pgsAssign.Po: No such file or directory
Makefile:1049: ../../../pgadmin/pgscript/expressions/.deps/pgsAssignToRecord.Po: No such file or directory
Makefile:1050: ../../../pgadmin/pgscript/expressions/.deps/pgsCast.Po: No such file or directory
Makefile:1051: ../../../pgadmin/pgscript/expressions/.deps/pgsColumns.Po: No such file or directory
Makefile:1052: ../../../pgadmin/pgscript/expressions/.deps/pgsDifferent.Po: No such file or directory
Makefile:1053: ../../../pgadmin/pgscript/expressions/.deps/pgsEqual.Po: No such file or directory
Makefile:1054: ../../../pgadmin/pgscript/expressions/.deps/pgsExecute.Po: No such file or directory
Makefile:1055: ../../../pgadmin/pgscript/expressions/.deps/pgsExpression.Po: No such file or directory
Makefile:1056: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDate.Po: No such file or directory
Makefile:1057: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDateTime.Po: No such file or directory
Makefile:1058: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDictionary.Po: No such file or directory
Makefile:1059: ../../../pgadmin/pgscript/expressions/.deps/pgsGenInt.Po: No such file or directory
Makefile:1060: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReal.Po: No such file or directory
Makefile:1061: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReference.Po: No such file or directory
Makefile:1062: ../../../pgadmin/pgscript/expressions/.deps/pgsGenRegex.Po: No such file or directory
Makefile:1063: ../../../pgadmin/pgscript/expressions/.deps/pgsGenString.Po: No such file or directory
Makefile:1064: ../../../pgadmin/pgscript/expressions/.deps/pgsGenTime.Po: No such file or directory
Makefile:1065: ../../../pgadmin/pgscript/expressions/.deps/pgsGreater.Po: No such file or directory
Makefile:1066: ../../../pgadmin/pgscript/expressions/.deps/pgsGreaterEqual.Po: No such file or directory
Makefile:1067: ../../../pgadmin/pgscript/expressions/.deps/pgsIdent.Po: No such file or directory
Makefile:1068: ../../../pgadmin/pgscript/expressions/.deps/pgsIdentRecord.Po: No such file or directory
Makefile:1069: ../../../pgadmin/pgscript/expressions/.deps/pgsLines.Po: No such file or directory
Makefile:1070: ../../../pgadmin/pgscript/expressions/.deps/pgsLower.Po: No such file or directory
Makefile:1071: ../../../pgadmin/pgscript/expressions/.deps/pgsLowerEqual.Po: No such file or directory
Makefile:1072: ../../../pgadmin/pgscript/expressions/.deps/pgsMinus.Po: No such file or directory
Makefile:1073: ../../../pgadmin/pgscript/expressions/.deps/pgsModulo.Po: No such file or directory
Makefile:1074: ../../../pgadmin/pgscript/expressions/.deps/pgsNegate.Po: No such file or directory
Makefile:1075: ../../../pgadmin/pgscript/expressions/.deps/pgsNot.Po: No such file or directory
Makefile:1076: ../../../pgadmin/pgscript/expressions/.deps/pgsOperation.Po: No such file or directory
Makefile:1077: ../../../pgadmin/pgscript/expressions/.deps/pgsOr.Po: No such file or directory
Makefile:1078: ../../../pgadmin/pgscript/expressions/.deps/pgsOver.Po: No such file or directory
Makefile:1079: ../../../pgadmin/pgscript/expressions/.deps/pgsParenthesis.Po: No such file or directory
Makefile:1080: ../../../pgadmin/pgscript/expressions/.deps/pgsPlus.Po: No such file or directory
Makefile:1081: ../../../pgadmin/pgscript/expressions/.deps/pgsRemoveLine.Po: No such file or directory
Makefile:1082: ../../../pgadmin/pgscript/expressions/.deps/pgsTimes.Po: No such file or directory
Makefile:1083: ../../../pgadmin/pgscript/expressions/.deps/pgsTrim.Po: No such file or directory
Makefile:1084: ../../../pgadmin/pgscript/generators/.deps/pgsDateGen.Po: No such file or directory
Makefile:1085: ../../../pgadmin/pgscript/generators/.deps/pgsDateTimeGen.Po: No such file or directory
Makefile:1086: ../../../pgadmin/pgscript/generators/.deps/pgsDictionaryGen.Po: No such file or directory
Makefile:1087: ../../../pgadmin/pgscript/generators/.deps/pgsIntegerGen.Po: No such file or directory
Makefile:1088: ../../../pgadmin/pgscript/generators/.deps/pgsNumberGen.Po: No such file or directory
Makefile:1089: ../../../pgadmin/pgscript/generators/.deps/pgsObjectGen.Po: No such file or directory
Makefile:1090: ../../../pgadmin/pgscript/generators/.deps/pgsRealGen.Po: No such file or directory
Makefile:1091: ../../../pgadmin/pgscript/generators/.deps/pgsReferenceGen.Po: No such file or directory
Makefile:1092: ../../../pgadmin/pgscript/generators/.deps/pgsRegexGen.Po: No such file or directory
Makefile:1093: ../../../pgadmin/pgscript/generators/.deps/pgsStringGen.Po: No such file or directory
Makefile:1094: ../../../pgadmin/pgscript/generators/.deps/pgsTimeGen.Po: No such file or directory
Makefile:1095: ../../../pgadmin/pgscript/objects/.deps/pgsGenerator.Po: No such file or directory
Makefile:1096: ../../../pgadmin/pgscript/objects/.deps/pgsNumber.Po: No such file or directory
Makefile:1097: ../../../pgadmin/pgscript/objects/.deps/pgsRecord.Po: No such file or directory
Makefile:1098: ../../../pgadmin/pgscript/objects/.deps/pgsString.Po: No such file or directory
Makefile:1099: ../../../pgadmin/pgscript/objects/.deps/pgsVariable.Po: No such file or directory
Makefile:1100: ../../../pgadmin/pgscript/statements/.deps/pgsAssertStmt.Po: No such file or directory
Makefile:1101: ../../../pgadmin/pgscript/statements/.deps/pgsBreakStmt.Po: No such file or directory
Makefile:1102: ../../../pgadmin/pgscript/statements/.deps/pgsContinueStmt.Po: No such file or directory
Makefile:1103: ../../../pgadmin/pgscript/statements/.deps/pgsDeclareRecordStmt.Po: No such file or directory
Makefile:1104: ../../../pgadmin/pgscript/statements/.deps/pgsExpressionStmt.Po: No such file or directory
Makefile:1105: ../../../pgadmin/pgscript/statements/.deps/pgsIfStmt.Po: No such file or directory
Makefile:1106: ../../../pgadmin/pgscript/statements/.deps/pgsPrintStmt.Po: No such file or directory
Makefile:1107: ../../../pgadmin/pgscript/statements/.deps/pgsProgram.Po: No such file or directory
Makefile:1108: ../../../pgadmin/pgscript/statements/.deps/pgsStmt.Po: No such file or directory
Makefile:1109: ../../../pgadmin/pgscript/statements/.deps/pgsStmtList.Po: No such file or directory
Makefile:1110: ../../../pgadmin/pgscript/statements/.deps/pgsWhileStmt.Po: No such file or directory
Makefile:1111: ../../../pgadmin/pgscript/utilities/.deps/pgsAlloc.Po: No such file or directory
Makefile:1112: ../../../pgadmin/pgscript/utilities/.deps/pgsContext.Po: No such file or directory
Makefile:1113: ../../../pgadmin/pgscript/utilities/.deps/pgsDriver.Po: No such file or directory
Makefile:1114: ../../../pgadmin/pgscript/utilities/.deps/pgsMapm.Po: No such file or directory
Makefile:1115: ../../../pgadmin/pgscript/utilities/.deps/pgsThread.Po: No such file or directory
Makefile:1116: ../../../pgadmin/pgscript/utilities/.deps/pgsUtilities.Po: No such file or directory
Makefile:1117: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm5sin.Po: No such file or directory
Makefile:1118: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_add.Po: No such file or directory
Makefile:1119: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_cpi.Po: No such file or directory
Makefile:1120: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_div.Po: No such file or directory
Makefile:1121: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_exp.Po: No such file or directory
Makefile:1122: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fam.Po: No such file or directory
Makefile:1123: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fft.Po: No such file or directory
Makefile:1124: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_flr.Po: No such file or directory
Makefile:1125: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fpf.Po: No such file or directory
Makefile:1126: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_gcd.Po: No such file or directory
Makefile:1127: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg2.Po: No such file or directory
Makefile:1128: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg3.Po: No such file or directory
Makefile:1129: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg4.Po: No such file or directory
Makefile:1130: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_log.Po: No such file or directory
Makefile:1131: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_mul.Po: No such file or directory
Makefile:1132: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_pow.Po: No such file or directory
Makefile:1133: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rcp.Po: No such file or directory
Makefile:1134: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rnd.Po: No such file or directory
Makefile:1135: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_set.Po: No such file or directory
Makefile:1136: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_sin.Po: No such file or directory
Makefile:1137: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasin.Po: No such file or directory
Makefile:1138: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasn0.Po: No such file or directory
Makefile:1139: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcbrt.Po: No such file or directory
Makefile:1140: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcnst.Po: No such file or directory
Makefile:1141: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfact.Po: No such file or directory
Makefile:1142: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfmul.Po: No such file or directory
Makefile:1143: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmgues.Po: No such file or directory
Makefile:1144: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhasn.Po: No such file or directory
Makefile:1145: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhsin.Po: No such file or directory
Makefile:1146: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmipwr.Po: No such file or directory
Makefile:1147: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmistr.Po: No such file or directory
Makefile:1148: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmpwr2.Po: No such file or directory
Makefile:1149: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmrsin.Po: No such file or directory
Makefile:1150: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmsqrt.Po: No such file or directory
Makefile:1151: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmstck.Po: No such file or directory
Makefile:1152: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutil.Po: No such file or directory
Makefile:1153: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl1.Po: No such file or directory
Makefile:1154: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl2.Po: No such file or directory
Makefile:1155: ../../../pgadmin/utils/.deps/misc.Po: No such file or directory
Makefile:1156: ../../../pgadmin/utils/.deps/sysLogger.Po: No such file or directory
make[3]: *** No rule to make target `../../../pgadmin/utils/.deps/sysLogger.Po'.  Stop.
make[2]: *** [distclean-recursive] Error 1
make[1]: *** [distclean-recursive] Error 1
make: *** [distclean-recursive] Error 1


On Wed, May 8, 2013 at 10:24 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Ashesh Vashi
Date:
On Thu, May 9, 2013 at 4:44 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi



On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

I needed to modify the configuration at quite a lot places to make it work properly.
And, looks like the pgscript has not been compiled by anyone from long time and I can say that because, it has been horribly broken.
If we're going to support the stand-alone pgscript application, we will need to modify the code accordingly.
There are many changes done in the pgadmin3 code, which are shared by pgscript. And, we've not taken care about pgscript affected areas.

Honestly, I don't think we need to keep that there. pgScript was originally written as a GSOC project by Mickael Deloison, and later added to pgAdmin as a second project (iirc, Magnus mentored). We included the command line interpretor just to give it a home, but as it hasn't been touched since it was added and isn't used for anything it should probably go.

Any comments Magnus, Mickael?

How much would that cleanup the patch you've submitted Ashesh? At a quick glance I guess at least the last hunk would be redundant.
It has not touch the code base, shared by pgscript.
But - only changes made are to generate separate objects for both targets (pgscript & pgAdmin3).
pgscript is yet not be compiled using this patch. 

Also - the subdir-object changes (in configuration) had introduced the dependency on the actual objects for each target (Here - pgscript and pgadmin3), because the objects are getting generated in the respective directories instead of target directory. And, that dependency leads to this distclean issue, because the source/object files are shared between this two targets, and that too in different Makefiles, and one of the target cleans those objects, other can not find it.
It is not able to identify two targets using the same objects (and, enable the renaming of objects never comes into picture, not even if we set the _SHORTNAME property for those targets. reference: http://www.gnu.org/software/automake/manual/html_node/Renamed-Objects.html)
And, because of the dependency on actual objects, they're not regenerating the objects, which they must because they do have different CXXFLAGS.

For the moment, I have fixed the 'make distclean' and cleaned up the configurations. Also - I've introduced the new object extension (.pgso) in pgscript Makefile.am to enable it to build separate object files from pgadmin3.

Though - need some more work to resolve the pgscript compilation issue.
We can do it later (if nobody is using it at the moment.)

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: 
Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

On Wed, May 8, 2013 at 5:09 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied.

When testing this, I noticed that the distclean target seems to be broken now. Can you (or one of the team) please take a look? Thanks.

viper:pgadmin3 dpage$ make distclean
Making distclean in xtra/png2c
make[1]: Nothing to be done for `distclean'.
Making distclean in branding
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in i18n
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in plugins.d
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in pgadmin
test -z "pgadmin3" || rm -f pgadmin3
rm -f include/images/*.pngc
rm -f *.o
rm -f *.tab.c
test -z "" || rm -f 
rm -f agent/*.o
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f 
rm -f ctl/*.o
rm -f agent/.deps/.dirstamp
rm -f agent/.dirstamp
rm -f ctl/.deps/.dirstamp
rm -f db/*.o
rm -f ctl/.dirstamp
rm -f db/.deps/.dirstamp
rm -f db/.dirstamp
rm -f dd/dditems/figures/*.o
rm -f dd/dditems/figures/.deps/.dirstamp
rm -f dd/dditems/figures/.dirstamp
rm -f dd/dditems/figures/xml/.deps/.dirstamp
rm -f dd/dditems/figures/xml/*.o
rm -f dd/dditems/figures/xml/.dirstamp
rm -f dd/dditems/handles/.deps/.dirstamp
rm -f dd/dditems/handles/*.o
rm -f dd/dditems/handles/.dirstamp
rm -f dd/dditems/locators/.deps/.dirstamp
rm -f dd/dditems/locators/.dirstamp
rm -f dd/dditems/locators/*.o
rm -f dd/dditems/tools/.deps/.dirstamp
rm -f dd/dditems/tools/.dirstamp
rm -f dd/dditems/utilities/.deps/.dirstamp
rm -f dd/dditems/tools/*.o
rm -f dd/dditems/utilities/.dirstamp
rm -f dd/ddmodel/.deps/.dirstamp
rm -f dd/dditems/utilities/*.o
rm -f dd/ddmodel/.dirstamp
rm -f debugger/.deps/.dirstamp
rm -f dd/ddmodel/*.o
rm -f debugger/.dirstamp
rm -f dlg/.deps/.dirstamp
rm -f dlg/.dirstamp
rm -f debugger/*.o
rm -f frm/.deps/.dirstamp
rm -f frm/.dirstamp
rm -f dlg/*.o
rm -f gqb/.deps/.dirstamp
rm -f gqb/.dirstamp
rm -f hotdraw/connectors/.deps/.dirstamp
rm -f hotdraw/connectors/.dirstamp
rm -f hotdraw/figures/.deps/.dirstamp
rm -f hotdraw/figures/.dirstamp
rm -f frm/*.o
rm -f hotdraw/figures/defaultAttributes/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/.dirstamp
rm -f hotdraw/figures/xml/.deps/.dirstamp
rm -f gqb/*.o
rm -f hotdraw/figures/xml/.dirstamp
rm -f hotdraw/handles/.deps/.dirstamp
rm -f hotdraw/handles/.dirstamp
rm -f hotdraw/connectors/*.o
rm -f hotdraw/locators/.deps/.dirstamp
rm -f hotdraw/locators/.dirstamp
rm -f hotdraw/figures/*.o
rm -f hotdraw/main/.deps/.dirstamp
rm -f hotdraw/main/.dirstamp
rm -f hotdraw/tools/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/*.o
rm -f hotdraw/tools/.dirstamp
rm -f hotdraw/utilities/.deps/.dirstamp
rm -f hotdraw/figures/xml/*.o
rm -f hotdraw/utilities/.dirstamp
rm -f libssh2/.deps/.dirstamp
rm -f libssh2/.dirstamp
rm -f hotdraw/handles/*.o
rm -f ogl/.deps/.dirstamp
rm -f ogl/.dirstamp
rm -f hotdraw/locators/*.o
rm -f pgscript/.deps/.dirstamp
rm -f pgscript/.dirstamp
rm -f hotdraw/main/*.o
rm -f pgscript/exceptions/.deps/.dirstamp
rm -f pgscript/exceptions/.dirstamp
rm -f pgscript/expressions/.deps/.dirstamp
rm -f hotdraw/tools/*.o
rm -f pgscript/expressions/.dirstamp
rm -f pgscript/generators/.deps/.dirstamp
rm -f hotdraw/utilities/*.o
rm -f pgscript/generators/.dirstamp
rm -f pgscript/objects/.deps/.dirstamp
rm -f pgscript/objects/.dirstamp
rm -f libssh2/*.o
rm -f pgscript/statements/.deps/.dirstamp
rm -f pgscript/statements/.dirstamp
rm -f pgscript/utilities/.deps/.dirstamp
rm -f ogl/*.o
rm -f pgscript/utilities/.dirstamp
rm -f pgscript/utilities/m_apm/.deps/.dirstamp
rm -f pgscript/utilities/m_apm/.dirstamp
rm -f pgscript/*.o
rm -f schema/.deps/.dirstamp
rm -f schema/.dirstamp
rm -f pgscript/exceptions/*.o
rm -f slony/.deps/.dirstamp
rm -f slony/.dirstamp
rm -f ui/.deps/.dirstamp
rm -f pgscript/expressions/*.o
rm -f ui/.dirstamp
rm -f utils/.deps/.dirstamp
rm -f utils/.dirstamp
rm -f pgscript/generators/*.o
rm -f pgscript/objects/*.o
rm -f pgscript/statements/*.o
rm -f pgscript/utilities/*.o
rm -f pgscript/utilities/m_apm/*.o
rm -f schema/*.o
rm -f slony/*.o
rm -f ui/*.o
rm -f utils/*.o
rm -rf ./.deps agent/.deps ctl/.deps db/.deps dd/dditems/figures/.deps dd/dditems/figures/xml/.deps dd/dditems/handles/.deps dd/dditems/locators/.deps dd/dditems/tools/.deps dd/dditems/utilities/.deps dd/ddmodel/.deps debugger/.deps dlg/.deps frm/.deps gqb/.deps hotdraw/connectors/.deps hotdraw/figures/.deps hotdraw/figures/defaultAttributes/.deps hotdraw/figures/xml/.deps hotdraw/handles/.deps hotdraw/locators/.deps hotdraw/main/.deps hotdraw/tools/.deps hotdraw/utilities/.deps libssh2/.deps ogl/.deps pgscript/.deps pgscript/exceptions/.deps pgscript/expressions/.deps pgscript/generators/.deps pgscript/objects/.deps pgscript/statements/.deps pgscript/utilities/.deps pgscript/utilities/m_apm/.deps schema/.deps slony/.deps ui/.deps utils/.deps
rm -f Makefile
Making distclean in xtra
Making distclean in png2c
make[2]: Nothing to be done for `distclean'.
Making distclean in pgscript
Making distclean in lib
Makefile:1032: ../../../pgadmin/db/.deps/keywords.Po: No such file or directory
Makefile:1033: ../../../pgadmin/db/.deps/pgConn.Po: No such file or directory
Makefile:1034: ../../../pgadmin/db/.deps/pgQueryThread.Po: No such file or directory
Makefile:1035: ../../../pgadmin/db/.deps/pgSet.Po: No such file or directory
Makefile:1036: ../../../pgadmin/pgscript/.deps/lex.pgs.Po: No such file or directory
Makefile:1037: ../../../pgadmin/pgscript/.deps/parser.tab.Po: No such file or directory
Makefile:1038: ../../../pgadmin/pgscript/.deps/pgsApplication.Po: No such file or directory
Makefile:1039: ../../../pgadmin/pgscript/exceptions/.deps/pgsArithmeticException.Po: No such file or directory
Makefile:1040: ../../../pgadmin/pgscript/exceptions/.deps/pgsAssertException.Po: No such file or directory
Makefile:1041: ../../../pgadmin/pgscript/exceptions/.deps/pgsBreakException.Po: No such file or directory
Makefile:1042: ../../../pgadmin/pgscript/exceptions/.deps/pgsCastException.Po: No such file or directory
Makefile:1043: ../../../pgadmin/pgscript/exceptions/.deps/pgsContinueException.Po: No such file or directory
Makefile:1044: ../../../pgadmin/pgscript/exceptions/.deps/pgsException.Po: No such file or directory
Makefile:1045: ../../../pgadmin/pgscript/exceptions/.deps/pgsInterruptException.Po: No such file or directory
Makefile:1046: ../../../pgadmin/pgscript/exceptions/.deps/pgsParameterException.Po: No such file or directory
Makefile:1047: ../../../pgadmin/pgscript/expressions/.deps/pgsAnd.Po: No such file or directory
Makefile:1048: ../../../pgadmin/pgscript/expressions/.deps/pgsAssign.Po: No such file or directory
Makefile:1049: ../../../pgadmin/pgscript/expressions/.deps/pgsAssignToRecord.Po: No such file or directory
Makefile:1050: ../../../pgadmin/pgscript/expressions/.deps/pgsCast.Po: No such file or directory
Makefile:1051: ../../../pgadmin/pgscript/expressions/.deps/pgsColumns.Po: No such file or directory
Makefile:1052: ../../../pgadmin/pgscript/expressions/.deps/pgsDifferent.Po: No such file or directory
Makefile:1053: ../../../pgadmin/pgscript/expressions/.deps/pgsEqual.Po: No such file or directory
Makefile:1054: ../../../pgadmin/pgscript/expressions/.deps/pgsExecute.Po: No such file or directory
Makefile:1055: ../../../pgadmin/pgscript/expressions/.deps/pgsExpression.Po: No such file or directory
Makefile:1056: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDate.Po: No such file or directory
Makefile:1057: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDateTime.Po: No such file or directory
Makefile:1058: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDictionary.Po: No such file or directory
Makefile:1059: ../../../pgadmin/pgscript/expressions/.deps/pgsGenInt.Po: No such file or directory
Makefile:1060: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReal.Po: No such file or directory
Makefile:1061: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReference.Po: No such file or directory
Makefile:1062: ../../../pgadmin/pgscript/expressions/.deps/pgsGenRegex.Po: No such file or directory
Makefile:1063: ../../../pgadmin/pgscript/expressions/.deps/pgsGenString.Po: No such file or directory
Makefile:1064: ../../../pgadmin/pgscript/expressions/.deps/pgsGenTime.Po: No such file or directory
Makefile:1065: ../../../pgadmin/pgscript/expressions/.deps/pgsGreater.Po: No such file or directory
Makefile:1066: ../../../pgadmin/pgscript/expressions/.deps/pgsGreaterEqual.Po: No such file or directory
Makefile:1067: ../../../pgadmin/pgscript/expressions/.deps/pgsIdent.Po: No such file or directory
Makefile:1068: ../../../pgadmin/pgscript/expressions/.deps/pgsIdentRecord.Po: No such file or directory
Makefile:1069: ../../../pgadmin/pgscript/expressions/.deps/pgsLines.Po: No such file or directory
Makefile:1070: ../../../pgadmin/pgscript/expressions/.deps/pgsLower.Po: No such file or directory
Makefile:1071: ../../../pgadmin/pgscript/expressions/.deps/pgsLowerEqual.Po: No such file or directory
Makefile:1072: ../../../pgadmin/pgscript/expressions/.deps/pgsMinus.Po: No such file or directory
Makefile:1073: ../../../pgadmin/pgscript/expressions/.deps/pgsModulo.Po: No such file or directory
Makefile:1074: ../../../pgadmin/pgscript/expressions/.deps/pgsNegate.Po: No such file or directory
Makefile:1075: ../../../pgadmin/pgscript/expressions/.deps/pgsNot.Po: No such file or directory
Makefile:1076: ../../../pgadmin/pgscript/expressions/.deps/pgsOperation.Po: No such file or directory
Makefile:1077: ../../../pgadmin/pgscript/expressions/.deps/pgsOr.Po: No such file or directory
Makefile:1078: ../../../pgadmin/pgscript/expressions/.deps/pgsOver.Po: No such file or directory
Makefile:1079: ../../../pgadmin/pgscript/expressions/.deps/pgsParenthesis.Po: No such file or directory
Makefile:1080: ../../../pgadmin/pgscript/expressions/.deps/pgsPlus.Po: No such file or directory
Makefile:1081: ../../../pgadmin/pgscript/expressions/.deps/pgsRemoveLine.Po: No such file or directory
Makefile:1082: ../../../pgadmin/pgscript/expressions/.deps/pgsTimes.Po: No such file or directory
Makefile:1083: ../../../pgadmin/pgscript/expressions/.deps/pgsTrim.Po: No such file or directory
Makefile:1084: ../../../pgadmin/pgscript/generators/.deps/pgsDateGen.Po: No such file or directory
Makefile:1085: ../../../pgadmin/pgscript/generators/.deps/pgsDateTimeGen.Po: No such file or directory
Makefile:1086: ../../../pgadmin/pgscript/generators/.deps/pgsDictionaryGen.Po: No such file or directory
Makefile:1087: ../../../pgadmin/pgscript/generators/.deps/pgsIntegerGen.Po: No such file or directory
Makefile:1088: ../../../pgadmin/pgscript/generators/.deps/pgsNumberGen.Po: No such file or directory
Makefile:1089: ../../../pgadmin/pgscript/generators/.deps/pgsObjectGen.Po: No such file or directory
Makefile:1090: ../../../pgadmin/pgscript/generators/.deps/pgsRealGen.Po: No such file or directory
Makefile:1091: ../../../pgadmin/pgscript/generators/.deps/pgsReferenceGen.Po: No such file or directory
Makefile:1092: ../../../pgadmin/pgscript/generators/.deps/pgsRegexGen.Po: No such file or directory
Makefile:1093: ../../../pgadmin/pgscript/generators/.deps/pgsStringGen.Po: No such file or directory
Makefile:1094: ../../../pgadmin/pgscript/generators/.deps/pgsTimeGen.Po: No such file or directory
Makefile:1095: ../../../pgadmin/pgscript/objects/.deps/pgsGenerator.Po: No such file or directory
Makefile:1096: ../../../pgadmin/pgscript/objects/.deps/pgsNumber.Po: No such file or directory
Makefile:1097: ../../../pgadmin/pgscript/objects/.deps/pgsRecord.Po: No such file or directory
Makefile:1098: ../../../pgadmin/pgscript/objects/.deps/pgsString.Po: No such file or directory
Makefile:1099: ../../../pgadmin/pgscript/objects/.deps/pgsVariable.Po: No such file or directory
Makefile:1100: ../../../pgadmin/pgscript/statements/.deps/pgsAssertStmt.Po: No such file or directory
Makefile:1101: ../../../pgadmin/pgscript/statements/.deps/pgsBreakStmt.Po: No such file or directory
Makefile:1102: ../../../pgadmin/pgscript/statements/.deps/pgsContinueStmt.Po: No such file or directory
Makefile:1103: ../../../pgadmin/pgscript/statements/.deps/pgsDeclareRecordStmt.Po: No such file or directory
Makefile:1104: ../../../pgadmin/pgscript/statements/.deps/pgsExpressionStmt.Po: No such file or directory
Makefile:1105: ../../../pgadmin/pgscript/statements/.deps/pgsIfStmt.Po: No such file or directory
Makefile:1106: ../../../pgadmin/pgscript/statements/.deps/pgsPrintStmt.Po: No such file or directory
Makefile:1107: ../../../pgadmin/pgscript/statements/.deps/pgsProgram.Po: No such file or directory
Makefile:1108: ../../../pgadmin/pgscript/statements/.deps/pgsStmt.Po: No such file or directory
Makefile:1109: ../../../pgadmin/pgscript/statements/.deps/pgsStmtList.Po: No such file or directory
Makefile:1110: ../../../pgadmin/pgscript/statements/.deps/pgsWhileStmt.Po: No such file or directory
Makefile:1111: ../../../pgadmin/pgscript/utilities/.deps/pgsAlloc.Po: No such file or directory
Makefile:1112: ../../../pgadmin/pgscript/utilities/.deps/pgsContext.Po: No such file or directory
Makefile:1113: ../../../pgadmin/pgscript/utilities/.deps/pgsDriver.Po: No such file or directory
Makefile:1114: ../../../pgadmin/pgscript/utilities/.deps/pgsMapm.Po: No such file or directory
Makefile:1115: ../../../pgadmin/pgscript/utilities/.deps/pgsThread.Po: No such file or directory
Makefile:1116: ../../../pgadmin/pgscript/utilities/.deps/pgsUtilities.Po: No such file or directory
Makefile:1117: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm5sin.Po: No such file or directory
Makefile:1118: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_add.Po: No such file or directory
Makefile:1119: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_cpi.Po: No such file or directory
Makefile:1120: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_div.Po: No such file or directory
Makefile:1121: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_exp.Po: No such file or directory
Makefile:1122: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fam.Po: No such file or directory
Makefile:1123: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fft.Po: No such file or directory
Makefile:1124: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_flr.Po: No such file or directory
Makefile:1125: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fpf.Po: No such file or directory
Makefile:1126: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_gcd.Po: No such file or directory
Makefile:1127: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg2.Po: No such file or directory
Makefile:1128: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg3.Po: No such file or directory
Makefile:1129: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg4.Po: No such file or directory
Makefile:1130: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_log.Po: No such file or directory
Makefile:1131: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_mul.Po: No such file or directory
Makefile:1132: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_pow.Po: No such file or directory
Makefile:1133: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rcp.Po: No such file or directory
Makefile:1134: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rnd.Po: No such file or directory
Makefile:1135: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_set.Po: No such file or directory
Makefile:1136: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_sin.Po: No such file or directory
Makefile:1137: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasin.Po: No such file or directory
Makefile:1138: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasn0.Po: No such file or directory
Makefile:1139: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcbrt.Po: No such file or directory
Makefile:1140: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcnst.Po: No such file or directory
Makefile:1141: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfact.Po: No such file or directory
Makefile:1142: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfmul.Po: No such file or directory
Makefile:1143: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmgues.Po: No such file or directory
Makefile:1144: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhasn.Po: No such file or directory
Makefile:1145: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhsin.Po: No such file or directory
Makefile:1146: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmipwr.Po: No such file or directory
Makefile:1147: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmistr.Po: No such file or directory
Makefile:1148: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmpwr2.Po: No such file or directory
Makefile:1149: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmrsin.Po: No such file or directory
Makefile:1150: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmsqrt.Po: No such file or directory
Makefile:1151: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmstck.Po: No such file or directory
Makefile:1152: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutil.Po: No such file or directory
Makefile:1153: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl1.Po: No such file or directory
Makefile:1154: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl2.Po: No such file or directory
Makefile:1155: ../../../pgadmin/utils/.deps/misc.Po: No such file or directory
Makefile:1156: ../../../pgadmin/utils/.deps/sysLogger.Po: No such file or directory
make[3]: *** No rule to make target `../../../pgadmin/utils/.deps/sysLogger.Po'.  Stop.
make[2]: *** [distclean-recursive] Error 1
make[1]: *** [distclean-recursive] Error 1
make: *** [distclean-recursive] Error 1


On Wed, May 8, 2013 at 10:24 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Dave Page
Date:
OK, I've pushed this as-is for now. We'll remove the pgscript CLI in a few days if noone exists.

I had a couple of other thoughts whilst playing with VPATH builds - shouldn't the doc and png2c output (*.pngc) be redirected to $(top_builddir), or is there a reason we don't currently do that? Can you check that please?

Thanks.


On Thu, May 9, 2013 at 1:02 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, May 9, 2013 at 4:44 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi



On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

I needed to modify the configuration at quite a lot places to make it work properly.
And, looks like the pgscript has not been compiled by anyone from long time and I can say that because, it has been horribly broken.
If we're going to support the stand-alone pgscript application, we will need to modify the code accordingly.
There are many changes done in the pgadmin3 code, which are shared by pgscript. And, we've not taken care about pgscript affected areas.

Honestly, I don't think we need to keep that there. pgScript was originally written as a GSOC project by Mickael Deloison, and later added to pgAdmin as a second project (iirc, Magnus mentored). We included the command line interpretor just to give it a home, but as it hasn't been touched since it was added and isn't used for anything it should probably go.

Any comments Magnus, Mickael?

How much would that cleanup the patch you've submitted Ashesh? At a quick glance I guess at least the last hunk would be redundant.
It has not touch the code base, shared by pgscript.
But - only changes made are to generate separate objects for both targets (pgscript & pgAdmin3).
pgscript is yet not be compiled using this patch. 

Also - the subdir-object changes (in configuration) had introduced the dependency on the actual objects for each target (Here - pgscript and pgadmin3), because the objects are getting generated in the respective directories instead of target directory. And, that dependency leads to this distclean issue, because the source/object files are shared between this two targets, and that too in different Makefiles, and one of the target cleans those objects, other can not find it.
It is not able to identify two targets using the same objects (and, enable the renaming of objects never comes into picture, not even if we set the _SHORTNAME property for those targets. reference: http://www.gnu.org/software/automake/manual/html_node/Renamed-Objects.html)
And, because of the dependency on actual objects, they're not regenerating the objects, which they must because they do have different CXXFLAGS.

For the moment, I have fixed the 'make distclean' and cleaned up the configurations. Also - I've introduced the new object extension (.pgso) in pgscript Makefile.am to enable it to build separate object files from pgadmin3.

Though - need some more work to resolve the pgscript compilation issue.
We can do it later (if nobody is using it at the moment.)

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: 
Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

On Wed, May 8, 2013 at 5:09 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied.

When testing this, I noticed that the distclean target seems to be broken now. Can you (or one of the team) please take a look? Thanks.

viper:pgadmin3 dpage$ make distclean
Making distclean in xtra/png2c
make[1]: Nothing to be done for `distclean'.
Making distclean in branding
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in i18n
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in plugins.d
test -z "" || rm -f 
test . = "." || test -z "" || rm -f 
rm -f Makefile
Making distclean in pgadmin
test -z "pgadmin3" || rm -f pgadmin3
rm -f include/images/*.pngc
rm -f *.o
rm -f *.tab.c
test -z "" || rm -f 
rm -f agent/*.o
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f 
rm -f ctl/*.o
rm -f agent/.deps/.dirstamp
rm -f agent/.dirstamp
rm -f ctl/.deps/.dirstamp
rm -f db/*.o
rm -f ctl/.dirstamp
rm -f db/.deps/.dirstamp
rm -f db/.dirstamp
rm -f dd/dditems/figures/*.o
rm -f dd/dditems/figures/.deps/.dirstamp
rm -f dd/dditems/figures/.dirstamp
rm -f dd/dditems/figures/xml/.deps/.dirstamp
rm -f dd/dditems/figures/xml/*.o
rm -f dd/dditems/figures/xml/.dirstamp
rm -f dd/dditems/handles/.deps/.dirstamp
rm -f dd/dditems/handles/*.o
rm -f dd/dditems/handles/.dirstamp
rm -f dd/dditems/locators/.deps/.dirstamp
rm -f dd/dditems/locators/.dirstamp
rm -f dd/dditems/locators/*.o
rm -f dd/dditems/tools/.deps/.dirstamp
rm -f dd/dditems/tools/.dirstamp
rm -f dd/dditems/utilities/.deps/.dirstamp
rm -f dd/dditems/tools/*.o
rm -f dd/dditems/utilities/.dirstamp
rm -f dd/ddmodel/.deps/.dirstamp
rm -f dd/dditems/utilities/*.o
rm -f dd/ddmodel/.dirstamp
rm -f debugger/.deps/.dirstamp
rm -f dd/ddmodel/*.o
rm -f debugger/.dirstamp
rm -f dlg/.deps/.dirstamp
rm -f dlg/.dirstamp
rm -f debugger/*.o
rm -f frm/.deps/.dirstamp
rm -f frm/.dirstamp
rm -f dlg/*.o
rm -f gqb/.deps/.dirstamp
rm -f gqb/.dirstamp
rm -f hotdraw/connectors/.deps/.dirstamp
rm -f hotdraw/connectors/.dirstamp
rm -f hotdraw/figures/.deps/.dirstamp
rm -f hotdraw/figures/.dirstamp
rm -f frm/*.o
rm -f hotdraw/figures/defaultAttributes/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/.dirstamp
rm -f hotdraw/figures/xml/.deps/.dirstamp
rm -f gqb/*.o
rm -f hotdraw/figures/xml/.dirstamp
rm -f hotdraw/handles/.deps/.dirstamp
rm -f hotdraw/handles/.dirstamp
rm -f hotdraw/connectors/*.o
rm -f hotdraw/locators/.deps/.dirstamp
rm -f hotdraw/locators/.dirstamp
rm -f hotdraw/figures/*.o
rm -f hotdraw/main/.deps/.dirstamp
rm -f hotdraw/main/.dirstamp
rm -f hotdraw/tools/.deps/.dirstamp
rm -f hotdraw/figures/defaultAttributes/*.o
rm -f hotdraw/tools/.dirstamp
rm -f hotdraw/utilities/.deps/.dirstamp
rm -f hotdraw/figures/xml/*.o
rm -f hotdraw/utilities/.dirstamp
rm -f libssh2/.deps/.dirstamp
rm -f libssh2/.dirstamp
rm -f hotdraw/handles/*.o
rm -f ogl/.deps/.dirstamp
rm -f ogl/.dirstamp
rm -f hotdraw/locators/*.o
rm -f pgscript/.deps/.dirstamp
rm -f pgscript/.dirstamp
rm -f hotdraw/main/*.o
rm -f pgscript/exceptions/.deps/.dirstamp
rm -f pgscript/exceptions/.dirstamp
rm -f pgscript/expressions/.deps/.dirstamp
rm -f hotdraw/tools/*.o
rm -f pgscript/expressions/.dirstamp
rm -f pgscript/generators/.deps/.dirstamp
rm -f hotdraw/utilities/*.o
rm -f pgscript/generators/.dirstamp
rm -f pgscript/objects/.deps/.dirstamp
rm -f pgscript/objects/.dirstamp
rm -f libssh2/*.o
rm -f pgscript/statements/.deps/.dirstamp
rm -f pgscript/statements/.dirstamp
rm -f pgscript/utilities/.deps/.dirstamp
rm -f ogl/*.o
rm -f pgscript/utilities/.dirstamp
rm -f pgscript/utilities/m_apm/.deps/.dirstamp
rm -f pgscript/utilities/m_apm/.dirstamp
rm -f pgscript/*.o
rm -f schema/.deps/.dirstamp
rm -f schema/.dirstamp
rm -f pgscript/exceptions/*.o
rm -f slony/.deps/.dirstamp
rm -f slony/.dirstamp
rm -f ui/.deps/.dirstamp
rm -f pgscript/expressions/*.o
rm -f ui/.dirstamp
rm -f utils/.deps/.dirstamp
rm -f utils/.dirstamp
rm -f pgscript/generators/*.o
rm -f pgscript/objects/*.o
rm -f pgscript/statements/*.o
rm -f pgscript/utilities/*.o
rm -f pgscript/utilities/m_apm/*.o
rm -f schema/*.o
rm -f slony/*.o
rm -f ui/*.o
rm -f utils/*.o
rm -rf ./.deps agent/.deps ctl/.deps db/.deps dd/dditems/figures/.deps dd/dditems/figures/xml/.deps dd/dditems/handles/.deps dd/dditems/locators/.deps dd/dditems/tools/.deps dd/dditems/utilities/.deps dd/ddmodel/.deps debugger/.deps dlg/.deps frm/.deps gqb/.deps hotdraw/connectors/.deps hotdraw/figures/.deps hotdraw/figures/defaultAttributes/.deps hotdraw/figures/xml/.deps hotdraw/handles/.deps hotdraw/locators/.deps hotdraw/main/.deps hotdraw/tools/.deps hotdraw/utilities/.deps libssh2/.deps ogl/.deps pgscript/.deps pgscript/exceptions/.deps pgscript/expressions/.deps pgscript/generators/.deps pgscript/objects/.deps pgscript/statements/.deps pgscript/utilities/.deps pgscript/utilities/m_apm/.deps schema/.deps slony/.deps ui/.deps utils/.deps
rm -f Makefile
Making distclean in xtra
Making distclean in png2c
make[2]: Nothing to be done for `distclean'.
Making distclean in pgscript
Making distclean in lib
Makefile:1032: ../../../pgadmin/db/.deps/keywords.Po: No such file or directory
Makefile:1033: ../../../pgadmin/db/.deps/pgConn.Po: No such file or directory
Makefile:1034: ../../../pgadmin/db/.deps/pgQueryThread.Po: No such file or directory
Makefile:1035: ../../../pgadmin/db/.deps/pgSet.Po: No such file or directory
Makefile:1036: ../../../pgadmin/pgscript/.deps/lex.pgs.Po: No such file or directory
Makefile:1037: ../../../pgadmin/pgscript/.deps/parser.tab.Po: No such file or directory
Makefile:1038: ../../../pgadmin/pgscript/.deps/pgsApplication.Po: No such file or directory
Makefile:1039: ../../../pgadmin/pgscript/exceptions/.deps/pgsArithmeticException.Po: No such file or directory
Makefile:1040: ../../../pgadmin/pgscript/exceptions/.deps/pgsAssertException.Po: No such file or directory
Makefile:1041: ../../../pgadmin/pgscript/exceptions/.deps/pgsBreakException.Po: No such file or directory
Makefile:1042: ../../../pgadmin/pgscript/exceptions/.deps/pgsCastException.Po: No such file or directory
Makefile:1043: ../../../pgadmin/pgscript/exceptions/.deps/pgsContinueException.Po: No such file or directory
Makefile:1044: ../../../pgadmin/pgscript/exceptions/.deps/pgsException.Po: No such file or directory
Makefile:1045: ../../../pgadmin/pgscript/exceptions/.deps/pgsInterruptException.Po: No such file or directory
Makefile:1046: ../../../pgadmin/pgscript/exceptions/.deps/pgsParameterException.Po: No such file or directory
Makefile:1047: ../../../pgadmin/pgscript/expressions/.deps/pgsAnd.Po: No such file or directory
Makefile:1048: ../../../pgadmin/pgscript/expressions/.deps/pgsAssign.Po: No such file or directory
Makefile:1049: ../../../pgadmin/pgscript/expressions/.deps/pgsAssignToRecord.Po: No such file or directory
Makefile:1050: ../../../pgadmin/pgscript/expressions/.deps/pgsCast.Po: No such file or directory
Makefile:1051: ../../../pgadmin/pgscript/expressions/.deps/pgsColumns.Po: No such file or directory
Makefile:1052: ../../../pgadmin/pgscript/expressions/.deps/pgsDifferent.Po: No such file or directory
Makefile:1053: ../../../pgadmin/pgscript/expressions/.deps/pgsEqual.Po: No such file or directory
Makefile:1054: ../../../pgadmin/pgscript/expressions/.deps/pgsExecute.Po: No such file or directory
Makefile:1055: ../../../pgadmin/pgscript/expressions/.deps/pgsExpression.Po: No such file or directory
Makefile:1056: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDate.Po: No such file or directory
Makefile:1057: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDateTime.Po: No such file or directory
Makefile:1058: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDictionary.Po: No such file or directory
Makefile:1059: ../../../pgadmin/pgscript/expressions/.deps/pgsGenInt.Po: No such file or directory
Makefile:1060: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReal.Po: No such file or directory
Makefile:1061: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReference.Po: No such file or directory
Makefile:1062: ../../../pgadmin/pgscript/expressions/.deps/pgsGenRegex.Po: No such file or directory
Makefile:1063: ../../../pgadmin/pgscript/expressions/.deps/pgsGenString.Po: No such file or directory
Makefile:1064: ../../../pgadmin/pgscript/expressions/.deps/pgsGenTime.Po: No such file or directory
Makefile:1065: ../../../pgadmin/pgscript/expressions/.deps/pgsGreater.Po: No such file or directory
Makefile:1066: ../../../pgadmin/pgscript/expressions/.deps/pgsGreaterEqual.Po: No such file or directory
Makefile:1067: ../../../pgadmin/pgscript/expressions/.deps/pgsIdent.Po: No such file or directory
Makefile:1068: ../../../pgadmin/pgscript/expressions/.deps/pgsIdentRecord.Po: No such file or directory
Makefile:1069: ../../../pgadmin/pgscript/expressions/.deps/pgsLines.Po: No such file or directory
Makefile:1070: ../../../pgadmin/pgscript/expressions/.deps/pgsLower.Po: No such file or directory
Makefile:1071: ../../../pgadmin/pgscript/expressions/.deps/pgsLowerEqual.Po: No such file or directory
Makefile:1072: ../../../pgadmin/pgscript/expressions/.deps/pgsMinus.Po: No such file or directory
Makefile:1073: ../../../pgadmin/pgscript/expressions/.deps/pgsModulo.Po: No such file or directory
Makefile:1074: ../../../pgadmin/pgscript/expressions/.deps/pgsNegate.Po: No such file or directory
Makefile:1075: ../../../pgadmin/pgscript/expressions/.deps/pgsNot.Po: No such file or directory
Makefile:1076: ../../../pgadmin/pgscript/expressions/.deps/pgsOperation.Po: No such file or directory
Makefile:1077: ../../../pgadmin/pgscript/expressions/.deps/pgsOr.Po: No such file or directory
Makefile:1078: ../../../pgadmin/pgscript/expressions/.deps/pgsOver.Po: No such file or directory
Makefile:1079: ../../../pgadmin/pgscript/expressions/.deps/pgsParenthesis.Po: No such file or directory
Makefile:1080: ../../../pgadmin/pgscript/expressions/.deps/pgsPlus.Po: No such file or directory
Makefile:1081: ../../../pgadmin/pgscript/expressions/.deps/pgsRemoveLine.Po: No such file or directory
Makefile:1082: ../../../pgadmin/pgscript/expressions/.deps/pgsTimes.Po: No such file or directory
Makefile:1083: ../../../pgadmin/pgscript/expressions/.deps/pgsTrim.Po: No such file or directory
Makefile:1084: ../../../pgadmin/pgscript/generators/.deps/pgsDateGen.Po: No such file or directory
Makefile:1085: ../../../pgadmin/pgscript/generators/.deps/pgsDateTimeGen.Po: No such file or directory
Makefile:1086: ../../../pgadmin/pgscript/generators/.deps/pgsDictionaryGen.Po: No such file or directory
Makefile:1087: ../../../pgadmin/pgscript/generators/.deps/pgsIntegerGen.Po: No such file or directory
Makefile:1088: ../../../pgadmin/pgscript/generators/.deps/pgsNumberGen.Po: No such file or directory
Makefile:1089: ../../../pgadmin/pgscript/generators/.deps/pgsObjectGen.Po: No such file or directory
Makefile:1090: ../../../pgadmin/pgscript/generators/.deps/pgsRealGen.Po: No such file or directory
Makefile:1091: ../../../pgadmin/pgscript/generators/.deps/pgsReferenceGen.Po: No such file or directory
Makefile:1092: ../../../pgadmin/pgscript/generators/.deps/pgsRegexGen.Po: No such file or directory
Makefile:1093: ../../../pgadmin/pgscript/generators/.deps/pgsStringGen.Po: No such file or directory
Makefile:1094: ../../../pgadmin/pgscript/generators/.deps/pgsTimeGen.Po: No such file or directory
Makefile:1095: ../../../pgadmin/pgscript/objects/.deps/pgsGenerator.Po: No such file or directory
Makefile:1096: ../../../pgadmin/pgscript/objects/.deps/pgsNumber.Po: No such file or directory
Makefile:1097: ../../../pgadmin/pgscript/objects/.deps/pgsRecord.Po: No such file or directory
Makefile:1098: ../../../pgadmin/pgscript/objects/.deps/pgsString.Po: No such file or directory
Makefile:1099: ../../../pgadmin/pgscript/objects/.deps/pgsVariable.Po: No such file or directory
Makefile:1100: ../../../pgadmin/pgscript/statements/.deps/pgsAssertStmt.Po: No such file or directory
Makefile:1101: ../../../pgadmin/pgscript/statements/.deps/pgsBreakStmt.Po: No such file or directory
Makefile:1102: ../../../pgadmin/pgscript/statements/.deps/pgsContinueStmt.Po: No such file or directory
Makefile:1103: ../../../pgadmin/pgscript/statements/.deps/pgsDeclareRecordStmt.Po: No such file or directory
Makefile:1104: ../../../pgadmin/pgscript/statements/.deps/pgsExpressionStmt.Po: No such file or directory
Makefile:1105: ../../../pgadmin/pgscript/statements/.deps/pgsIfStmt.Po: No such file or directory
Makefile:1106: ../../../pgadmin/pgscript/statements/.deps/pgsPrintStmt.Po: No such file or directory
Makefile:1107: ../../../pgadmin/pgscript/statements/.deps/pgsProgram.Po: No such file or directory
Makefile:1108: ../../../pgadmin/pgscript/statements/.deps/pgsStmt.Po: No such file or directory
Makefile:1109: ../../../pgadmin/pgscript/statements/.deps/pgsStmtList.Po: No such file or directory
Makefile:1110: ../../../pgadmin/pgscript/statements/.deps/pgsWhileStmt.Po: No such file or directory
Makefile:1111: ../../../pgadmin/pgscript/utilities/.deps/pgsAlloc.Po: No such file or directory
Makefile:1112: ../../../pgadmin/pgscript/utilities/.deps/pgsContext.Po: No such file or directory
Makefile:1113: ../../../pgadmin/pgscript/utilities/.deps/pgsDriver.Po: No such file or directory
Makefile:1114: ../../../pgadmin/pgscript/utilities/.deps/pgsMapm.Po: No such file or directory
Makefile:1115: ../../../pgadmin/pgscript/utilities/.deps/pgsThread.Po: No such file or directory
Makefile:1116: ../../../pgadmin/pgscript/utilities/.deps/pgsUtilities.Po: No such file or directory
Makefile:1117: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm5sin.Po: No such file or directory
Makefile:1118: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_add.Po: No such file or directory
Makefile:1119: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_cpi.Po: No such file or directory
Makefile:1120: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_div.Po: No such file or directory
Makefile:1121: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_exp.Po: No such file or directory
Makefile:1122: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fam.Po: No such file or directory
Makefile:1123: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fft.Po: No such file or directory
Makefile:1124: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_flr.Po: No such file or directory
Makefile:1125: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fpf.Po: No such file or directory
Makefile:1126: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_gcd.Po: No such file or directory
Makefile:1127: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg2.Po: No such file or directory
Makefile:1128: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg3.Po: No such file or directory
Makefile:1129: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg4.Po: No such file or directory
Makefile:1130: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_log.Po: No such file or directory
Makefile:1131: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_mul.Po: No such file or directory
Makefile:1132: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_pow.Po: No such file or directory
Makefile:1133: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rcp.Po: No such file or directory
Makefile:1134: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rnd.Po: No such file or directory
Makefile:1135: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_set.Po: No such file or directory
Makefile:1136: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_sin.Po: No such file or directory
Makefile:1137: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasin.Po: No such file or directory
Makefile:1138: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasn0.Po: No such file or directory
Makefile:1139: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcbrt.Po: No such file or directory
Makefile:1140: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcnst.Po: No such file or directory
Makefile:1141: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfact.Po: No such file or directory
Makefile:1142: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfmul.Po: No such file or directory
Makefile:1143: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmgues.Po: No such file or directory
Makefile:1144: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhasn.Po: No such file or directory
Makefile:1145: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhsin.Po: No such file or directory
Makefile:1146: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmipwr.Po: No such file or directory
Makefile:1147: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmistr.Po: No such file or directory
Makefile:1148: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmpwr2.Po: No such file or directory
Makefile:1149: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmrsin.Po: No such file or directory
Makefile:1150: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmsqrt.Po: No such file or directory
Makefile:1151: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmstck.Po: No such file or directory
Makefile:1152: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutil.Po: No such file or directory
Makefile:1153: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl1.Po: No such file or directory
Makefile:1154: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl2.Po: No such file or directory
Makefile:1155: ../../../pgadmin/utils/.deps/misc.Po: No such file or directory
Makefile:1156: ../../../pgadmin/utils/.deps/sysLogger.Po: No such file or directory
make[3]: *** No rule to make target `../../../pgadmin/utils/.deps/sysLogger.Po'.  Stop.
make[2]: *** [distclean-recursive] Error 1
make[1]: *** [distclean-recursive] Error 1
make: *** [distclean-recursive] Error 1


On Wed, May 8, 2013 at 10:24 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Ashesh Vashi
Date:


On 9 May 2013 20:43, "Dave Page" <dpage@pgadmin.org> wrote:
>
> OK, I've pushed this as-is for now. We'll remove the pgscript CLI in a few days if noone exists.
>
> I had a couple of other thoughts whilst playing with VPATH builds - shouldn't the doc and png2c output (*.pngc) be redirected to $(top_builddir), or is there a reason we don't currently do that? Can you check that please?
Yeah - I tried that... and, I m aware of that.. But - forgot to mention that here.
As I could not give more time, I've fixed only upto this level, so that - nothing is broken..

Atleast - creation of the png2c binary & using it from the builddir has been taken care in my previous patch..

I'll spend some more time after few days....
I've something else with more priority in my plate. :(

Thanks,

Ashesh Vashi
>
> Thanks.
>
>
> On Thu, May 9, 2013 at 1:02 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>
>> On Thu, May 9, 2013 at 4:44 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi
>>>
>>>
>>>
>>> On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>>>
>>>> Hi Dave,
>>>>
>>>> I needed to modify the configuration at quite a lot places to make it work properly.
>>>> And, looks like the pgscript has not been compiled by anyone from long time and I can say that because, it has been horribly broken.
>>>> If we're going to support the stand-alone pgscript application, we will need to modify the code accordingly.
>>>> There are many changes done in the pgadmin3 code, which are shared by pgscript. And, we've not taken care about pgscript affected areas.
>>>
>>>
>>> Honestly, I don't think we need to keep that there. pgScript was originally written as a GSOC project by Mickael Deloison, and later added to pgAdmin as a second project (iirc, Magnus mentored). We included the command line interpretor just to give it a home, but as it hasn't been touched since it was added and isn't used for anything it should probably go.
>>>
>>> Any comments Magnus, Mickael?
>>>
>>> How much would that cleanup the patch you've submitted Ashesh? At a quick glance I guess at least the last hunk would be redundant.
>>
>> It has not touch the code base, shared by pgscript.
>> But - only changes made are to generate separate objects for both targets (pgscript & pgAdmin3).
>> pgscript is yet not be compiled using this patch. 
>>>>
>>>>
>>>> Also - the subdir-object changes (in configuration) had introduced the dependency on the actual objects for each target (Here - pgscript and pgadmin3), because the objects are getting generated in the respective directories instead of target directory. And, that dependency leads to this distclean issue, because the source/object files are shared between this two targets, and that too in different Makefiles, and one of the target cleans those objects, other can not find it.
>>>> It is not able to identify two targets using the same objects (and, enable the renaming of objects never comes into picture, not even if we set the _SHORTNAME property for those targets. reference: http://www.gnu.org/software/automake/manual/html_node/Renamed-Objects.html)
>>>> And, because of the dependency on actual objects, they're not regenerating the objects, which they must because they do have different CXXFLAGS.
>>>>
>>>> For the moment, I have fixed the 'make distclean' and cleaned up the configurations. Also - I've introduced the new object extension (.pgso) in pgscript Makefile.am to enable it to build separate object files from pgadmin3.
>>>>
>>>> Though - need some more work to resolve the pgscript compilation issue.
>>>> We can do it later (if nobody is using it at the moment.)
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>
>>>>
>>>> http://www.linkedin.com/in/asheshvashi
>>>>
>>>> On Wed, May 8, 2013 at 5:09 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>>>
>>>>> Thanks - patch applied.
>>>>>
>>>>> When testing this, I noticed that the distclean target seems to be broken now. Can you (or one of the team) please take a look? Thanks.
>>>>>
>>>>> viper:pgadmin3 dpage$ make distclean
>>>>> Making distclean in xtra/png2c
>>>>> make[1]: Nothing to be done for `distclean'.
>>>>> Making distclean in branding
>>>>> test -z "" || rm -f 
>>>>> test . = "." || test -z "" || rm -f 
>>>>> rm -f Makefile
>>>>> Making distclean in i18n
>>>>> test -z "" || rm -f 
>>>>> test . = "." || test -z "" || rm -f 
>>>>> rm -f Makefile
>>>>> Making distclean in plugins.d
>>>>> test -z "" || rm -f 
>>>>> test . = "." || test -z "" || rm -f 
>>>>> rm -f Makefile
>>>>> Making distclean in pgadmin
>>>>> test -z "pgadmin3" || rm -f pgadmin3
>>>>> rm -f include/images/*.pngc
>>>>> rm -f *.o
>>>>> rm -f *.tab.c
>>>>> test -z "" || rm -f 
>>>>> rm -f agent/*.o
>>>>> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
>>>>> test . = "." || test -z "" || rm -f 
>>>>> rm -f ctl/*.o
>>>>> rm -f agent/.deps/.dirstamp
>>>>> rm -f agent/.dirstamp
>>>>> rm -f ctl/.deps/.dirstamp
>>>>> rm -f db/*.o
>>>>> rm -f ctl/.dirstamp
>>>>> rm -f db/.deps/.dirstamp
>>>>> rm -f db/.dirstamp
>>>>> rm -f dd/dditems/figures/*.o
>>>>> rm -f dd/dditems/figures/.deps/.dirstamp
>>>>> rm -f dd/dditems/figures/.dirstamp
>>>>> rm -f dd/dditems/figures/xml/.deps/.dirstamp
>>>>> rm -f dd/dditems/figures/xml/*.o
>>>>> rm -f dd/dditems/figures/xml/.dirstamp
>>>>> rm -f dd/dditems/handles/.deps/.dirstamp
>>>>> rm -f dd/dditems/handles/*.o
>>>>> rm -f dd/dditems/handles/.dirstamp
>>>>> rm -f dd/dditems/locators/.deps/.dirstamp
>>>>> rm -f dd/dditems/locators/.dirstamp
>>>>> rm -f dd/dditems/locators/*.o
>>>>> rm -f dd/dditems/tools/.deps/.dirstamp
>>>>> rm -f dd/dditems/tools/.dirstamp
>>>>> rm -f dd/dditems/utilities/.deps/.dirstamp
>>>>> rm -f dd/dditems/tools/*.o
>>>>> rm -f dd/dditems/utilities/.dirstamp
>>>>> rm -f dd/ddmodel/.deps/.dirstamp
>>>>> rm -f dd/dditems/utilities/*.o
>>>>> rm -f dd/ddmodel/.dirstamp
>>>>> rm -f debugger/.deps/.dirstamp
>>>>> rm -f dd/ddmodel/*.o
>>>>> rm -f debugger/.dirstamp
>>>>> rm -f dlg/.deps/.dirstamp
>>>>> rm -f dlg/.dirstamp
>>>>> rm -f debugger/*.o
>>>>> rm -f frm/.deps/.dirstamp
>>>>> rm -f frm/.dirstamp
>>>>> rm -f dlg/*.o
>>>>> rm -f gqb/.deps/.dirstamp
>>>>> rm -f gqb/.dirstamp
>>>>> rm -f hotdraw/connectors/.deps/.dirstamp
>>>>> rm -f hotdraw/connectors/.dirstamp
>>>>> rm -f hotdraw/figures/.deps/.dirstamp
>>>>> rm -f hotdraw/figures/.dirstamp
>>>>> rm -f frm/*.o
>>>>> rm -f hotdraw/figures/defaultAttributes/.deps/.dirstamp
>>>>> rm -f hotdraw/figures/defaultAttributes/.dirstamp
>>>>> rm -f hotdraw/figures/xml/.deps/.dirstamp
>>>>> rm -f gqb/*.o
>>>>> rm -f hotdraw/figures/xml/.dirstamp
>>>>> rm -f hotdraw/handles/.deps/.dirstamp
>>>>> rm -f hotdraw/handles/.dirstamp
>>>>> rm -f hotdraw/connectors/*.o
>>>>> rm -f hotdraw/locators/.deps/.dirstamp
>>>>> rm -f hotdraw/locators/.dirstamp
>>>>> rm -f hotdraw/figures/*.o
>>>>> rm -f hotdraw/main/.deps/.dirstamp
>>>>> rm -f hotdraw/main/.dirstamp
>>>>> rm -f hotdraw/tools/.deps/.dirstamp
>>>>> rm -f hotdraw/figures/defaultAttributes/*.o
>>>>> rm -f hotdraw/tools/.dirstamp
>>>>> rm -f hotdraw/utilities/.deps/.dirstamp
>>>>> rm -f hotdraw/figures/xml/*.o
>>>>> rm -f hotdraw/utilities/.dirstamp
>>>>> rm -f libssh2/.deps/.dirstamp
>>>>> rm -f libssh2/.dirstamp
>>>>> rm -f hotdraw/handles/*.o
>>>>> rm -f ogl/.deps/.dirstamp
>>>>> rm -f ogl/.dirstamp
>>>>> rm -f hotdraw/locators/*.o
>>>>> rm -f pgscript/.deps/.dirstamp
>>>>> rm -f pgscript/.dirstamp
>>>>> rm -f hotdraw/main/*.o
>>>>> rm -f pgscript/exceptions/.deps/.dirstamp
>>>>> rm -f pgscript/exceptions/.dirstamp
>>>>> rm -f pgscript/expressions/.deps/.dirstamp
>>>>> rm -f hotdraw/tools/*.o
>>>>> rm -f pgscript/expressions/.dirstamp
>>>>> rm -f pgscript/generators/.deps/.dirstamp
>>>>> rm -f hotdraw/utilities/*.o
>>>>> rm -f pgscript/generators/.dirstamp
>>>>> rm -f pgscript/objects/.deps/.dirstamp
>>>>> rm -f pgscript/objects/.dirstamp
>>>>> rm -f libssh2/*.o
>>>>> rm -f pgscript/statements/.deps/.dirstamp
>>>>> rm -f pgscript/statements/.dirstamp
>>>>> rm -f pgscript/utilities/.deps/.dirstamp
>>>>> rm -f ogl/*.o
>>>>> rm -f pgscript/utilities/.dirstamp
>>>>> rm -f pgscript/utilities/m_apm/.deps/.dirstamp
>>>>> rm -f pgscript/utilities/m_apm/.dirstamp
>>>>> rm -f pgscript/*.o
>>>>> rm -f schema/.deps/.dirstamp
>>>>> rm -f schema/.dirstamp
>>>>> rm -f pgscript/exceptions/*.o
>>>>> rm -f slony/.deps/.dirstamp
>>>>> rm -f slony/.dirstamp
>>>>> rm -f ui/.deps/.dirstamp
>>>>> rm -f pgscript/expressions/*.o
>>>>> rm -f ui/.dirstamp
>>>>> rm -f utils/.deps/.dirstamp
>>>>> rm -f utils/.dirstamp
>>>>> rm -f pgscript/generators/*.o
>>>>> rm -f pgscript/objects/*.o
>>>>> rm -f pgscript/statements/*.o
>>>>> rm -f pgscript/utilities/*.o
>>>>> rm -f pgscript/utilities/m_apm/*.o
>>>>> rm -f schema/*.o
>>>>> rm -f slony/*.o
>>>>> rm -f ui/*.o
>>>>> rm -f utils/*.o
>>>>> rm -rf ./.deps agent/.deps ctl/.deps db/.deps dd/dditems/figures/.deps dd/dditems/figures/xml/.deps dd/dditems/handles/.deps dd/dditems/locators/.deps dd/dditems/tools/.deps dd/dditems/utilities/.deps dd/ddmodel/.deps debugger/.deps dlg/.deps frm/.deps gqb/.deps hotdraw/connectors/.deps hotdraw/figures/.deps hotdraw/figures/defaultAttributes/.deps hotdraw/figures/xml/.deps hotdraw/handles/.deps hotdraw/locators/.deps hotdraw/main/.deps hotdraw/tools/.deps hotdraw/utilities/.deps libssh2/.deps ogl/.deps pgscript/.deps pgscript/exceptions/.deps pgscript/expressions/.deps pgscript/generators/.deps pgscript/objects/.deps pgscript/statements/.deps pgscript/utilities/.deps pgscript/utilities/m_apm/.deps schema/.deps slony/.deps ui/.deps utils/.deps
>>>>> rm -f Makefile
>>>>> Making distclean in xtra
>>>>> Making distclean in png2c
>>>>> make[2]: Nothing to be done for `distclean'.
>>>>> Making distclean in pgscript
>>>>> Making distclean in lib
>>>>> Makefile:1032: ../../../pgadmin/db/.deps/keywords.Po: No such file or directory
>>>>> Makefile:1033: ../../../pgadmin/db/.deps/pgConn.Po: No such file or directory
>>>>> Makefile:1034: ../../../pgadmin/db/.deps/pgQueryThread.Po: No such file or directory
>>>>> Makefile:1035: ../../../pgadmin/db/.deps/pgSet.Po: No such file or directory
>>>>> Makefile:1036: ../../../pgadmin/pgscript/.deps/lex.pgs.Po: No such file or directory
>>>>> Makefile:1037: ../../../pgadmin/pgscript/.deps/parser.tab.Po: No such file or directory
>>>>> Makefile:1038: ../../../pgadmin/pgscript/.deps/pgsApplication.Po: No such file or directory
>>>>> Makefile:1039: ../../../pgadmin/pgscript/exceptions/.deps/pgsArithmeticException.Po: No such file or directory
>>>>> Makefile:1040: ../../../pgadmin/pgscript/exceptions/.deps/pgsAssertException.Po: No such file or directory
>>>>> Makefile:1041: ../../../pgadmin/pgscript/exceptions/.deps/pgsBreakException.Po: No such file or directory
>>>>> Makefile:1042: ../../../pgadmin/pgscript/exceptions/.deps/pgsCastException.Po: No such file or directory
>>>>> Makefile:1043: ../../../pgadmin/pgscript/exceptions/.deps/pgsContinueException.Po: No such file or directory
>>>>> Makefile:1044: ../../../pgadmin/pgscript/exceptions/.deps/pgsException.Po: No such file or directory
>>>>> Makefile:1045: ../../../pgadmin/pgscript/exceptions/.deps/pgsInterruptException.Po: No such file or directory
>>>>> Makefile:1046: ../../../pgadmin/pgscript/exceptions/.deps/pgsParameterException.Po: No such file or directory
>>>>> Makefile:1047: ../../../pgadmin/pgscript/expressions/.deps/pgsAnd.Po: No such file or directory
>>>>> Makefile:1048: ../../../pgadmin/pgscript/expressions/.deps/pgsAssign.Po: No such file or directory
>>>>> Makefile:1049: ../../../pgadmin/pgscript/expressions/.deps/pgsAssignToRecord.Po: No such file or directory
>>>>> Makefile:1050: ../../../pgadmin/pgscript/expressions/.deps/pgsCast.Po: No such file or directory
>>>>> Makefile:1051: ../../../pgadmin/pgscript/expressions/.deps/pgsColumns.Po: No such file or directory
>>>>> Makefile:1052: ../../../pgadmin/pgscript/expressions/.deps/pgsDifferent.Po: No such file or directory
>>>>> Makefile:1053: ../../../pgadmin/pgscript/expressions/.deps/pgsEqual.Po: No such file or directory
>>>>> Makefile:1054: ../../../pgadmin/pgscript/expressions/.deps/pgsExecute.Po: No such file or directory
>>>>> Makefile:1055: ../../../pgadmin/pgscript/expressions/.deps/pgsExpression.Po: No such file or directory
>>>>> Makefile:1056: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDate.Po: No such file or directory
>>>>> Makefile:1057: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDateTime.Po: No such file or directory
>>>>> Makefile:1058: ../../../pgadmin/pgscript/expressions/.deps/pgsGenDictionary.Po: No such file or directory
>>>>> Makefile:1059: ../../../pgadmin/pgscript/expressions/.deps/pgsGenInt.Po: No such file or directory
>>>>> Makefile:1060: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReal.Po: No such file or directory
>>>>> Makefile:1061: ../../../pgadmin/pgscript/expressions/.deps/pgsGenReference.Po: No such file or directory
>>>>> Makefile:1062: ../../../pgadmin/pgscript/expressions/.deps/pgsGenRegex.Po: No such file or directory
>>>>> Makefile:1063: ../../../pgadmin/pgscript/expressions/.deps/pgsGenString.Po: No such file or directory
>>>>> Makefile:1064: ../../../pgadmin/pgscript/expressions/.deps/pgsGenTime.Po: No such file or directory
>>>>> Makefile:1065: ../../../pgadmin/pgscript/expressions/.deps/pgsGreater.Po: No such file or directory
>>>>> Makefile:1066: ../../../pgadmin/pgscript/expressions/.deps/pgsGreaterEqual.Po: No such file or directory
>>>>> Makefile:1067: ../../../pgadmin/pgscript/expressions/.deps/pgsIdent.Po: No such file or directory
>>>>> Makefile:1068: ../../../pgadmin/pgscript/expressions/.deps/pgsIdentRecord.Po: No such file or directory
>>>>> Makefile:1069: ../../../pgadmin/pgscript/expressions/.deps/pgsLines.Po: No such file or directory
>>>>> Makefile:1070: ../../../pgadmin/pgscript/expressions/.deps/pgsLower.Po: No such file or directory
>>>>> Makefile:1071: ../../../pgadmin/pgscript/expressions/.deps/pgsLowerEqual.Po: No such file or directory
>>>>> Makefile:1072: ../../../pgadmin/pgscript/expressions/.deps/pgsMinus.Po: No such file or directory
>>>>> Makefile:1073: ../../../pgadmin/pgscript/expressions/.deps/pgsModulo.Po: No such file or directory
>>>>> Makefile:1074: ../../../pgadmin/pgscript/expressions/.deps/pgsNegate.Po: No such file or directory
>>>>> Makefile:1075: ../../../pgadmin/pgscript/expressions/.deps/pgsNot.Po: No such file or directory
>>>>> Makefile:1076: ../../../pgadmin/pgscript/expressions/.deps/pgsOperation.Po: No such file or directory
>>>>> Makefile:1077: ../../../pgadmin/pgscript/expressions/.deps/pgsOr.Po: No such file or directory
>>>>> Makefile:1078: ../../../pgadmin/pgscript/expressions/.deps/pgsOver.Po: No such file or directory
>>>>> Makefile:1079: ../../../pgadmin/pgscript/expressions/.deps/pgsParenthesis.Po: No such file or directory
>>>>> Makefile:1080: ../../../pgadmin/pgscript/expressions/.deps/pgsPlus.Po: No such file or directory
>>>>> Makefile:1081: ../../../pgadmin/pgscript/expressions/.deps/pgsRemoveLine.Po: No such file or directory
>>>>> Makefile:1082: ../../../pgadmin/pgscript/expressions/.deps/pgsTimes.Po: No such file or directory
>>>>> Makefile:1083: ../../../pgadmin/pgscript/expressions/.deps/pgsTrim.Po: No such file or directory
>>>>> Makefile:1084: ../../../pgadmin/pgscript/generators/.deps/pgsDateGen.Po: No such file or directory
>>>>> Makefile:1085: ../../../pgadmin/pgscript/generators/.deps/pgsDateTimeGen.Po: No such file or directory
>>>>> Makefile:1086: ../../../pgadmin/pgscript/generators/.deps/pgsDictionaryGen.Po: No such file or directory
>>>>> Makefile:1087: ../../../pgadmin/pgscript/generators/.deps/pgsIntegerGen.Po: No such file or directory
>>>>> Makefile:1088: ../../../pgadmin/pgscript/generators/.deps/pgsNumberGen.Po: No such file or directory
>>>>> Makefile:1089: ../../../pgadmin/pgscript/generators/.deps/pgsObjectGen.Po: No such file or directory
>>>>> Makefile:1090: ../../../pgadmin/pgscript/generators/.deps/pgsRealGen.Po: No such file or directory
>>>>> Makefile:1091: ../../../pgadmin/pgscript/generators/.deps/pgsReferenceGen.Po: No such file or directory
>>>>> Makefile:1092: ../../../pgadmin/pgscript/generators/.deps/pgsRegexGen.Po: No such file or directory
>>>>> Makefile:1093: ../../../pgadmin/pgscript/generators/.deps/pgsStringGen.Po: No such file or directory
>>>>> Makefile:1094: ../../../pgadmin/pgscript/generators/.deps/pgsTimeGen.Po: No such file or directory
>>>>> Makefile:1095: ../../../pgadmin/pgscript/objects/.deps/pgsGenerator.Po: No such file or directory
>>>>> Makefile:1096: ../../../pgadmin/pgscript/objects/.deps/pgsNumber.Po: No such file or directory
>>>>> Makefile:1097: ../../../pgadmin/pgscript/objects/.deps/pgsRecord.Po: No such file or directory
>>>>> Makefile:1098: ../../../pgadmin/pgscript/objects/.deps/pgsString.Po: No such file or directory
>>>>> Makefile:1099: ../../../pgadmin/pgscript/objects/.deps/pgsVariable.Po: No such file or directory
>>>>> Makefile:1100: ../../../pgadmin/pgscript/statements/.deps/pgsAssertStmt.Po: No such file or directory
>>>>> Makefile:1101: ../../../pgadmin/pgscript/statements/.deps/pgsBreakStmt.Po: No such file or directory
>>>>> Makefile:1102: ../../../pgadmin/pgscript/statements/.deps/pgsContinueStmt.Po: No such file or directory
>>>>> Makefile:1103: ../../../pgadmin/pgscript/statements/.deps/pgsDeclareRecordStmt.Po: No such file or directory
>>>>> Makefile:1104: ../../../pgadmin/pgscript/statements/.deps/pgsExpressionStmt.Po: No such file or directory
>>>>> Makefile:1105: ../../../pgadmin/pgscript/statements/.deps/pgsIfStmt.Po: No such file or directory
>>>>> Makefile:1106: ../../../pgadmin/pgscript/statements/.deps/pgsPrintStmt.Po: No such file or directory
>>>>> Makefile:1107: ../../../pgadmin/pgscript/statements/.deps/pgsProgram.Po: No such file or directory
>>>>> Makefile:1108: ../../../pgadmin/pgscript/statements/.deps/pgsStmt.Po: No such file or directory
>>>>> Makefile:1109: ../../../pgadmin/pgscript/statements/.deps/pgsStmtList.Po: No such file or directory
>>>>> Makefile:1110: ../../../pgadmin/pgscript/statements/.deps/pgsWhileStmt.Po: No such file or directory
>>>>> Makefile:1111: ../../../pgadmin/pgscript/utilities/.deps/pgsAlloc.Po: No such file or directory
>>>>> Makefile:1112: ../../../pgadmin/pgscript/utilities/.deps/pgsContext.Po: No such file or directory
>>>>> Makefile:1113: ../../../pgadmin/pgscript/utilities/.deps/pgsDriver.Po: No such file or directory
>>>>> Makefile:1114: ../../../pgadmin/pgscript/utilities/.deps/pgsMapm.Po: No such file or directory
>>>>> Makefile:1115: ../../../pgadmin/pgscript/utilities/.deps/pgsThread.Po: No such file or directory
>>>>> Makefile:1116: ../../../pgadmin/pgscript/utilities/.deps/pgsUtilities.Po: No such file or directory
>>>>> Makefile:1117: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm5sin.Po: No such file or directory
>>>>> Makefile:1118: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_add.Po: No such file or directory
>>>>> Makefile:1119: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_cpi.Po: No such file or directory
>>>>> Makefile:1120: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_div.Po: No such file or directory
>>>>> Makefile:1121: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_exp.Po: No such file or directory
>>>>> Makefile:1122: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fam.Po: No such file or directory
>>>>> Makefile:1123: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fft.Po: No such file or directory
>>>>> Makefile:1124: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_flr.Po: No such file or directory
>>>>> Makefile:1125: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_fpf.Po: No such file or directory
>>>>> Makefile:1126: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_gcd.Po: No such file or directory
>>>>> Makefile:1127: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg2.Po: No such file or directory
>>>>> Makefile:1128: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg3.Po: No such file or directory
>>>>> Makefile:1129: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_lg4.Po: No such file or directory
>>>>> Makefile:1130: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_log.Po: No such file or directory
>>>>> Makefile:1131: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_mul.Po: No such file or directory
>>>>> Makefile:1132: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_pow.Po: No such file or directory
>>>>> Makefile:1133: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rcp.Po: No such file or directory
>>>>> Makefile:1134: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_rnd.Po: No such file or directory
>>>>> Makefile:1135: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_set.Po: No such file or directory
>>>>> Makefile:1136: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapm_sin.Po: No such file or directory
>>>>> Makefile:1137: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasin.Po: No such file or directory
>>>>> Makefile:1138: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmasn0.Po: No such file or directory
>>>>> Makefile:1139: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcbrt.Po: No such file or directory
>>>>> Makefile:1140: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmcnst.Po: No such file or directory
>>>>> Makefile:1141: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfact.Po: No such file or directory
>>>>> Makefile:1142: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmfmul.Po: No such file or directory
>>>>> Makefile:1143: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmgues.Po: No such file or directory
>>>>> Makefile:1144: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhasn.Po: No such file or directory
>>>>> Makefile:1145: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmhsin.Po: No such file or directory
>>>>> Makefile:1146: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmipwr.Po: No such file or directory
>>>>> Makefile:1147: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmistr.Po: No such file or directory
>>>>> Makefile:1148: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmpwr2.Po: No such file or directory
>>>>> Makefile:1149: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmrsin.Po: No such file or directory
>>>>> Makefile:1150: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmsqrt.Po: No such file or directory
>>>>> Makefile:1151: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmstck.Po: No such file or directory
>>>>> Makefile:1152: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutil.Po: No such file or directory
>>>>> Makefile:1153: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl1.Po: No such file or directory
>>>>> Makefile:1154: ../../../pgadmin/pgscript/utilities/m_apm/.deps/mapmutl2.Po: No such file or directory
>>>>> Makefile:1155: ../../../pgadmin/utils/.deps/misc.Po: No such file or directory
>>>>> Makefile:1156: ../../../pgadmin/utils/.deps/sysLogger.Po: No such file or directory
>>>>> make[3]: *** No rule to make target `../../../pgadmin/utils/.deps/sysLogger.Po'.  Stop.
>>>>> make[2]: *** [distclean-recursive] Error 1
>>>>> make[1]: *** [distclean-recursive] Error 1
>>>>> make: *** [distclean-recursive] Error 1
>>>>>
>>>>>
>>>>> On Wed, May 8, 2013 at 10:24 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> When building the pgAdmin3 latest source using VPATH builds, it is not able to compile the pgAdmin3.
>>>>>> (Reference: http://www.gnu.org/software/automake/manual/html_node/VPATH-Builds.html)
>>>>>>
>>>>>> Please find the patch to resolve the issue.
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Thanks & Regards,
>>>>>>
>>>>>> Ashesh Vashi
>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>>
>>>>>>  
>>>>>>
>>>>>> http://www.linkedin.com/in/asheshvashi
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>>
>>
>> --
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>
>>  
>>
>> http://www.linkedin.com/in/asheshvashi
>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Dave Page
Date:
On Thu, May 9, 2013 at 7:34 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
>
> On 9 May 2013 20:43, "Dave Page" <dpage@pgadmin.org> wrote:
>>
>> OK, I've pushed this as-is for now. We'll remove the pgscript CLI in a few
>> days if noone exists.
>>
>> I had a couple of other thoughts whilst playing with VPATH builds -
>> shouldn't the doc and png2c output (*.pngc) be redirected to
>> $(top_builddir), or is there a reason we don't currently do that? Can you
>> check that please?
> Yeah - I tried that... and, I m aware of that.. But - forgot to mention that
> here.
> As I could not give more time, I've fixed only upto this level, so that -
> nothing is broken..
>
> Atleast - creation of the png2c binary & using it from the builddir has been
> taken care in my previous patch..
>
> I'll spend some more time after few days....
> I've something else with more priority in my plate. :(

Probably also my fault, so no problem :-). This is low priority.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Magnus Hagander
Date:
On Thu, May 9, 2013 at 1:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi


On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

I needed to modify the configuration at quite a lot places to make it work properly.
And, looks like the pgscript has not been compiled by anyone from long time and I can say that because, it has been horribly broken.
If we're going to support the stand-alone pgscript application, we will need to modify the code accordingly.
There are many changes done in the pgadmin3 code, which are shared by pgscript. And, we've not taken care about pgscript affected areas.

Honestly, I don't think we need to keep that there. pgScript was originally written as a GSOC project by Mickael Deloison, and later added to pgAdmin as a second project (iirc, Magnus mentored). We included the command line interpretor just to give it a home, but as it hasn't been touched since it was added and isn't used for anything it should probably go.

Any comments Magnus, Mickael?

Wel, keeping it anywhere *else* is just going to make the problem even worse. So the options are to either fix it, or to throw it out completely.

I'm not against throwing it out completely - as you say, nobody seems to have touched it in ages and ages. If we *do* want to keep it, we should make it part of the main build so that we detect breakage *right away* and not years later - much easier to fix that way.
 
-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Dave Page
Date:
On Mon, May 13, 2013 at 12:25 PM, Magnus Hagander <magnus@hagander.net> wrote:
> On Thu, May 9, 2013 at 1:14 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>>
>> On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi
>> <ashesh.vashi@enterprisedb.com> wrote:
>>>
>>> Hi Dave,
>>>
>>> I needed to modify the configuration at quite a lot places to make it
>>> work properly.
>>> And, looks like the pgscript has not been compiled by anyone from long
>>> time and I can say that because, it has been horribly broken.
>>> If we're going to support the stand-alone pgscript application, we will
>>> need to modify the code accordingly.
>>> There are many changes done in the pgadmin3 code, which are shared by
>>> pgscript. And, we've not taken care about pgscript affected areas.
>>
>>
>> Honestly, I don't think we need to keep that there. pgScript was
>> originally written as a GSOC project by Mickael Deloison, and later added to
>> pgAdmin as a second project (iirc, Magnus mentored). We included the command
>> line interpretor just to give it a home, but as it hasn't been touched since
>> it was added and isn't used for anything it should probably go.
>>
>> Any comments Magnus, Mickael?
>
>
> Wel, keeping it anywhere *else* is just going to make the problem even
> worse. So the options are to either fix it, or to throw it out completely.
>
> I'm not against throwing it out completely - as you say, nobody seems to
> have touched it in ages and ages. If we *do* want to keep it, we should make
> it part of the main build so that we detect breakage *right away* and not
> years later - much easier to fix that way.

Thanks. I'm pro-ditching it.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue)

From
Guillaume Lelarge
Date:
On Mon, 2013-05-13 at 13:04 +0100, Dave Page wrote:
> On Mon, May 13, 2013 at 12:25 PM, Magnus Hagander <magnus@hagander.net> wrote:
> > On Thu, May 9, 2013 at 1:14 PM, Dave Page <dpage@pgadmin.org> wrote:
> >>
> >> Hi
> >>
> >>
> >> On Thu, May 9, 2013 at 12:07 PM, Ashesh Vashi
> >> <ashesh.vashi@enterprisedb.com> wrote:
> >>>
> >>> Hi Dave,
> >>>
> >>> I needed to modify the configuration at quite a lot places to make it
> >>> work properly.
> >>> And, looks like the pgscript has not been compiled by anyone from long
> >>> time and I can say that because, it has been horribly broken.
> >>> If we're going to support the stand-alone pgscript application, we will
> >>> need to modify the code accordingly.
> >>> There are many changes done in the pgadmin3 code, which are shared by
> >>> pgscript. And, we've not taken care about pgscript affected areas.
> >>
> >>
> >> Honestly, I don't think we need to keep that there. pgScript was
> >> originally written as a GSOC project by Mickael Deloison, and later added to
> >> pgAdmin as a second project (iirc, Magnus mentored). We included the command
> >> line interpretor just to give it a home, but as it hasn't been touched since
> >> it was added and isn't used for anything it should probably go.
> >>
> >> Any comments Magnus, Mickael?
> >
> >
> > Wel, keeping it anywhere *else* is just going to make the problem even
> > worse. So the options are to either fix it, or to throw it out completely.
> >
> > I'm not against throwing it out completely - as you say, nobody seems to
> > have touched it in ages and ages. If we *do* want to keep it, we should make
> > it part of the main build so that we detect breakage *right away* and not
> > years later - much easier to fix that way.
>
> Thanks. I'm pro-ditching it.
>

FWIW, +1


--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com