Thread: pgAdmin III commit: Fix another issue related to wxWidgets 2.9

pgAdmin III commit: Fix another issue related to wxWidgets 2.9

From
Guillaume Lelarge
Date:
Fix another issue related to wxWidgets 2.9

When the wxPLURAL patch was applied, it didn't drop the arguments to the
Format function. It was accepted this way in 2.8, but 2.9 is stricter.

Per report from Colin Beckingham.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4e8c217f812a0ecc95a02db367d8af63f39073ad

Modified Files
--------------
pgadmin/ctl/ctlSQLBox.cpp    |    2 +-
pgadmin/db/pgQueryThread.cpp |    4 ++--
pgadmin/frm/frmEditGrid.cpp  |   20 ++++++++++----------
pgadmin/frm/frmExport.cpp    |    2 +-
pgadmin/frm/frmQuery.cpp     |   20 ++++++++++----------
pgadmin/slony/slNode.cpp     |    4 ++--
6 files changed, 26 insertions(+), 26 deletions(-)


Re: pgAdmin III commit: Fix another issue related to wxWidgets 2.9

From
Timon
Date:
this commit wrongly shows number of returned rows. the latest version
has this bug too
see attachment

2012/3/10 Guillaume Lelarge <guillaume@lelarge.info>:
> Fix another issue related to wxWidgets 2.9
>
> When the wxPLURAL patch was applied, it didn't drop the arguments to the
> Format function. It was accepted this way in 2.8, but 2.9 is stricter.
>
> Per report from Colin Beckingham.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4e8c217f812a0ecc95a02db367d8af63f39073ad
>
> Modified Files
> --------------
> pgadmin/ctl/ctlSQLBox.cpp    |    2 +-
> pgadmin/db/pgQueryThread.cpp |    4 ++--
> pgadmin/frm/frmEditGrid.cpp  |   20 ++++++++++----------
> pgadmin/frm/frmExport.cpp    |    2 +-
> pgadmin/frm/frmQuery.cpp     |   20 ++++++++++----------
> pgadmin/slony/slNode.cpp     |    4 ++--
> 6 files changed, 26 insertions(+), 26 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers



--
All bugs reserved

Attachment

Re: pgAdmin III commit: Fix another issue related to wxWidgets 2.9

From
Guillaume Lelarge
Date:
On Tue, 2012-03-13 at 16:13 +0500, Timon wrote:
> this commit wrongly shows number of returned rows. the latest version
> has this bug too
> see attachment
>

You're right. I reverted my old patch.


--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com