Thread: Option "Nulls First" in the ordering screen.

Option "Nulls First" in the ordering screen.

From
Vinicius Santos
Date:
Hello,

I implemented an option "Nulls First" in the ordering screen.
It's just a checkbox for versions >= 8.3 of PostgreSQL.

What do you think?

Re: Option "Nulls First" in the ordering screen.

From
Guillaume Lelarge
Date:
On Thu, 2011-10-27 at 08:43 -0200, Vinicius Santos wrote:
> Hello,
>
> I implemented an option "Nulls First" in the ordering screen.
> It's just a checkbox for versions >= 8.3 of PostgreSQL.
>
> What do you think?

Which ordering screen?


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


Re: Option "Nulls First" in the ordering screen.

From
Guillaume Lelarge
Date:
On Thu, 2011-10-27 at 17:21 -0200, Vinicius Santos wrote:
> >
> >
> > Which ordering screen?
> >
> >
> dlgEditGridOptions. Beside the button "wxID_REMOVE".

Nope, would be better if it was a radiobox below the column name.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


Re: Option "Nulls First" in the ordering screen.

From
Guillaume Lelarge
Date:
Don't forget the list!

On Thu, 2011-10-27 at 17:31 -0200, Vinicius Santos wrote:
> > Nope, would be better if it was a radiobox below the column name.
> >
> >
> Humm.
> I did not think at radiobox, because this feature is only available from
> 8.3.

And? I don't get your point here. The version it first appeared doesn't
affect the UI.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


Fwd: Option "Nulls First" in the ordering screen.

From
Vinicius Santos
Date:
I did not realize again ...


Nope, would be better if it was a radiobox below the column name.


Humm.
I did not think at radiobox, because this feature is only available from  8.3.


Re: Option "Nulls First" in the ordering screen.

From
Vinicius Santos
Date:
And? I don't get your point here. The version it first appeared doesn't
affect the UI.

Ok. But for versions < 8.3, I disable the radiobox, right?

Since the query:
"SELECT column FROM table ORDER BY column NULLS FIRST" would not work on these versions.

Re: Option "Nulls First" in the ordering screen.

From
Guillaume Lelarge
Date:
On Thu, 2011-10-27 at 18:47 -0200, Vinicius Santos wrote:
> >
> > Yes. Our UI guideline is to disable (and not hide) widgets when the
> > option is not available (whatever the reason).
> >
>
> Ok. Do you agree with implementation ?
>

I agree with the idea. I'll agree with the implementation once I'll read
the patch :)

> Can I submit the patch tomorrow?

Sure.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


Re: Option "Nulls First" in the ordering screen.

From
Guillaume Lelarge
Date:
On Thu, 2011-10-27 at 17:39 -0200, Vinicius Santos wrote:
> > And? I don't get your point here. The version it first appeared doesn't
> > affect the UI.
> >
>
> Ok. But for versions < 8.3, I disable the radiobox, right?
>

Yes. Our UI guideline is to disable (and not hide) widgets when the
option is not available (whatever the reason).

> Since the query:
> "SELECT column FROM table ORDER BY column NULLS FIRST" would not work on
> these versions.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


Re: Option "Nulls First" in the ordering screen.

From
Vinicius Santos
Date:
Yes. Our UI guideline is to disable (and not hide) widgets when the
option is not available (whatever the reason).

Ok. Do you agree with implementation ?

Can I submit the patch tomorrow?

Re: Option "Nulls First" in the ordering screen.

From
Vinicius Santos
Date:
Hello,

I implemented a function for the two buttons "Asc" and "Desc", so that the maintenance is easier.

Take a look and tell me what you think.

Thanks.
Attachment

Re: Option "Nulls First" in the ordering screen.

From
Guillaume Lelarge
Date:
On Tue, 2011-11-01 at 08:47 -0200, Vinicius Santos wrote:
> Hello,
>
> I implemented a function for the two buttons "Asc" and "Desc", so that
> the maintenance
> is easier.
>
> Take a look and tell me what you think.
>

Well, I don't like the UI. It takes too much space for only one
information. I would better like a combobox, with the two choices.

Moreover, it simply doesn't work on Linux. I've got an assertion failure
on OnPaint for the list. I actually don't understand why, but it works
without your patch, so I guess your patch is buggy here.

Something that would be interesting to add is a collation widget. Since
9.1, you can add a collation information to a sort. That would be worth
adding.

Anyway, please, fix the UI, try to fix the Linux bug if you can
(otherwise, I can do it), and add the collation stuff. Will be an
interesting patch to commit.

Thanks.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


Re: Option "Nulls First" in the ordering screen.

From
Vinicius Santos
Date:

Well, I don't like the UI. It takes too much space for only one
information. I would better like a combobox, with the two choices.

I thought so too. I agree with you.


Moreover, it simply doesn't work on Linux. I've got an assertion failure
on OnPaint for the list. I actually don't understand why, but it works
without your patch, so I guess your patch is buggy here.

I will test on Ubuntu.
 

Something that would be interesting to add is a collation widget. Since
9.1, you can add a collation information to a sort. That would be worth
adding.

Anyway, please, fix the UI, try to fix the Linux bug if you can
(otherwise, I can do it), and add the collation stuff. Will be an
interesting patch to commit.

Ok. I will try to fix the problem on Ubuntu.

About the collation, should be a combobox too.
As the screen "New database ...". What do you think?

Thanks.

Re: Option "Nulls First" in the ordering screen.

From
Guillaume Lelarge
Date:
On Tue, 2011-11-01 at 12:07 -0200, Vinicius Santos wrote:
> > Well, I don't like the UI. It takes too much space for only one
> > information. I would better like a combobox, with the two choices.
> >
>
> I thought so too. I agree with you.
>

OK.

>
> > Moreover, it simply doesn't work on Linux. I've got an assertion failure
> > on OnPaint for the list. I actually don't understand why, but it works
> > without your patch, so I guess your patch is buggy here.
> >
>
> I will test on Ubuntu.
>

Thanks.

> >
> > Something that would be interesting to add is a collation widget. Since
> > 9.1, you can add a collation information to a sort. That would be worth
> > adding.
> >
> > Anyway, please, fix the UI, try to fix the Linux bug if you can
> > (otherwise, I can do it), and add the collation stuff. Will be an
> > interesting patch to commit.
> >
>
> Ok. I will try to fix the problem on Ubuntu.
>
> About the collation, should be a combobox too.
> As the screen "New database ...". What do you think?
>

Yes, that would be great.

Thanks.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com