Thread: pgAdmin III commit: Support for security labels on global objects

pgAdmin III commit: Support for security labels on global objects

From
Guillaume Lelarge
Date:
Support for security labels on global objects

This is to support a 9.2 feature of PostgreSQL. It adds a new tab to
databases, roles, and tablespaces dialogs, that allows one to add security
label for each provider they want. I suppose most users will have only one
provider, but the patch supports multi providers.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=76b9514bf29ad3b8f5a23197155014147fb839ea

Modified Files
--------------
pgadmin/dlg/dlgDatabase.cpp         |   24 ++++++++++++++++++++++++
pgadmin/dlg/dlgRole.cpp             |   29 +++++++++++++++++++++++++----
pgadmin/dlg/dlgTablespace.cpp       |   31 ++++++++++++++++++++++++++-----
pgadmin/include/dlg/dlgDatabase.h   |    4 ++++
pgadmin/include/dlg/dlgRole.h       |    4 ++++
pgadmin/include/dlg/dlgTablespace.h |    4 ++++
pgadmin/schema/pgDatabase.cpp       |   30 ++++++++++++++++++++++++++++--
pgadmin/schema/pgRole.cpp           |   25 +++++++++++++++++++++++++
pgadmin/schema/pgTablespace.cpp     |   30 +++++++++++++++++++++++++++++-
9 files changed, 169 insertions(+), 12 deletions(-)


pgadmin crashes after createing second table.
steps to reproduce:
1) run pgadmin
2) create table (empty table t1, for example)
3) create one more table (empty table t2, etc...)
4) catch the crash

git bisect points to this commit

gcc-4.6.0-10.fc15.x86_64
postgresql 9.0.4


2011/7/25 Guillaume Lelarge <guillaume@lelarge.info>:
> Support for security labels on global objects
>
> This is to support a 9.2 feature of PostgreSQL. It adds a new tab to
> databases, roles, and tablespaces dialogs, that allows one to add security
> label for each provider they want. I suppose most users will have only one
> provider, but the patch supports multi providers.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=76b9514bf29ad3b8f5a23197155014147fb839ea
>
> Modified Files
> --------------
> pgadmin/dlg/dlgDatabase.cpp         |   24 ++++++++++++++++++++++++
> pgadmin/dlg/dlgRole.cpp             |   29 +++++++++++++++++++++++++----
> pgadmin/dlg/dlgTablespace.cpp       |   31 ++++++++++++++++++++++++++-----
> pgadmin/include/dlg/dlgDatabase.h   |    4 ++++
> pgadmin/include/dlg/dlgRole.h       |    4 ++++
> pgadmin/include/dlg/dlgTablespace.h |    4 ++++
> pgadmin/schema/pgDatabase.cpp       |   30 ++++++++++++++++++++++++++++--
> pgadmin/schema/pgRole.cpp           |   25 +++++++++++++++++++++++++
> pgadmin/schema/pgTablespace.cpp     |   30 +++++++++++++++++++++++++++++-
> 9 files changed, 169 insertions(+), 12 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
All bugs reserved

Re: pgAdmin III commit: Support for security labels on global objects

From
Guillaume Lelarge
Date:
On Tue, 2011-08-02 at 19:04 +0600, Timon wrote:
> pgadmin crashes after createing second table.
> steps to reproduce:
> 1) run pgadmin
> 2) create table (empty table t1, for example)
> 3) create one more table (empty table t2, etc...)
> 4) catch the crash
>
> git bisect points to this commit
>
> gcc-4.6.0-10.fc15.x86_64
> postgresql 9.0.4
>

Thanks, you're right. I pushed a fix for this.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com