Thread: Enabling/disabling triggers and rules

Enabling/disabling triggers and rules

From
Guillaume Lelarge
Date:
Hi,

Right now, the enabled/disabled state of a trigger and a rule is not
displayed in the SQL pane of the browser. I can understand we don't
display its state if the object is enabled, but shouldn't we display
that the object is disabled in the SQL pane if it is? Just like we show
a FK is invalid when it is.

Any opinions on that issue?

Oh, and do we consider this a bug (so to be fixed in 1.14), or a new
feature?


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


Re: Enabling/disabling triggers and rules

From
Dave Page
Date:
On Sat, Jul 9, 2011 at 10:12 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Hi,
>
> Right now, the enabled/disabled state of a trigger and a rule is not
> displayed in the SQL pane of the browser. I can understand we don't
> display its state if the object is enabled, but shouldn't we display
> that the object is disabled in the SQL pane if it is? Just like we show
> a FK is invalid when it is.
>
> Any opinions on that issue?

We should include the SQL to disable it, yes. That is required to
recreate the object to the same state.

> Oh, and do we consider this a bug (so to be fixed in 1.14), or a new
> feature?

I'd call that a bug.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Enabling/disabling triggers and rules

From
Guillaume Lelarge
Date:
On Sat, 2011-07-09 at 10:18 +0100, Dave Page wrote:
> On Sat, Jul 9, 2011 at 10:12 AM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
> > Hi,
> >
> > Right now, the enabled/disabled state of a trigger and a rule is not
> > displayed in the SQL pane of the browser. I can understand we don't
> > display its state if the object is enabled, but shouldn't we display
> > that the object is disabled in the SQL pane if it is? Just like we show
> > a FK is invalid when it is.
> >
> > Any opinions on that issue?
>
> We should include the SQL to disable it, yes. That is required to
> recreate the object to the same state.
>

Agreed.

> > Oh, and do we consider this a bug (so to be fixed in 1.14), or a new
> > feature?
>
> I'd call that a bug.
>

Fixed. In 1.14 and master.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com