Postgres Pro
Downloads
Home   >   mailing lists

Thread: Foreign Table without options

Foreign Table without options

From
Jasmin Dizdarevic
Date:
There is a Problem in "void pgForeignTable::iSetOptions(const wxString &tmpoptions)" when tmpoptions is empty (no options specified during creation of FT) we're running into an infinite loop.

I would like to provide a patch, but currently I've some troubles with my local branches ;)

Could somebody add 

if(tmpoptions == wxT(""))
return;

on top of the method.

Tested with 1.14 Beta 2

Fwd: Foreign Table without options

From
Jasmin Dizdarevic
Date:
here's the patch.

---------- Forwarded message ----------
From: Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com>
Date: 2011/6/16
Subject: Foreign Table without options
To: pgadmin-hackers@postgresql.org


There is a Problem in "void pgForeignTable::iSetOptions(const wxString &tmpoptions)" when tmpoptions is empty (no options specified during creation of FT) we're running into an infinite loop.

I would like to provide a patch, but currently I've some troubles with my local branches ;)

Could somebody add 

if(tmpoptions == wxT(""))
return;

on top of the method.

Tested with 1.14 Beta 2


Attachment

Re: Foreign Table without options

From
Guillaume Lelarge
Date:
On Thu, 2011-06-16 at 01:52 +0200, Jasmin Dizdarevic wrote:
> There is a Problem in "void pgForeignTable::iSetOptions(const wxString
> &tmpoptions)" when tmpoptions is empty (no options specified during
> creation of FT) we're running into an infinite loop.
> I would like to provide a patch, but currently I've some troubles with
> my local branches ;)
> Could somebody add
> if(tmpoptions == wxT(""))
> return;
> on top of the method.
>
>
> Tested with 1.14 Beta 2
>

Thanks, this bug is now fixed.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com