Thread: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Ashesh Vashi
Date:
Hi Dave,

For some reason, the wxCalendarBox control was not working on linux (i.e. Ubuntu).
I found that - wxWidgets has already provided a class for that. (wxDatePickerCtrl).

As per our conversation, I have modified the code to use the wxDatePickerCtrl instead of wxCalendarBox.
Please find the patch for the master branch.

I have made minimal changes to work this control as per our expectation.

I think - this is a bug, so we should apply this to REL-1_12 and REL-1_10 branches too...
If you want, I can generate the patches for them.

Please review this patch and give your comments.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi


Attachment

Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Jasmin Dizdarevic
Date:
Very sexy on Windows 7.

2011/5/27 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Hi Dave,

For some reason, the wxCalendarBox control was not working on linux (i.e. Ubuntu).
I found that - wxWidgets has already provided a class for that. (wxDatePickerCtrl).

As per our conversation, I have modified the code to use the wxDatePickerCtrl instead of wxCalendarBox.
Please find the patch for the master branch.

I have made minimal changes to work this control as per our expectation.

I think - this is a bug, so we should apply this to REL-1_12 and REL-1_10 branches too...
If you want, I can generate the patches for them.

Please review this patch and give your comments.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Guillaume Lelarge
Date:
Le 05/27/2011 11:17 PM, Ashesh Vashi a écrit :
> Hi Dave,
>
> For some reason, the wxCalendarBox control was not working on linux (i.e.
> Ubuntu).
> I found that - wxWidgets has already provided a class for that.
> (wxDatePickerCtrl).
>
> http://docs.wxwidgets.org/stable/wx_wxdatepickerctrl.html
>
> As per our conversation, I have modified the code to use the
> wxDatePickerCtrl instead of wxCalendarBox.
> Please find the patch for the master branch.
>
> I have made minimal changes to work this control as per our expectation.
>
> I think - this is a bug, so we should apply this to REL-1_12 and REL-1_10
> branches too...
> If you want, I can generate the patches for them.
>
> Please review this patch and give your comments.
>

I'm mostly working on Linux (Ubuntu) and I don't really see the
differences. I mean, yeah, they're not the same, but it didn't feel bad
on Linux before. What are you trying to fix?

BTW, we don't release bugfixes for 1.10.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Ashesh Vashi
Date:
On ubuntu 10.04 and some of the linux flavors, the wxCalendarBox is not at all usable.
Sometimes, it even does not render the calendar properly on clicking the pop up button, and sometimes, it does not allow to click on the calendar.

As per my conversation with Dave, he was able to reproduce the same.

Dave,
Can you please confirm this?

On Sat, May 28, 2011 at 6:01 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote:
Le 05/27/2011 11:17 PM, Ashesh Vashi a écrit :
> Hi Dave,
>
> For some reason, the wxCalendarBox control was not working on linux (i.e.
> Ubuntu).
> I found that - wxWidgets has already provided a class for that.
> (wxDatePickerCtrl).
>
> http://docs.wxwidgets.org/stable/wx_wxdatepickerctrl.html
>
> As per our conversation, I have modified the code to use the
> wxDatePickerCtrl instead of wxCalendarBox.
> Please find the patch for the master branch.
>
> I have made minimal changes to work this control as per our expectation.
>
> I think - this is a bug, so we should apply this to REL-1_12 and REL-1_10
> branches too...
> If you want, I can generate the patches for them.
>
> Please review this patch and give your comments.
>

I'm mostly working on Linux (Ubuntu) and I don't really see the
differences. I mean, yeah, they're not the same, but it didn't feel bad
on Linux before. What are you trying to fix?

BTW, we don't release bugfixes for 1.10.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi


Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Dave Page
Date:
On Saturday, May 28, 2011, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
> On ubuntu 10.04 and some of the linux flavors, the wxCalendarBox is not at all usable.Sometimes, it even does not
renderthe calendar properly on clicking the pop up button, and sometimes, it does not allow to click on the calendar. 
>
>
> As per my conversation with Dave, he was able to reproduce the same.
> Dave,Can you please confirm this?

Yeah, it's certainly broken. The popup sometimes can't get focus so
you can't select a date. I spent/wasted about 4 hours trying to figure
out why yesterday, and failed miserably.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Dave Page
Date:
Oh, and I'll review/commit this later...

On Saturday, May 28, 2011, Dave Page <dave.page@enterprisedb.com> wrote:
> On Saturday, May 28, 2011, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>> On ubuntu 10.04 and some of the linux flavors, the wxCalendarBox is not at all usable.Sometimes, it even does not
renderthe calendar properly on clicking the pop up button, and sometimes, it does not allow to click on the calendar. 
>>
>>
>> As per my conversation with Dave, he was able to reproduce the same.
>> Dave,Can you please confirm this?
>
> Yeah, it's certainly broken. The popup sometimes can't get focus so
> you can't select a date. I spent/wasted about 4 hours trying to figure
> out why yesterday, and failed miserably.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Guillaume Lelarge
Date:
On 05/28/2011 06:57 AM, Ashesh Vashi wrote:
> On ubuntu 10.04 and some of the linux flavors, the wxCalendarBox is not at
> all usable.
> Sometimes, it even does not render the calendar properly on clicking the pop
> up button, and sometimes, it does not allow to click on the calendar.
>
> As per my conversation with Dave, he was able to reproduce the same.
>
> Dave,
> Can you please confirm this?
>

Oh, I believe, no problem. I'm just wondering why I don't have the issue
on my (broken) Ubuntu 11.04... oh, you spoke about 10.04, that's
probably the reason why.

/me off to get some coffee :)


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Dave Page
Date:
Thanks Ashesh - applied to -HEAD. I i didn't bother with the
back-branches as the problem shows up so rarely.

On Sat, May 28, 2011 at 7:25 AM, Dave Page <dave.page@enterprisedb.com> wrote:
> Oh, and I'll review/commit this later...
>
> On Saturday, May 28, 2011, Dave Page <dave.page@enterprisedb.com> wrote:
>> On Saturday, May 28, 2011, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>> On ubuntu 10.04 and some of the linux flavors, the wxCalendarBox is not at all usable.Sometimes, it even does not
renderthe calendar properly on clicking the pop up button, and sometimes, it does not allow to click on the calendar. 
>>>
>>>
>>> As per my conversation with Dave, he was able to reproduce the same.
>>> Dave,Can you please confirm this?
>>
>> Yeah, it's certainly broken. The popup sometimes can't get focus so
>> you can't select a date. I spent/wasted about 4 hours trying to figure
>> out why yesterday, and failed miserably.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From
Ashesh Vashi
Date:


On Tue, May 31, 2011 at 3:22 PM, Dave Page <dave.page@enterprisedb.com> wrote:
Thanks Ashesh - applied to -HEAD. I i didn't bother with the
back-branches as the problem shows up so rarely.
Thanks.
Yeah - that's true.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: 
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

 

On Sat, May 28, 2011 at 7:25 AM, Dave Page <dave.page@enterprisedb.com> wrote:
> Oh, and I'll review/commit this later...
>
> On Saturday, May 28, 2011, Dave Page <dave.page@enterprisedb.com> wrote:
>> On Saturday, May 28, 2011, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>> On ubuntu 10.04 and some of the linux flavors, the wxCalendarBox is not at all usable.Sometimes, it even does not render the calendar properly on clicking the pop up button, and sometimes, it does not allow to click on the calendar.
>>>
>>>
>>> As per my conversation with Dave, he was able to reproduce the same.
>>> Dave,Can you please confirm this?
>>
>> Yeah, it's certainly broken. The popup sometimes can't get focus so
>> you can't select a date. I spent/wasted about 4 hours trying to figure
>> out why yesterday, and failed miserably.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company