Thread: pgAdmin III commit: Ask to reset connection in the query tool

pgAdmin III commit: Ask to reset connection in the query tool

From
Guillaume Lelarge
Date:
Ask to reset connection in the query tool

If a query fails because of a bad connection, the query tool will ask the user
if he wants an automatic reset. If yes, it'll try to reset the connection.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7cbb6b50b7a9524b6a19323fcee79be4af29a479

Modified Files
--------------
CHANGELOG                   |    1 +
pgadmin/db/pgConn.cpp       |    6 ++++++
pgadmin/frm/frmQuery.cpp    |   24 +++++++++++++++++++-----
pgadmin/include/db/pgConn.h |    2 ++
4 files changed, 28 insertions(+), 5 deletions(-)


hmm, seem that it asks about reconnection even when query has syntax error

from messages tab:
ERROR:  syntax error at or near "to"
СТРОКА 3:  substring(sender from 1 to 11),
                                   ^
********** Ошибка **********
ERROR: syntax error at or near "to"
SQL state: 42601
Символ: 52

2011/5/4 Guillaume Lelarge <guillaume@lelarge.info>
Ask to reset connection in the query tool

If a query fails because of a bad connection, the query tool will ask the user
if he wants an automatic reset. If yes, it'll try to reset the connection.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7cbb6b50b7a9524b6a19323fcee79be4af29a479

Modified Files
--------------
CHANGELOG                   |    1 +
pgadmin/db/pgConn.cpp       |    6 ++++++
pgadmin/frm/frmQuery.cpp    |   24 +++++++++++++++++++-----
pgadmin/include/db/pgConn.h |    2 ++
4 files changed, 28 insertions(+), 5 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers



--
All bugs reserved

Re: pgAdmin III commit: Ask to reset connection in the query tool

From
Guillaume Lelarge
Date:
On 05/04/2011 02:21 PM, Timon wrote:
> hmm, seem that it asks about reconnection even when query has syntax error
>
> from messages tab:
> ERROR:  syntax error at or near "to"
> СТРОКА 3:  substring(sender from 1 to 11),
>                                    ^
> ********** Ошибка **********
> ERROR: syntax error at or near "to"
> SQL state: 42601
> Символ: 52
>

Fixed. Even if I'm not really proud of the fix. Not sure I really want
to keep that patch.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com