Thread: Re: [pgadmin-support] Copy & paste - git
it was already discussed. I have same bug, but Guillaume Lelarge <guillaume@lelarge.info> unable to reproduce it. Using git bisect I found commit which broke this feature. This is http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c4a350002d8e7bdb77bf5d8eb1c5eb4efade6aff 2011/3/15 Claudio Freire <klaussfreire@gmail.com>: > Hey, I just did a git pull and built from source (on debian squeeze), > and I cannot copy & paste from the SQL results panel. > > Copy & paste there is pretty useful ;-) > > Any chance to get it back? > > -- > Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-support > -- All bugs reserved
Le 15/03/2011 07:52, Timon a écrit : > it was already discussed. I have same bug, but Guillaume Lelarge > <guillaume@lelarge.info> unable to reproduce it. > Using git bisect I found commit which broke this feature. This is > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c4a350002d8e7bdb77bf5d8eb1c5eb4efade6aff > > 2011/3/15 Claudio Freire <klaussfreire@gmail.com>: >> Hey, I just did a git pull and built from source (on debian squeeze), >> and I cannot copy & paste from the SQL results panel. >> >> Copy & paste there is pretty useful ;-) >> >> Any chance to get it back? >> Could you try this patch? -- Guillaume http://www.postgresql.fr http://dalibo.com
Attachment
---------- Forwarded message ---------- From: Timon <timosha@gmail.com> Date: 2011/3/15 Subject: Re: [pgadmin-support] Copy & paste - git To: Guillaume Lelarge <guillaume@lelarge.info> This patch didn't help :( Copy/paste works everywhere fine, but not with sqlResult control. Also when I move cursor to scratchPad after sqlQuery control, copy/paste works fine. But when I move cursor to scratchPad after sqlResult control, copy/past doesn't work in scratchPad control too. 2011/3/15 Guillaume Lelarge <guillaume@lelarge.info>: > Le 15/03/2011 07:52, Timon a écrit : >> it was already discussed. I have same bug, but Guillaume Lelarge >> <guillaume@lelarge.info> unable to reproduce it. >> Using git bisect I found commit which broke this feature. This is >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c4a350002d8e7bdb77bf5d8eb1c5eb4efade6aff >> >> 2011/3/15 Claudio Freire <klaussfreire@gmail.com>: >>> Hey, I just did a git pull and built from source (on debian squeeze), >>> and I cannot copy & paste from the SQL results panel. >>> >>> Copy & paste there is pretty useful ;-) >>> >>> Any chance to get it back? >>> > > Could you try this patch? > > > -- > Guillaume > http://www.postgresql.fr > http://dalibo.com > -- All bugs reserved -- All bugs reserved
Le 15/03/2011 15:34, Claudio Freire a écrit : > Now, this patch actually does work. > Indeed, it actually works. I'm doing a few changes and I'll commit it. Thanks a lot for working on this. > On Tue, Mar 15, 2011 at 11:15 AM, Claudio Freire <klaussfreire@gmail.com> wrote: >> On Tue, Mar 15, 2011 at 10:59 AM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >>> Of course, it can only work. This patch simply says: "hey, copy is >>> ALWAYS available". So, sure, it works. In a weird way, but it works :) >>> >>> But don't expect this patch to be commited. -- Guillaume http://www.postgresql.fr http://dalibo.com
Le 15/03/2011 10:28, Guillaume Lelarge a écrit : > Le 15/03/2011 07:52, Timon a écrit : >> it was already discussed. I have same bug, but Guillaume Lelarge >> <guillaume@lelarge.info> unable to reproduce it. >> Using git bisect I found commit which broke this feature. This is >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c4a350002d8e7bdb77bf5d8eb1c5eb4efade6aff >> >> 2011/3/15 Claudio Freire <klaussfreire@gmail.com>: >>> Hey, I just did a git pull and built from source (on debian squeeze), >>> and I cannot copy & paste from the SQL results panel. >>> >>> Copy & paste there is pretty useful ;-) >>> >>> Any chance to get it back? >>> > > Could you try this patch? > Timon tried it and it didn't work out. But he continued to work on it and finally sent me a patch that fixes the issue. So, big thank to him :) Patch will be commited in a few minutes. -- Guillaume http://www.postgresql.fr http://dalibo.com