Thread: pgAdmin III commit: Ensure the embedded version of OGL builds properly
Ensure the embedded version of OGL builds properly on Windows. While we're here, update the installer, and the wxWidgets build script. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bc38a18228e9717e7157eccb484adf506b5933bd Modified Files -------------- pgadmin/include/ogl/basic.h | 14 ++-- pgadmin/include/ogl/basicp.h | 20 +++--- pgadmin/include/ogl/bmpshape.h | 2 +- pgadmin/include/ogl/canvas.h | 6 +- pgadmin/include/ogl/composit.h | 8 +- pgadmin/include/ogl/constrnt.h | 4 +- pgadmin/include/ogl/divided.h | 2 +- pgadmin/include/ogl/drawn.h | 6 +- pgadmin/include/ogl/drawnp.h | 10 ++-- pgadmin/include/ogl/lines.h | 12 ++-- pgadmin/include/ogl/linesp.h | 8 +- pgadmin/include/ogl/mfutils.h | 4 +- pgadmin/include/ogl/misc.h | 26 ++++---- pgadmin/include/ogl/module.mk | 1 - pgadmin/include/ogl/ogl.h | 13 +--- pgadmin/include/ogl/ogldiag.h | 6 +- pgadmin/include/ogl/oglprec.h | 19 ------ pgadmin/include/precomp.h | 16 +++++ pgadmin/ogl/basic.cpp | 2 +- pgadmin/ogl/basic2.cpp | 2 +- pgadmin/ogl/bmpshape.cpp | 2 +- pgadmin/ogl/canvas.cpp | 2 +- pgadmin/ogl/composit.cpp | 2 +- pgadmin/ogl/constrnt.cpp | 2 +- pgadmin/ogl/divided.cpp | 2 +- pgadmin/ogl/drawn.cpp | 2 +- pgadmin/ogl/lines.cpp | 2 +- pgadmin/ogl/mfutils.cpp | 2 +- pgadmin/ogl/ogldiag.cpp | 2 +- pgadmin/ogl/oglmisc.cpp | 2 +- pgadmin/pgAdmin3.vcproj | 136 +++++++++++++++++++++++++++++++++++++++- pkg/win32/src/pgadmin3.wxs | 1 - xtra/wx-build/build-wxmsw.bat | 2 +- 33 files changed, 229 insertions(+), 111 deletions(-)
Re: pgAdmin III commit: Ensure the embedded version of OGL builds properly
From
Peter Geoghegan
Date:
This commit has eliminated the remaining OGL related warnings that I mentioned on the main phase 2 thread, that are described here: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39159. I now build pgAdmin warning free on g++ 4.5.1. I incorrectly assumed that attributes were consistent between declaration and definition, as they apparently were for the poster of that bug report. -- Regards, Peter Geoghegan
On Thu, Feb 17, 2011 at 2:57 AM, Peter Geoghegan <peter.geoghegan86@gmail.com> wrote: > This commit has eliminated the remaining OGL related warnings that I > mentioned on the main phase 2 thread, that are described here: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39159. > > I now build pgAdmin warning free on g++ 4.5.1. > > I incorrectly assumed that attributes were consistent between > declaration and definition, as they apparently were for the poster of > that bug report. Oh, cool - I hadn't even considered that as an issue on *nix. I had it in my head those macros only did anything on Windows. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company