Thread: pgAdmin III commit: The new version of astyle seems to want to tweak a
The new version of astyle seems to want to tweak a number of files. Now using Artistic Style 2.01. Branch ------ REL-1_12_0_PATCHES Details ------- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c42cacea8c014fb6d29c45d9d7e8ef7ce2114545 Modified Files -------------- pgadmin/ctl/ctlDefaultSecurityPanel.cpp | 40 +++++++++++----------- pgadmin/ctl/ctlSecurityPanel.cpp | 44 ++++++++++++------------ pgadmin/db/pgConn.cpp | 2 +- pgadmin/dlg/dlgClasses.cpp | 2 +- pgadmin/frm/frmEditGrid.cpp | 20 ++++++------ pgadmin/frm/frmReport.cpp | 34 +++++++++--------- pgadmin/frm/frmStatus.cpp | 6 ++-- pgadmin/include/frm/frmReport.h | 2 +- pgadmin/include/gqb/gqbArrayCollection.h | 2 +- pgadmin/include/pgAdmin3.h | 4 +- pgadmin/include/pgscript/FlexLexer.h | 2 +- pgadmin/pgAdmin3.cpp | 2 +- pgadmin/pgscript/utilities/m_apm/mapm_fft.cpp | 10 +++--- pgadmin/pgscript/utilities/m_apm/mapm_set.cpp | 2 +- pgadmin/pgscript/utilities/m_apm/mapmfact.cpp | 4 +- pgadmin/pgscript/utilities/m_apm/mapmfmul.cpp | 16 ++++---- pgadmin/pgscript/utilities/m_apm/mapmutil.cpp | 2 +- pgadmin/schema/pgFunction.cpp | 2 +- pgadmin/schema/pgObject.cpp | 24 +++++++------- pgadmin/slony/dlgRepCluster.cpp | 6 ++-- pgadmin/utils/md5.cpp | 14 ++++---- pgadmin/utils/sysProcess.cpp | 2 +- pgadmin/utils/utffile.cpp | 2 +- 23 files changed, 122 insertions(+), 122 deletions(-)
Re: pgAdmin III commit: The new version of astyle seems to want to tweak a
From
Magnus Hagander
Date:
On Tue, Jan 18, 2011 at 18:53, Dave Page <dpage@pgadmin.org> wrote: > The new version of astyle seems to want to tweak a number of files. > Now using Artistic Style 2.01. Does *any* platform actually ship with this? Since they don't seem to ship any packages of their own - and I can't find it on debian *or* ubuntu, including no backports or the experimental and beta versions. Just for the future - I think it would be a good idea to actually pitch a change like this before making it. (for now I'll just stick to the "we're going to run it later anyway" approach until I can get around to installing a separate version for pgadmin) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
On Tue, Jan 18, 2011 at 7:19 PM, Magnus Hagander <magnus@hagander.net> wrote: > On Tue, Jan 18, 2011 at 18:53, Dave Page <dpage@pgadmin.org> wrote: >> The new version of astyle seems to want to tweak a number of files. >> Now using Artistic Style 2.01. > > Does *any* platform actually ship with this? Since they don't seem to > ship any packages of their own - and I can't find it on debian *or* > ubuntu, including no backports or the experimental and beta versions. It's the current on MacPorts. No idea about Linux as I don't develop on it. > Just for the future - I think it would be a good idea to actually > pitch a change like this before making it. > > (for now I'll just stick to the "we're going to run it later anyway" > approach until I can get around to installing a separate version for > pgadmin) For the 3 commits you make every year? :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: pgAdmin III commit: The new version of astyle seems to want to tweak a
From
Magnus Hagander
Date:
On Tue, Jan 18, 2011 at 20:25, Dave Page <dpage@pgadmin.org> wrote: > On Tue, Jan 18, 2011 at 7:19 PM, Magnus Hagander <magnus@hagander.net> wrote: >> On Tue, Jan 18, 2011 at 18:53, Dave Page <dpage@pgadmin.org> wrote: >>> The new version of astyle seems to want to tweak a number of files. >>> Now using Artistic Style 2.01. >> >> Does *any* platform actually ship with this? Since they don't seem to >> ship any packages of their own - and I can't find it on debian *or* >> ubuntu, including no backports or the experimental and beta versions. > > It's the current on MacPorts. No idea about Linux as I don't develop on it. Oh really? wow :-) >> Just for the future - I think it would be a good idea to actually >> pitch a change like this before making it. >> >> (for now I'll just stick to the "we're going to run it later anyway" >> approach until I can get around to installing a separate version for >> pgadmin) > > For the 3 commits you make every year? :-) Hey, I had *10* commits last year! :P But yes, that's why it's fine as long as it's available for those of you who do more commits. Most important of all are Guillaume, of course. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
On Tue, Jan 18, 2011 at 7:29 PM, Magnus Hagander <magnus@hagander.net> wrote: > On Tue, Jan 18, 2011 at 20:25, Dave Page <dpage@pgadmin.org> wrote: >> On Tue, Jan 18, 2011 at 7:19 PM, Magnus Hagander <magnus@hagander.net> wrote: >>> On Tue, Jan 18, 2011 at 18:53, Dave Page <dpage@pgadmin.org> wrote: >>>> The new version of astyle seems to want to tweak a number of files. >>>> Now using Artistic Style 2.01. >>> >>> Does *any* platform actually ship with this? Since they don't seem to >>> ship any packages of their own - and I can't find it on debian *or* >>> ubuntu, including no backports or the experimental and beta versions. >> >> It's the current on MacPorts. No idea about Linux as I don't develop on it. > > Oh really? wow :-) It's almost 2 months old now, so it's not exactly new. A quick search of the Fedora package database shows it was added there for f13 and f14 on the 1st December as well. Guess you need to get a proper OS... :-p -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: pgAdmin III commit: The new version of astyle seems to want to tweak a
From
Guillaume Lelarge
Date:
Le 18/01/2011 20:40, Dave Page a écrit : > On Tue, Jan 18, 2011 at 7:29 PM, Magnus Hagander <magnus@hagander.net> wrote: >> On Tue, Jan 18, 2011 at 20:25, Dave Page <dpage@pgadmin.org> wrote: >>> On Tue, Jan 18, 2011 at 7:19 PM, Magnus Hagander <magnus@hagander.net> wrote: >>>> On Tue, Jan 18, 2011 at 18:53, Dave Page <dpage@pgadmin.org> wrote: >>>>> The new version of astyle seems to want to tweak a number of files. >>>>> Now using Artistic Style 2.01. >>>> >>>> Does *any* platform actually ship with this? Since they don't seem to >>>> ship any packages of their own - and I can't find it on debian *or* >>>> ubuntu, including no backports or the experimental and beta versions. >>> >>> It's the current on MacPorts. No idea about Linux as I don't develop on it. >> >> Oh really? wow :-) > > It's almost 2 months old now, so it's not exactly new. A quick search > of the Fedora package database shows it was added there for f13 and > f14 on the 1st December as well. > > Guess you need to get a proper OS... :-p > So do I :) I have 1.24 of astyle. Ubuntu 10.10 has this one, and Ubuntu 11.04 will have it too. Not sure I'll stay on Ubuntu actually, but anyway, it sucks. ArchLinux has 2.01. Well, I'll just have to compile it myself. Shouldn't be too hard. -- Guillaume http://www.postgresql.fr http://dalibo.com
On Tue, Jan 18, 2011 at 8:15 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 18/01/2011 20:40, Dave Page a écrit : >> On Tue, Jan 18, 2011 at 7:29 PM, Magnus Hagander <magnus@hagander.net> wrote: >>> On Tue, Jan 18, 2011 at 20:25, Dave Page <dpage@pgadmin.org> wrote: >>>> On Tue, Jan 18, 2011 at 7:19 PM, Magnus Hagander <magnus@hagander.net> wrote: >>>>> On Tue, Jan 18, 2011 at 18:53, Dave Page <dpage@pgadmin.org> wrote: >>>>>> The new version of astyle seems to want to tweak a number of files. >>>>>> Now using Artistic Style 2.01. >>>>> >>>>> Does *any* platform actually ship with this? Since they don't seem to >>>>> ship any packages of their own - and I can't find it on debian *or* >>>>> ubuntu, including no backports or the experimental and beta versions. >>>> >>>> It's the current on MacPorts. No idea about Linux as I don't develop on it. >>> >>> Oh really? wow :-) >> >> It's almost 2 months old now, so it's not exactly new. A quick search >> of the Fedora package database shows it was added there for f13 and >> f14 on the 1st December as well. >> >> Guess you need to get a proper OS... :-p >> > > So do I :) > > I have 1.24 of astyle. Ubuntu 10.10 has this one, and Ubuntu 11.04 will > have it too. Not sure I'll stay on Ubuntu actually, but anyway, it > sucks. ArchLinux has 2.01. > > Well, I'll just have to compile it myself. Shouldn't be too hard. Sorry :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Wed, Jan 19, 2011 at 1:45 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote:
Le 18/01/2011 20:40, Dave Page a écrit :> On Tue, Jan 18, 2011 at 7:29 PM, Magnus Hagander <magnus@hagander.net> wrote:So do I :)
>> On Tue, Jan 18, 2011 at 20:25, Dave Page <dpage@pgadmin.org> wrote:
>>> On Tue, Jan 18, 2011 at 7:19 PM, Magnus Hagander <magnus@hagander.net> wrote:
>>>> On Tue, Jan 18, 2011 at 18:53, Dave Page <dpage@pgadmin.org> wrote:
>>>>> The new version of astyle seems to want to tweak a number of files.
>>>>> Now using Artistic Style 2.01.
>>>>
>>>> Does *any* platform actually ship with this? Since they don't seem to
>>>> ship any packages of their own - and I can't find it on debian *or*
>>>> ubuntu, including no backports or the experimental and beta versions.
>>>
>>> It's the current on MacPorts. No idea about Linux as I don't develop on it.
>>
>> Oh really? wow :-)
>
> It's almost 2 months old now, so it's not exactly new. A quick search
> of the Fedora package database shows it was added there for f13 and
> f14 on the 1st December as well.
>
> Guess you need to get a proper OS... :-p
>
I have 1.24 of astyle. Ubuntu 10.10 has this one, and Ubuntu 11.04 will
have it too. Not sure I'll stay on Ubuntu actually, but anyway, it
sucks. ArchLinux has 2.01.
Well, I'll just have to compile it myself. Shouldn't be too hard.
Not too hard.
I use Ubuntu most of the time.
So, I had to compile it from the source.
--
Ashesh
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: pgAdmin III commit: The new version of astyle seems to want to tweak a
From
Guillaume Lelarge
Date:
Le 18/01/2011 21:29, Dave Page a écrit : > On Tue, Jan 18, 2011 at 8:15 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Le 18/01/2011 20:40, Dave Page a écrit : >>> On Tue, Jan 18, 2011 at 7:29 PM, Magnus Hagander <magnus@hagander.net> wrote: >>>> On Tue, Jan 18, 2011 at 20:25, Dave Page <dpage@pgadmin.org> wrote: >>>>> On Tue, Jan 18, 2011 at 7:19 PM, Magnus Hagander <magnus@hagander.net> wrote: >>>>>> On Tue, Jan 18, 2011 at 18:53, Dave Page <dpage@pgadmin.org> wrote: >>>>>>> The new version of astyle seems to want to tweak a number of files. >>>>>>> Now using Artistic Style 2.01. >>>>>> >>>>>> Does *any* platform actually ship with this? Since they don't seem to >>>>>> ship any packages of their own - and I can't find it on debian *or* >>>>>> ubuntu, including no backports or the experimental and beta versions. >>>>> >>>>> It's the current on MacPorts. No idea about Linux as I don't develop on it. >>>> >>>> Oh really? wow :-) >>> >>> It's almost 2 months old now, so it's not exactly new. A quick search >>> of the Fedora package database shows it was added there for f13 and >>> f14 on the 1st December as well. >>> >>> Guess you need to get a proper OS... :-p >>> >> >> So do I :) >> >> I have 1.24 of astyle. Ubuntu 10.10 has this one, and Ubuntu 11.04 will >> have it too. Not sure I'll stay on Ubuntu actually, but anyway, it >> sucks. ArchLinux has 2.01. >> >> Well, I'll just have to compile it myself. Shouldn't be too hard. > > Sorry :-) > Don't worry, it's already done :) -- Guillaume http://www.postgresql.fr http://dalibo.com