Thread: New options dialog

New options dialog

From

Guillaume Lelarge

Date:

09 January 2011, 22:26:31

Hi,

At pgday.eu 2010, Dave and I discussed about the options dialog. We
would like to make it look like the Visual Studio options dialog.
Something like this one:

  http://www.timvw.be/wp-content/images/msbuildverbosity.gif

So, tonight, I've been thinking about it and how to use the treeview,
and here is what I propose:

General
  Help path
        (PG help path, EDB help path, GP help path, Slony help path)
  Binaries path
        (PG bin path, EDB bin path, GP bin path, Slony bin path,
         Ignore server/utility version mismatches)
  Miscellanous
        (System schemas)
Browser
  Display
        (list of objects, Default button)
  Properties
    Table
        (Count rows if estimated less than)
  Miscellanous
        (Font, Confirm object deletion, Show system objects in the
         treeview, Show users for privileges, Show object properties on
         double click in the treeview)
Query tool
  Query editor
        (Font, Indent characters, Use spaces instead of tabs, Copy SQL
         from main window to query tool)
  Results grid
        (Result copy quoting, Result copy quote character, Result copy
         field seperator, Show NULL values as <NULL>)
  Query file
        (Read and write Unicode UTF-8 files, Write BOM for UTF files,
         Do not prompt for unsaved files on exit)
  Favourites
        (File path)
  Macros
        (File path)
  History file
        (File path, Maximum queries to store, Maximum size of a stored
         query)
pgAgent
        (Maximum rows to retrieve)
Colours
  Foreground/Background
  Caret
  Syntax highlighting
  Status Window
Miscellanous
  Guru hints
        (Do not show gutu hints; Reset guru hints)
  Logging
        (Logfile, Log level)

Comments?

BTW, does anyone know what "max characters per column" is supposed to
do? AFAICT, it's not used in the current code.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Re: New options dialog

From

Dave Page

Date:

10 January 2011, 08:40:20

Hi

On Sun, Jan 9, 2011 at 11:26 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Hi,
>
> At pgday.eu 2010, Dave and I discussed about the options dialog. We
> would like to make it look like the Visual Studio options dialog.
> Something like this one:
>
>  http://www.timvw.be/wp-content/images/msbuildverbosity.gif
>
> So, tonight, I've been thinking about it and how to use the treeview,
> and here is what I propose:
>
> General
>  Help path
>        (PG help path, EDB help path, GP help path, Slony help path)
>  Binaries path
>        (PG bin path, EDB bin path, GP bin path, Slony bin path,
>         Ignore server/utility version mismatches)
>  Miscellanous
>        (System schemas)
> Browser
>  Display
>        (list of objects, Default button)
>  Properties
>    Table
>        (Count rows if estimated less than)
>  Miscellanous
>        (Font, Confirm object deletion, Show system objects in the
>         treeview, Show users for privileges, Show object properties on
>         double click in the treeview)
> Query tool
>  Query editor
>        (Font, Indent characters, Use spaces instead of tabs, Copy SQL
>         from main window to query tool)
>  Results grid
>        (Result copy quoting, Result copy quote character, Result copy
>         field seperator, Show NULL values as <NULL>)
>  Query file
>        (Read and write Unicode UTF-8 files, Write BOM for UTF files,
>         Do not prompt for unsaved files on exit)
>  Favourites
>        (File path)
>  Macros
>        (File path)
>
>  History file
>        (File path, Maximum queries to store, Maximum size of a stored
>         query)
> pgAgent
>        (Maximum rows to retrieve)
> Colours
>  Foreground/Background
>  Caret
>  Syntax highlighting
>  Status Window
> Miscellanous
>  Guru hints
>        (Do not show gutu hints; Reset guru hints)
>  Logging
>        (Logfile, Log level)
>
> Comments?

Seems OK.

> BTW, does anyone know what "max characters per column" is supposed to
> do? AFAICT, it's not used in the current code.

It's supposed to be the maximum length of a value that we'll try to
display in the Query Tool results or the Table Editor. If a value is
longer, it's supposed to not display it (and probably display some
non-editable message instead).

I suppose "Max characters per cell" would be better.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: New options dialog

From

Jasmin Dizdarevic

Date:

10 January 2011, 09:35:32

Such setting dialogs are state of the art now and it's a good investment in future, when more and more settings are required.

2011/1/10 Dave Page <dpage@pgadmin.org>

Hi

On Sun, Jan 9, 2011 at 11:26 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Hi,
>
> At pgday.eu 2010, Dave and I discussed about the options dialog. We
> would like to make it look like the Visual Studio options dialog.
> Something like this one:
>
> http://www.timvw.be/wp-content/images/msbuildverbosity.gif
>
> So, tonight, I've been thinking about it and how to use the treeview,
> and here is what I propose:
>
> General
> Help path
> (PG help path, EDB help path, GP help path, Slony help path)
> Binaries path
> (PG bin path, EDB bin path, GP bin path, Slony bin path,
> Ignore server/utility version mismatches)
> Miscellanous
> (System schemas)
> Browser
> Display
> (list of objects, Default button)
> Properties
> Table
> (Count rows if estimated less than)
> Miscellanous
> (Font, Confirm object deletion, Show system objects in the
> treeview, Show users for privileges, Show object properties on
> double click in the treeview)
> Query tool
> Query editor
> (Font, Indent characters, Use spaces instead of tabs, Copy SQL
> from main window to query tool)
> Results grid
> (Result copy quoting, Result copy quote character, Result copy
> field seperator, Show NULL values as <NULL>)
> Query file
> (Read and write Unicode UTF-8 files, Write BOM for UTF files,
> Do not prompt for unsaved files on exit)
> Favourites
> (File path)
> Macros
> (File path)
>
> History file
> (File path, Maximum queries to store, Maximum size of a stored
> query)
> pgAgent
> (Maximum rows to retrieve)
> Colours
> Foreground/Background
> Caret
> Syntax highlighting
> Status Window
> Miscellanous
> Guru hints
> (Do not show gutu hints; Reset guru hints)
> Logging
> (Logfile, Log level)
>
> Comments?

Seems OK.

> BTW, does anyone know what "max characters per column" is supposed to
> do? AFAICT, it's not used in the current code.

It's supposed to be the maximum length of a value that we'll try to
display in the Query Tool results or the Table Editor. If a value is
longer, it's supposed to not display it (and probably display some
non-editable message instead).

I suppose "Max characters per cell" would be better.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: New options dialog

From

Guillaume Lelarge

Date:

15 August 2011, 09:32:06

On Mon, 2011-01-10 at 09:40 +0000, Dave Page wrote:
> Hi
>
> On Sun, Jan 9, 2011 at 11:26 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
> > Hi,
> >
> > At pgday.eu 2010, Dave and I discussed about the options dialog. We
> > would like to make it look like the Visual Studio options dialog.
> > Something like this one:
> >
> >  http://www.timvw.be/wp-content/images/msbuildverbosity.gif
> >
> > So, tonight, I've been thinking about it and how to use the treeview,
> > and here is what I propose:
> >
> > General
> >  Help path
> >        (PG help path, EDB help path, GP help path, Slony help path)
> >  Binaries path
> >        (PG bin path, EDB bin path, GP bin path, Slony bin path,
> >         Ignore server/utility version mismatches)
> >  Miscellanous
> >        (System schemas)
> > Browser
> >  Display
> >        (list of objects, Default button)
> >  Properties
> >    Table
> >        (Count rows if estimated less than)
> >  Miscellanous
> >        (Font, Confirm object deletion, Show system objects in the
> >         treeview, Show users for privileges, Show object properties on
> >         double click in the treeview)
> > Query tool
> >  Query editor
> >        (Font, Indent characters, Use spaces instead of tabs, Copy SQL
> >         from main window to query tool)
> >  Results grid
> >        (Result copy quoting, Result copy quote character, Result copy
> >         field seperator, Show NULL values as <NULL>)
> >  Query file
> >        (Read and write Unicode UTF-8 files, Write BOM for UTF files,
> >         Do not prompt for unsaved files on exit)
> >  Favourites
> >        (File path)
> >  Macros
> >        (File path)
> >
> >  History file
> >        (File path, Maximum queries to store, Maximum size of a stored
> >         query)
> > pgAgent
> >        (Maximum rows to retrieve)
> > Colours
> >  Foreground/Background
> >  Caret
> >  Syntax highlighting
> >  Status Window
> > Miscellanous
> >  Guru hints
> >        (Do not show gutu hints; Reset guru hints)
> >  Logging
> >        (Logfile, Log level)
> >
> > Comments?
>
> Seems OK.
>

Here it is. Patch attached, and a few screenshots.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com

Attachment

Re: New options dialog

From

Thom Brown

Date:

15 August 2011, 09:40:42

On 15 August 2011 10:29, Guillaume Lelarge <guillaume@lelarge.info> wrote:

On Mon, 2011-01-10 at 09:40 +0000, Dave Page wrote:
> Hi
>
> On Sun, Jan 9, 2011 at 11:26 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
> > Hi,
> >
> > At pgday.eu 2010, Dave and I discussed about the options dialog. We
> > would like to make it look like the Visual Studio options dialog.
> > Something like this one:
> >
> > http://www.timvw.be/wp-content/images/msbuildverbosity.gif
> >
> > So, tonight, I've been thinking about it and how to use the treeview,
> > and here is what I propose:
> >
> > General
> > Help path
> > (PG help path, EDB help path, GP help path, Slony help path)
> > Binaries path
> > (PG bin path, EDB bin path, GP bin path, Slony bin path,
> > Ignore server/utility version mismatches)
> > Miscellanous
> > (System schemas)
> > Browser
> > Display
> > (list of objects, Default button)
> > Properties
> > Table
> > (Count rows if estimated less than)
> > Miscellanous
> > (Font, Confirm object deletion, Show system objects in the
> > treeview, Show users for privileges, Show object properties on
> > double click in the treeview)
> > Query tool
> > Query editor
> > (Font, Indent characters, Use spaces instead of tabs, Copy SQL
> > from main window to query tool)
> > Results grid
> > (Result copy quoting, Result copy quote character, Result copy
> > field seperator, Show NULL values as <NULL>)
> > Query file
> > (Read and write Unicode UTF-8 files, Write BOM for UTF files,
> > Do not prompt for unsaved files on exit)
> > Favourites
> > (File path)
> > Macros
> > (File path)
> >
> > History file
> > (File path, Maximum queries to store, Maximum size of a stored
> > query)
> > pgAgent
> > (Maximum rows to retrieve)
> > Colours
> > Foreground/Background
> > Caret
> > Syntax highlighting
> > Status Window
> > Miscellanous
> > Guru hints
> > (Do not show gutu hints; Reset guru hints)
> > Logging
> > (Logfile, Log level)
> >
> > Comments?
>
> Seems OK.
>

Here it is. Patch attached, and a few screenshots.

Nice work Guillaume. I didn't see the original discussion about this so I didn't have any expectations, but this looks really good. This also means the options dialogue is able to add as many options as are needed in future without cramming them all in one tab, or having dozens of tabs to scroll through.

So this is effectively the same way that LibreOffice/OpenOffice does it :)

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: New options dialog

From

Dave Page

Date:

15 August 2011, 09:44:25

On Mon, Aug 15, 2011 at 10:39 AM, Thom Brown <thom@linux.com> wrote:
> On 15 August 2011 10:29, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>
>> On Mon, 2011-01-10 at 09:40 +0000, Dave Page wrote:
>> > Hi
>> >
>> > On Sun, Jan 9, 2011 at 11:26 PM, Guillaume Lelarge
>> > <guillaume@lelarge.info> wrote:
>> > > Hi,
>> > >
>> > > At pgday.eu 2010, Dave and I discussed about the options dialog. We
>> > > would like to make it look like the Visual Studio options dialog.
>> > > Something like this one:
>> > >
>> > >  http://www.timvw.be/wp-content/images/msbuildverbosity.gif
>> > >
>> > > So, tonight, I've been thinking about it and how to use the treeview,
>> > > and here is what I propose:
>> > >
>> > > General
>> > >  Help path
>> > >        (PG help path, EDB help path, GP help path, Slony help path)
>> > >  Binaries path
>> > >        (PG bin path, EDB bin path, GP bin path, Slony bin path,
>> > >         Ignore server/utility version mismatches)
>> > >  Miscellanous
>> > >        (System schemas)
>> > > Browser
>> > >  Display
>> > >        (list of objects, Default button)
>> > >  Properties
>> > >    Table
>> > >        (Count rows if estimated less than)
>> > >  Miscellanous
>> > >        (Font, Confirm object deletion, Show system objects in the
>> > >         treeview, Show users for privileges, Show object properties on
>> > >         double click in the treeview)
>> > > Query tool
>> > >  Query editor
>> > >        (Font, Indent characters, Use spaces instead of tabs, Copy SQL
>> > >         from main window to query tool)
>> > >  Results grid
>> > >        (Result copy quoting, Result copy quote character, Result copy
>> > >         field seperator, Show NULL values as <NULL>)
>> > >  Query file
>> > >        (Read and write Unicode UTF-8 files, Write BOM for UTF files,
>> > >         Do not prompt for unsaved files on exit)
>> > >  Favourites
>> > >        (File path)
>> > >  Macros
>> > >        (File path)
>> > >
>> > >  History file
>> > >        (File path, Maximum queries to store, Maximum size of a stored
>> > >         query)
>> > > pgAgent
>> > >        (Maximum rows to retrieve)
>> > > Colours
>> > >  Foreground/Background
>> > >  Caret
>> > >  Syntax highlighting
>> > >  Status Window
>> > > Miscellanous
>> > >  Guru hints
>> > >        (Do not show gutu hints; Reset guru hints)
>> > >  Logging
>> > >        (Logfile, Log level)
>> > >
>> > > Comments?
>> >
>> > Seems OK.
>> >
>>
>> Here it is. Patch attached, and a few screenshots.
>
> Nice work Guillaume.  I didn't see the original discussion about this so I
> didn't have any expectations, but this looks really good.  This also means
> the options dialogue is able to add as many options as are needed in future
> without cramming them all in one tab, or having dozens of tabs to scroll
> through.
> +1
> So this is effectively the same way that LibreOffice/OpenOffice does it :)

Oooh, shiny. Nice work Guillaume.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: New options dialog

From

Guillaume Lelarge

Date:

15 August 2011, 13:07:24

On Mon, 2011-08-15 at 10:44 +0100, Dave Page wrote:
> On Mon, Aug 15, 2011 at 10:39 AM, Thom Brown <thom@linux.com> wrote:
> > On 15 August 2011 10:29, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> >>
> >> On Mon, 2011-01-10 at 09:40 +0000, Dave Page wrote:
> >> > Hi
> >> >
> >> > On Sun, Jan 9, 2011 at 11:26 PM, Guillaume Lelarge
> >> > <guillaume@lelarge.info> wrote:
> >> > > Hi,
> >> > >
> >> > > At pgday.eu 2010, Dave and I discussed about the options dialog. We
> >> > > would like to make it look like the Visual Studio options dialog.
> >> > > Something like this one:
> >> > >
> >> > >  http://www.timvw.be/wp-content/images/msbuildverbosity.gif
> >> > >
> >> > > So, tonight, I've been thinking about it and how to use the treeview,
> >> > > and here is what I propose:
> >> > >
> >> > > General
> >> > >  Help path
> >> > >        (PG help path, EDB help path, GP help path, Slony help path)
> >> > >  Binaries path
> >> > >        (PG bin path, EDB bin path, GP bin path, Slony bin path,
> >> > >         Ignore server/utility version mismatches)
> >> > >  Miscellanous
> >> > >        (System schemas)
> >> > > Browser
> >> > >  Display
> >> > >        (list of objects, Default button)
> >> > >  Properties
> >> > >    Table
> >> > >        (Count rows if estimated less than)
> >> > >  Miscellanous
> >> > >        (Font, Confirm object deletion, Show system objects in the
> >> > >         treeview, Show users for privileges, Show object properties on
> >> > >         double click in the treeview)
> >> > > Query tool
> >> > >  Query editor
> >> > >        (Font, Indent characters, Use spaces instead of tabs, Copy SQL
> >> > >         from main window to query tool)
> >> > >  Results grid
> >> > >        (Result copy quoting, Result copy quote character, Result copy
> >> > >         field seperator, Show NULL values as <NULL>)
> >> > >  Query file
> >> > >        (Read and write Unicode UTF-8 files, Write BOM for UTF files,
> >> > >         Do not prompt for unsaved files on exit)
> >> > >  Favourites
> >> > >        (File path)
> >> > >  Macros
> >> > >        (File path)
> >> > >
> >> > >  History file
> >> > >        (File path, Maximum queries to store, Maximum size of a stored
> >> > >         query)
> >> > > pgAgent
> >> > >        (Maximum rows to retrieve)
> >> > > Colours
> >> > >  Foreground/Background
> >> > >  Caret
> >> > >  Syntax highlighting
> >> > >  Status Window
> >> > > Miscellanous
> >> > >  Guru hints
> >> > >        (Do not show gutu hints; Reset guru hints)
> >> > >  Logging
> >> > >        (Logfile, Log level)
> >> > >
> >> > > Comments?
> >> >
> >> > Seems OK.
> >> >
> >>
> >> Here it is. Patch attached, and a few screenshots.
> >
> > Nice work Guillaume.  I didn't see the original discussion about this so I
> > didn't have any expectations, but this looks really good.  This also means
> > the options dialogue is able to add as many options as are needed in future
> > without cramming them all in one tab, or having dozens of tabs to scroll
> > through.

Yeah, that's why I decided to work on this. We need more space for
options (some of the query tool, that should be there, but are in the
query tool menus right now... and I expect to have some options too for
the database designer).

> > +1
> > So this is effectively the same way that LibreOffice/OpenOffice does it :)
>
> Oooh, shiny. Nice work Guillaume.
>

Thank you both. I did some changes, mainly because of a bug on Windows.
Will commit it later.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com

Re: New options dialog

From

Guillaume Lelarge

Date:

15 August 2011, 14:35:05

On Mon, 2011-08-15 at 15:07 +0200, Guillaume Lelarge wrote:
> On Mon, 2011-08-15 at 10:44 +0100, Dave Page wrote:
> > On Mon, Aug 15, 2011 at 10:39 AM, Thom Brown <thom@linux.com> wrote:
> > > On 15 August 2011 10:29, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> > >>
> > >> On Mon, 2011-01-10 at 09:40 +0000, Dave Page wrote:
> > >> > Hi
> > >> >
> > >> > On Sun, Jan 9, 2011 at 11:26 PM, Guillaume Lelarge
> > >> > <guillaume@lelarge.info> wrote:
> > >> > > Hi,
> > >> > >
> > >> > > At pgday.eu 2010, Dave and I discussed about the options dialog. We
> > >> > > would like to make it look like the Visual Studio options dialog.
> > >> > > Something like this one:
> > >> > >
> > >> > >  http://www.timvw.be/wp-content/images/msbuildverbosity.gif
> > >> > >
> > >> > > So, tonight, I've been thinking about it and how to use the treeview,
> > >> > > and here is what I propose:
> > >> > >
> > >> > > General
> > >> > >  Help path
> > >> > >        (PG help path, EDB help path, GP help path, Slony help path)
> > >> > >  Binaries path
> > >> > >        (PG bin path, EDB bin path, GP bin path, Slony bin path,
> > >> > >         Ignore server/utility version mismatches)
> > >> > >  Miscellanous
> > >> > >        (System schemas)
> > >> > > Browser
> > >> > >  Display
> > >> > >        (list of objects, Default button)
> > >> > >  Properties
> > >> > >    Table
> > >> > >        (Count rows if estimated less than)
> > >> > >  Miscellanous
> > >> > >        (Font, Confirm object deletion, Show system objects in the
> > >> > >         treeview, Show users for privileges, Show object properties on
> > >> > >         double click in the treeview)
> > >> > > Query tool
> > >> > >  Query editor
> > >> > >        (Font, Indent characters, Use spaces instead of tabs, Copy SQL
> > >> > >         from main window to query tool)
> > >> > >  Results grid
> > >> > >        (Result copy quoting, Result copy quote character, Result copy
> > >> > >         field seperator, Show NULL values as <NULL>)
> > >> > >  Query file
> > >> > >        (Read and write Unicode UTF-8 files, Write BOM for UTF files,
> > >> > >         Do not prompt for unsaved files on exit)
> > >> > >  Favourites
> > >> > >        (File path)
> > >> > >  Macros
> > >> > >        (File path)
> > >> > >
> > >> > >  History file
> > >> > >        (File path, Maximum queries to store, Maximum size of a stored
> > >> > >         query)
> > >> > > pgAgent
> > >> > >        (Maximum rows to retrieve)
> > >> > > Colours
> > >> > >  Foreground/Background
> > >> > >  Caret
> > >> > >  Syntax highlighting
> > >> > >  Status Window
> > >> > > Miscellanous
> > >> > >  Guru hints
> > >> > >        (Do not show gutu hints; Reset guru hints)
> > >> > >  Logging
> > >> > >        (Logfile, Log level)
> > >> > >
> > >> > > Comments?
> > >> >
> > >> > Seems OK.
> > >> >
> > >>
> > >> Here it is. Patch attached, and a few screenshots.
> > >
> > > Nice work Guillaume.  I didn't see the original discussion about this so I
> > > didn't have any expectations, but this looks really good.  This also means
> > > the options dialogue is able to add as many options as are needed in future
> > > without cramming them all in one tab, or having dozens of tabs to scroll
> > > through.
>
> Yeah, that's why I decided to work on this. We need more space for
> options (some of the query tool, that should be there, but are in the
> query tool menus right now... and I expect to have some options too for
> the database designer).
>
> > > +1
> > > So this is effectively the same way that LibreOffice/OpenOffice does it :)
> >
> > Oooh, shiny. Nice work Guillaume.
> >
>
> Thank you both. I did some changes, mainly because of a bug on Windows.
> Will commit it later.
>

Commited, pushed, etc.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com