Thread: pgAdmin III commit: Fix the enableing of Unlogged checkbox

pgAdmin III commit: Fix the enableing of Unlogged checkbox

From
Guillaume Lelarge
Date:
Fix the enableing of Unlogged checkbox

The Unlogged checkbox should be disabled if the user isn't connected to a 9.1+
PostgreSQL server.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7558d286095cc5541df08078bfd24936eedf2c15

Modified Files
--------------
pgadmin/dlg/dlgTable.cpp |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


Re: pgAdmin III commit: Fix the enableing of Unlogged checkbox

From
Jasmin Dizdarevic
Date:
Hi, 

sorry, but there is still a bug: 

When I click on a table the following statement is shown in the SQL pane:

CREATE UNLOGGED TABLE berfil.tasks
(
  taskid character varying(32) NOT NULL,
  taskyear numeric(4,0),

and when opening properties the checkbox is checked. Backend is 8.4.

Just another idea: Wouldn't it be nice to show if a table is unlogged or not in the properties?

Regards,
Jasmin



2011/1/9 Guillaume Lelarge <guillaume@lelarge.info>
Fix the enableing of Unlogged checkbox

The Unlogged checkbox should be disabled if the user isn't connected to a 9.1+
PostgreSQL server.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7558d286095cc5541df08078bfd24936eedf2c15

Modified Files
--------------
pgadmin/dlg/dlgTable.cpp |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin III commit: Fix the enableing of Unlogged checkbox

From
Guillaume Lelarge
Date:
Hi,

Le 09/01/2011 22:04, Jasmin Dizdarevic a écrit :
> [...]
> sorry, but there is still a bug:
>
> When I click on a table the following statement is shown in the SQL pane:
>
> CREATE UNLOGGED TABLE berfil.tasks
> (
>   taskid character varying(32) NOT NULL,
>   taskyear numeric(4,0),
>
> and when opening properties the checkbox is checked. Backend is 8.4.
>

It shouldn't. Working on it.

> Just another idea: Wouldn't it be nice to show if a table is unlogged or not
> in the properties?
>

It does. Only on 9.1.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Re: pgAdmin III commit: Fix the enableing of Unlogged checkbox

From
Guillaume Lelarge
Date:
Le 09/01/2011 22:25, Guillaume Lelarge a écrit :
> Hi,
>
> Le 09/01/2011 22:04, Jasmin Dizdarevic a écrit :
>> [...]
>> sorry, but there is still a bug:
>>
>> When I click on a table the following statement is shown in the SQL pane:
>>
>> CREATE UNLOGGED TABLE berfil.tasks
>> (
>>   taskid character varying(32) NOT NULL,
>>   taskyear numeric(4,0),
>>
>> and when opening properties the checkbox is checked. Backend is 8.4.
>>
>
> It shouldn't. Working on it.
>

You were right. This is fixed.

This "new year" patch is turning into a nightmare...


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com