Thread: Fwd: dlgEditGridOptions

Fwd: dlgEditGridOptions

From
Steffen Kuhn
Date:
Hi,

as already mentioned, I'm not that firm with the  multiplatform demands.
Anyway here is my suggest working on ubuntu gnome.

Regards
Steffen

-------- Original-Nachricht --------
Betreff:     dlgEditGridOptions
Datum:     Thu, 19 Aug 2010 21:56:08 +0200
Von:     Steffen Kuhn <steffen_kuhn@web.de>
An:     pg@kuhnsteffen.de



Hi,

on Ubuntu 10.04 with gonome running there is an issue with
      rightSize = lstSortCols->GetClientSize().GetWidth()-leftSize;
line 87.
lstSortCols->GetClientSize().GetWidth() isn't determined correct so that
columne 2 is added behind column 1.
See the result as pictrure attached.
I'm not so deep into this that I can deliver patch meeting the
multiplatform demands.



Attachment

Re: Fwd: dlgEditGridOptions

From
Dave Page
Date:
Hi Steffen

On Sun, Aug 22, 2010 at 3:30 PM, Steffen Kuhn <pg@kuhnsteffen.de> wrote:
> Hi,
>
> as already mentioned, I'm not that firm with the  multiplatform demands.
> Anyway here is my suggest working on ubuntu gnome.

I think I missed the email with the screenshot - can you resend it please?

Guillaume; this dialogue (like frmOptions) seems to have some residual
mis-formatting from the addition of sizers (I assume). Specifically,
there is no border between the tabset and the edges of the dialogue,
and the OK/Cancel buttons and the edges of the dialogue. Perhaps you
could work your magic on them, and apply Steffen's patch at the same
time if you think it's appropriate?

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

Attachment

Re: Fwd: dlgEditGridOptions

From
Guillaume Lelarge
Date:
Le 23/08/2010 16:33, Dave Page a écrit :
> Hi Steffen
>
> On Sun, Aug 22, 2010 at 3:30 PM, Steffen Kuhn <pg@kuhnsteffen.de> wrote:
>> Hi,
>>
>> as already mentioned, I'm not that firm with the  multiplatform demands.
>> Anyway here is my suggest working on ubuntu gnome.
>
> I think I missed the email with the screenshot - can you resend it please?
>
> Guillaume; this dialogue (like frmOptions) seems to have some residual
> mis-formatting from the addition of sizers (I assume). Specifically,
> there is no border between the tabset and the edges of the dialogue,
> and the OK/Cancel buttons and the edges of the dialogue. Perhaps you
> could work your magic on them, and apply Steffen's patch at the same
> time if you think it's appropriate?
>

Was working on it. Steffen's patch isn't appropriate, but he's right
about the bug on GTK. And you're right about the sizers. I still don't
know why but wxWidgets doesn't return us the good size of the list.
Anyway, I'm working on it.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Re: Fwd: dlgEditGridOptions

From
Dave Page
Date:
On Mon, Aug 23, 2010 at 3:42 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 23/08/2010 16:33, Dave Page a écrit :
>> Hi Steffen
>>
>> On Sun, Aug 22, 2010 at 3:30 PM, Steffen Kuhn <pg@kuhnsteffen.de> wrote:
>>> Hi,
>>>
>>> as already mentioned, I'm not that firm with the  multiplatform demands.
>>> Anyway here is my suggest working on ubuntu gnome.
>>
>> I think I missed the email with the screenshot - can you resend it please?
>>
>> Guillaume; this dialogue (like frmOptions) seems to have some residual
>> mis-formatting from the addition of sizers (I assume). Specifically,
>> there is no border between the tabset and the edges of the dialogue,
>> and the OK/Cancel buttons and the edges of the dialogue. Perhaps you
>> could work your magic on them, and apply Steffen's patch at the same
>> time if you think it's appropriate?
>>
>
> Was working on it. Steffen's patch isn't appropriate, but he's right
> about the bug on GTK. And you're right about the sizers. I still don't
> know why but wxWidgets doesn't return us the good size of the list.
> Anyway, I'm working on it.

Great - thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

Re: Fwd: dlgEditGridOptions

From
Guillaume Lelarge
Date:
Le 23/08/2010 16:44, Dave Page a écrit :
> On Mon, Aug 23, 2010 at 3:42 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 23/08/2010 16:33, Dave Page a écrit :
>>> Hi Steffen
>>>
>>> On Sun, Aug 22, 2010 at 3:30 PM, Steffen Kuhn <pg@kuhnsteffen.de> wrote:
>>>> Hi,
>>>>
>>>> as already mentioned, I'm not that firm with the  multiplatform demands.
>>>> Anyway here is my suggest working on ubuntu gnome.
>>>
>>> I think I missed the email with the screenshot - can you resend it please?
>>>
>>> Guillaume; this dialogue (like frmOptions) seems to have some residual
>>> mis-formatting from the addition of sizers (I assume). Specifically,
>>> there is no border between the tabset and the edges of the dialogue,
>>> and the OK/Cancel buttons and the edges of the dialogue. Perhaps you
>>> could work your magic on them, and apply Steffen's patch at the same
>>> time if you think it's appropriate?
>>>
>>
>> Was working on it. Steffen's patch isn't appropriate, but he's right
>> about the bug on GTK. And you're right about the sizers. I still don't
>> know why but wxWidgets doesn't return us the good size of the list.
>> Anyway, I'm working on it.
>
> Great - thanks.
>

It took me some time to get back to it, but I finally commited this.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Re: Fwd: dlgEditGridOptions

From
Dave Page
Date:
On Tue, Dec 21, 2010 at 10:49 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 23/08/2010 16:44, Dave Page a écrit :
>> On Mon, Aug 23, 2010 at 3:42 PM, Guillaume Lelarge
>> <guillaume@lelarge.info> wrote:
>>> Le 23/08/2010 16:33, Dave Page a écrit :
>>>> Hi Steffen
>>>>
>>>> On Sun, Aug 22, 2010 at 3:30 PM, Steffen Kuhn <pg@kuhnsteffen.de> wrote:
>>>>> Hi,
>>>>>
>>>>> as already mentioned, I'm not that firm with the  multiplatform demands.
>>>>> Anyway here is my suggest working on ubuntu gnome.
>>>>
>>>> I think I missed the email with the screenshot - can you resend it please?
>>>>
>>>> Guillaume; this dialogue (like frmOptions) seems to have some residual
>>>> mis-formatting from the addition of sizers (I assume). Specifically,
>>>> there is no border between the tabset and the edges of the dialogue,
>>>> and the OK/Cancel buttons and the edges of the dialogue. Perhaps you
>>>> could work your magic on them, and apply Steffen's patch at the same
>>>> time if you think it's appropriate?
>>>>
>>>
>>> Was working on it. Steffen's patch isn't appropriate, but he's right
>>> about the bug on GTK. And you're right about the sizers. I still don't
>>> know why but wxWidgets doesn't return us the good size of the list.
>>> Anyway, I'm working on it.
>>
>> Great - thanks.
>>
>
> It took me some time to get back to it, but I finally commited this.

Thanks :-)

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company