Thread: PATCH: wx/sysopt.h header missing

PATCH: wx/sysopt.h header missing

From
Ashesh Vashi
Date:
Hi Dave,

I am not able to compile the pgadmin on OSX.
PFA for the same to resolve the issue.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA -
The Enterprise Postgres Company


Attachment

Re: PATCH: wx/sysopt.h header missing

From
Guillaume Lelarge
Date:
Hi Ashesh,

Le 06/05/2010 09:12, Ashesh Vashi a écrit :
> [...]
> I am not able to compile the pgadmin on OSX.
> PFA for the same to resolve the issue.
>

That's an include I got rid of yesterday. I only checked on Windows and
Linux. I should have checked on Mac OS X. I'll do next time. Sorry about
this.

Did you have any other issues? (because I removed other #include to get
rid of warnings on VC++)

was it on trunk or the 1.10 branch? did you check them both? I'll try a
compile on them right now.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Re: PATCH: wx/sysopt.h header missing

From
Ashesh Vashi
Date:
On trunk...

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA -
The Enterprise Postgres Company



On Thu, May 6, 2010 at 12:55 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote:
Hi Ashesh,

Le 06/05/2010 09:12, Ashesh Vashi a écrit :
> [...]
> I am not able to compile the pgadmin on OSX.
> PFA for the same to resolve the issue.
>

That's an include I got rid of yesterday. I only checked on Windows and
Linux. I should have checked on Mac OS X. I'll do next time. Sorry about
this.

Did you have any other issues? (because I removed other #include to get
rid of warnings on VC++)

was it on trunk or the 1.10 branch? did you check them both? I'll try a
compile on them right now.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Re: PATCH: wx/sysopt.h header missing

From
Ashesh Vashi
Date:
Hi Guillaume,

Compiles well other than this.
I think - we need to change this on both trunk and 1.10 branch.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA -
The Enterprise Postgres Company



On Thu, May 6, 2010 at 12:55 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote:
Hi Ashesh,

Le 06/05/2010 09:12, Ashesh Vashi a écrit :
> [...]
> I am not able to compile the pgadmin on OSX.
> PFA for the same to resolve the issue.
>

That's an include I got rid of yesterday. I only checked on Windows and
Linux. I should have checked on Mac OS X. I'll do next time. Sorry about
this.

Did you have any other issues? (because I removed other #include to get
rid of warnings on VC++)

was it on trunk or the 1.10 branch? did you check them both? I'll try a
compile on them right now.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Re: PATCH: wx/sysopt.h header missing

From
Guillaume Lelarge
Date:
Le 06/05/2010 09:55, Ashesh Vashi a écrit :
> [...]
> Compiles well other than this.
> I think - we need to change this on both trunk and 1.10 branch.
>

I commited your patch. Thanks for noticing and providing a patch. I
promise I won't ever commit something without first checking on all the
platforms I have.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com