Postgres Pro
Downloads
Home   >   mailing lists

Thread: Warning on -TRUNK

Warning on -TRUNK

From
Dave Page
Date:
./dlg/dlgTrigger.cpp: In member function `void
dlgTrigger::OnAddCol(wxCommandEvent&)':
./dlg/dlgTrigger.cpp:209: warning: unused variable 'colIndex'

Looks like the variable can just be removed - or were you going to use
it for something you've since forgotten about?

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Re: Warning on -TRUNK

From
Guillaume Lelarge
Date:
Le vendredi 11 décembre 2009 à 09:41:59, Dave Page a écrit :
> ./dlg/dlgTrigger.cpp: In member function `void
> dlgTrigger::OnAddCol(wxCommandEvent&)':
> ./dlg/dlgTrigger.cpp:209: warning: unused variable 'colIndex'
>
> Looks like the variable can just be removed - or were you going to use
> it for something you've since forgotten about?
>

No, it can be removed. I copied/pasted some code of dlgIndex, but forgot to
remove the variable. I'll commit a fix soon.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Re: Warning on -TRUNK

From
Dave Page
Date:
On Fri, Dec 11, 2009 at 8:55 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le vendredi 11 décembre 2009 à 09:41:59, Dave Page a écrit :
>> ./dlg/dlgTrigger.cpp: In member function `void
>> dlgTrigger::OnAddCol(wxCommandEvent&)':
>> ./dlg/dlgTrigger.cpp:209: warning: unused variable 'colIndex'
>>
>> Looks like the variable can just be removed - or were you going to use
>> it for something you've since forgotten about?
>>
>
> No, it can be removed. I copied/pasted some code of dlgIndex, but forgot to
> remove the variable. I'll commit a fix soon.

Cool, thanks.



--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Re: Warning on -TRUNK

From
Guillaume Lelarge
Date:
Le vendredi 11 décembre 2009 à 09:57:55, Dave Page a écrit :
> On Fri, Dec 11, 2009 at 8:55 AM, Guillaume Lelarge
>
> <guillaume@lelarge.info> wrote:
> > Le vendredi 11 décembre 2009 à 09:41:59, Dave Page a écrit :
> >> ./dlg/dlgTrigger.cpp: In member function `void
> >> dlgTrigger::OnAddCol(wxCommandEvent&)':
> >> ./dlg/dlgTrigger.cpp:209: warning: unused variable 'colIndex'
> >>
> >> Looks like the variable can just be removed - or were you going to use
> >> it for something you've since forgotten about?
> >
> > No, it can be removed. I copied/pasted some code of dlgIndex, but forgot
> > to remove the variable. I'll commit a fix soon.
>
> Cool, thanks.
>

Done.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com