Thread: problem with SVN Commit by hiroshi: r7562

problem with SVN Commit by hiroshi: r7562

From
Sergey Burladyan
Date:
problem patch: http://archives.postgresql.org/pgadmin-hackers/2009-01/msg00166.php
with this patch cyrillic logs displayed incorrectly.


revert some lines from it fix problem:
-        wxString str;
-        if (wxString(wxString(raw,wxConvLibc),wxConvUTF8).Len() > 0)
-            str = line + wxString(wxString(raw,wxConvLibc),wxConvUTF8);
-        else
-            str = line + wxTextBuffer::Translate(wxString(raw, set->GetConversion()), wxTextFileType_Unix);
+        wxString str = line + wxTextBuffer::Translate(wxString(raw, set->GetConversion()), wxTextFileType_Unix);


i can't understand what is going on here:
wxString(wxString(raw,wxConvLibc),wxConvUTF8)

but without it - log loaded with correct encoding.

test locale settings:
cp1251=# select name, setting from pg_settings where name like 'lc_%' or name like '%encod%';
      name       |   setting
-----------------+--------------
 client_encoding | WIN1251
 lc_collate      | ru_RU.CP1251
 lc_ctype        | ru_RU.CP1251
 lc_messages     | ru_RU.CP1251
 lc_monetary     | ru_RU.CP1251
 lc_numeric      | ru_RU.CP1251
 lc_time         | ru_RU.CP1251
 server_encoding | WIN1251

cp1251@seb:~$ locale
LANG=ru_RU.CP1251
LC_CTYPE="ru_RU.CP1251"
LC_NUMERIC="ru_RU.CP1251"
LC_TIME="ru_RU.CP1251"
LC_COLLATE="ru_RU.CP1251"
LC_MONETARY="ru_RU.CP1251"
LC_MESSAGES="ru_RU.CP1251"
LC_PAPER="ru_RU.CP1251"
LC_NAME="ru_RU.CP1251"
LC_ADDRESS="ru_RU.CP1251"
LC_TELEPHONE="ru_RU.CP1251"
LC_MEASUREMENT="ru_RU.CP1251"
LC_IDENTIFICATION="ru_RU.CP1251"
LC_ALL=


--
Sergey Burladyan

Attachment

Re: problem with SVN Commit by hiroshi: r7562

From
"Hiroshi Saito"
Date:
Hi Sergey-san.

Um, It contains the problem of a very difficult Postgres server.:-(
http://archives.postgresql.org//pgadmin-hackers/2009-01/msg00159.php
http://archives.postgresql.org//pgadmin-hackers/2009-01/msg00160.php

The problem is seen in Japan at the time of patch which you propose.
However, I think that you should take some into consideration by the reason
for having the realistic problem.....

Please let me inquire after discussion with Dave and Guillaume.

BTW, We have not solved the encoding problem of a server log yet.
The plan was considered this way and that in a certain form.
http://winpg.jp/~saito/pg_work/ELOG_ENCODING_PALN/
Although this is ad hoc, it has a prototype.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Sergey Burladyan" <eshkinkot@gmail.com>


>
> problem patch: http://archives.postgresql.org/pgadmin-hackers/2009-01/msg00166.php
> with this patch cyrillic logs displayed incorrectly.
>
>


--------------------------------------------------------------------------------


>
> revert some lines from it fix problem:
> -        wxString str;
> -        if (wxString(wxString(raw,wxConvLibc),wxConvUTF8).Len() > 0)
> -            str = line + wxString(wxString(raw,wxConvLibc),wxConvUTF8);
> -        else
> -            str = line + wxTextBuffer::Translate(wxString(raw, set->GetConversion()),
> wxTextFileType_Unix);
> +        wxString str = line + wxTextBuffer::Translate(wxString(raw, set->GetConversion()),
> wxTextFileType_Unix);
>
>


--------------------------------------------------------------------------------


>
> i can't understand what is going on here:
> wxString(wxString(raw,wxConvLibc),wxConvUTF8)
>
> but without it - log loaded with correct encoding.
>
> test locale settings:
> cp1251=# select name, setting from pg_settings where name like 'lc_%' or name like '%encod%';
>      name       |   setting
> -----------------+--------------
> client_encoding | WIN1251
> lc_collate      | ru_RU.CP1251
> lc_ctype        | ru_RU.CP1251
> lc_messages     | ru_RU.CP1251
> lc_monetary     | ru_RU.CP1251
> lc_numeric      | ru_RU.CP1251
> lc_time         | ru_RU.CP1251
> server_encoding | WIN1251
>
> cp1251@seb:~$ locale
> LANG=ru_RU.CP1251
> LC_CTYPE="ru_RU.CP1251"
> LC_NUMERIC="ru_RU.CP1251"
> LC_TIME="ru_RU.CP1251"
> LC_COLLATE="ru_RU.CP1251"
> LC_MONETARY="ru_RU.CP1251"
> LC_MESSAGES="ru_RU.CP1251"
> LC_PAPER="ru_RU.CP1251"
> LC_NAME="ru_RU.CP1251"
> LC_ADDRESS="ru_RU.CP1251"
> LC_TELEPHONE="ru_RU.CP1251"
> LC_MEASUREMENT="ru_RU.CP1251"
> LC_IDENTIFICATION="ru_RU.CP1251"
> LC_ALL=
>
>
> --
> Sergey Burladyan
>


--------------------------------------------------------------------------------


>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>