Thread: Patch for pgScript
Hi pgadmin hackers, First, let me wish you a very happy new year 2009. Then, here is a patch for the pgScript part of pgAdmin: Features: - Use of pgAdmin UI to highlight the line where an error occurred (frmQuery, pgsDriver, pgsThread, pgsApplication, pgsStmtList) - Possibility to execute only one part of the script by selecting it (frmQuery) - Changed output style (exceptions/*, expressions/pgsExecute, statements/pgsStmtList) - Improved the script for integration tests: it does not print the executed queries anymore because the output was too messy (xtra/pgscript/file/test/execute.sh) Bugs: - Fixed print statement which caused a lock in case an exception was thrown (statement/pgsPrintStmt) Best regards, Mickael
Attachment
Hi! Sorry for the delay in reviewing. Does using "[PGSWARNG]" really make sense? It saves only *two* characters over the much more readanle "[PGSWARNING]" //Magnus Mickael Deloison wrote: > Hi pgadmin hackers, > > First, let me wish you a very happy new year 2009. > > Then, here is a patch for the pgScript part of pgAdmin: > Features: > - Use of pgAdmin UI to highlight the line where an error occurred > (frmQuery, pgsDriver, pgsThread, pgsApplication, pgsStmtList) > - Possibility to execute only one part of the script by selecting it (frmQuery) > - Changed output style (exceptions/*, expressions/pgsExecute, > statements/pgsStmtList) > - Improved the script for integration tests: it does not print the > executed queries anymore because the output was too messy > (xtra/pgscript/file/test/execute.sh) > Bugs: > - Fixed print statement which caused a lock in case an exception was > thrown (statement/pgsPrintStmt) > > Best regards, > Mickael > > > ------------------------------------------------------------------------ > >
On Wed, Jan 21, 2009 at 12:39 PM, Magnus Hagander <magnus@hagander.net> wrote: > Hi! > > Sorry for the delay in reviewing. > > Does using "[PGSWARNG]" really make sense? It saves only *two* > characters over the much more readanle "[PGSWARNING]" Urgh. Definitely less readable. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
CC:ing your explanation back to the list for others to see. //Magnus Mickael Deloison wrote: > Hi, > > This is just meant for having same length as the other messages : > [PGSQUERY], [PGSWARNG], [PGSEXCPT] > If you do not like that, I (or you) can change it. Keep me posted. > > Regards, > Mickael > > 2009/1/21 Magnus Hagander <magnus@hagander.net>: >> Hi! >> >> Sorry for the delay in reviewing. >> >> Does using "[PGSWARNG]" really make sense? It saves only *two* >> characters over the much more readanle "[PGSWARNING]" >> >> >> //Magnus >> >> Mickael Deloison wrote: >>> Hi pgadmin hackers, >>> >>> First, let me wish you a very happy new year 2009. >>> >>> Then, here is a patch for the pgScript part of pgAdmin: >>> Features: >>> - Use of pgAdmin UI to highlight the line where an error occurred >>> (frmQuery, pgsDriver, pgsThread, pgsApplication, pgsStmtList) >>> - Possibility to execute only one part of the script by selecting it (frmQuery) >>> - Changed output style (exceptions/*, expressions/pgsExecute, >>> statements/pgsStmtList) >>> - Improved the script for integration tests: it does not print the >>> executed queries anymore because the output was too messy >>> (xtra/pgscript/file/test/execute.sh) >>> Bugs: >>> - Fixed print statement which caused a lock in case an exception was >>> thrown (statement/pgsPrintStmt) >>> >>> Best regards, >>> Mickael >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >>
On Wed, Jan 21, 2009 at 1:44 PM, Magnus Hagander <magnus@hagander.net> wrote: > Mickael Deloison wrote: >> Hi, >> >> This is just meant for having same length as the other messages : >> [PGSQUERY], [PGSWARNG], [PGSEXCPT] >> If you do not like that, I (or you) can change it. Keep me posted. What we normally do is pad after the variable length text with some spaces. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Magnus Hagander a écrit : > CC:ing your explanation back to the list for others to see. > > //Magnus > > > Mickael Deloison wrote: >> Hi, >> >> This is just meant for having same length as the other messages : >> [PGSQUERY], [PGSWARNG], [PGSEXCPT] >> If you do not like that, I (or you) can change it. Keep me posted. >> I don't know if these words will be translatable, but if they are, this argument is not a good one :) -- Guillaume. http://www.postgresqlfr.org http://dalibo.com