Thread: Patch for removing TipsOfDay functionality
Hi,
As per Dave page suggestion, I worked on removing the "Tips Of the Day" functionality.
I have attached the patch for it.
Please review it.
Regards,
Ashesh
As per Dave page suggestion, I worked on removing the "Tips Of the Day" functionality.
I have attached the patch for it.
Please review it.
Regards,
Ashesh
On Tue, Nov 4, 2008 at 6:02 AM, Ashesh D Vashi <ashesh.vashi@enterprisedb.com> wrote: > Hi, > > As per Dave page suggestion, I worked on removing the "Tips Of the Day" > functionality. > I have attached the patch for it. > > Please review it. Hi Ashesh, An eyeball review looks good - you've fixed up a couple of places I'd completely forgotten about. Just one change required I think; in the Windows installer part of the patch, there are a bunch of hunks like: <Component Id="de_de_docs" Guid="{BCC51FC8-18F9-46CB-A536-8EB8A55812F0}"> - <File Id="de_de_docs.tips.txt" Name="tips.txt" DiskId="1" Source="$(var.BUILDTREE)/docs/de_DE/tips.txt" /> + <CreateFolder/> </Component> We should just remove those empty components altogether I think. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
On Tue, Nov 4, 2008 at 1:37 PM, Ashesh D Vashi <ashesh.vashi@enterprisedb.com> wrote: > Hi, > > Please find the updated version of the patch. Thanks Ashesh - patch applied, with a minor change to remove the ComponentRefs for the Components that were removes from the Wix source. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com