Thread: Re: [Fwd: pgscript merged to svn trunk]

Re: [Fwd: pgscript merged to svn trunk]

From
Magnus Hagander
Date:
I have applied pgscript to trunk. YAY!

I'm sure a few more things will need to be adjusted still, but I wanted
to get this in before it drifts further.

One very clear thing - Mickael, I did not apply the screenshots, because
they have been superseeded by the GQB patch. Can you provide new ones,
please?

I'd also like to say Good Job! and Thanks! to Mickael - this is a great
new feature for pgadmin!

//Magnus


Mickael Deloison wrote:
> Hi Magnus,
>
> Some modified files including pgAdmin3.vcproj. I compiled both Linux
> and Windows versions successfully.
>
> Added:
>   * pgadmin/pgscript/README
>
> Modified:
>   * pgadmin/pgAdmin3.vcproj
>   * pgadmin/pgscript/module.mk
>   * pgadmin/pgscript/parser.sh
>   * xtra/Makefile.am
>
> This way of working is quite hard (modified files by email). I hope
> you can commit them so that it would be easier to update files.
>
> Best regards,
> Mickael
>
> 2008/9/10 Magnus Hagander <magnus@hagander.net>:
>>
>> -------- Original Message --------
>> Subject: pgscript merged to svn trunk
>> Date: Wed, 10 Sep 2008 16:18:02 +0200
>> From: Magnus Hagander <magnus@hagander.net>
>> To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
>>
>> Guys (Mickael in particular),
>>
>> I've merged the pgscript patch up with the current svn snapshot, and
>> also removed the support for --disable-pgscript. I've also cleaned up a
>> few other minor things.
>>
>> I'm not done with my review, but here's the updated snapshot so others
>> can check it. In particular, check that I didn't break anything that
>> worked before :-) Thanks!
>>
>> Oh - sidenote. I haven't merged up the VC++ project files yet, working
>> on that now, but I figured I should get the code out there already...
>>
>> //Magnus
>>
>>


Re: [Fwd: pgscript merged to svn trunk]

From
"Dave Page"
Date:
On Mon, Sep 15, 2008 at 2:10 PM, Magnus Hagander <magnus@hagander.net> wrote:
> I have applied pgscript to trunk. YAY!

Yay! indeed :-)

> I'd also like to say Good Job! and Thanks! to Mickael - this is a great
> new feature for pgadmin!

Yes, I'd like to echo that - nice work Mickael.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com