Thread: SQL tab on Server's properties dialog?
Hi, While working on the dialogs' review, I was wondering why we show the SQL tab for the Server's properties dialog. I think we shouldn't display this tab on this dialog. The patch enclosed does this. I'm not sure this qualifies as a bug. But it shouldn't be hard to apply the patch on the 1.8 branch. Comments? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: pgadmin/dlg/dlgProperty.cpp =================================================================== --- pgadmin/dlg/dlgProperty.cpp (revision 7393) +++ pgadmin/dlg/dlgProperty.cpp (working copy) @@ -311,8 +311,11 @@ void dlgProperty::CreateAdditionalPages() { - sqlPane = new ctlSQLBox(nbNotebook, CTL_PROPSQL, wxDefaultPosition, wxDefaultSize, wxTE_MULTILINE | wxSUNKEN_BORDER| wxTE_READONLY | wxTE_RICH2); - nbNotebook->AddPage(sqlPane, wxT("SQL")); + if (wxString(factory->GetTypeName()).Cmp(wxT("Server"))) + { + sqlPane = new ctlSQLBox(nbNotebook, CTL_PROPSQL, wxDefaultPosition, wxDefaultSize, wxTE_MULTILINE | wxSUNKEN_BORDER| wxTE_READONLY | wxTE_RICH2); + nbNotebook->AddPage(sqlPane, wxT("SQL")); + } }
On Sat, Jul 26, 2008 at 10:44 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Hi, > > While working on the dialogs' review, I was wondering why we show the SQL > tab for the Server's properties dialog. I think we shouldn't display this > tab on this dialog. The patch enclosed does this. > > I'm not sure this qualifies as a bug. But it shouldn't be hard to apply the > patch on the 1.8 branch. > > Comments? Bung it on -head, but don't bother with the 1.8 branch. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Sat, Jul 26, 2008 at 10:44 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> [...] >> While working on the dialogs' review, I was wondering why we show the SQL >> tab for the Server's properties dialog. I think we shouldn't display this >> tab on this dialog. The patch enclosed does this. >> >> I'm not sure this qualifies as a bug. But it shouldn't be hard to apply the >> patch on the 1.8 branch. >> >> Comments? > > Bung it on -head, but don't bother with the 1.8 branch. > Done. I don't know why the commit message didn't arrive on the list. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com