Thread: dlgCheck review

dlgCheck review

From

Guillaume Lelarge

Date:

21 July 2008, 23:26:44

A small property dialog. Works on Linux and Mac OS X.

Comments?


--
Guillaume.
  http://www.postgresqlfr.org
  http://dalibo.com
<?xml version="1.0" encoding="ISO-8859-1"?>
<resource>
  <object class="wxDialog" name="dlgCheck">
    <title></title>
    <style>wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER|wxRESIZE_BOX|wxTHICK_FRAME</style>
    <object class="wxFlexGridSizer">
      <cols>1</cols>
      <growablecols>0</growablecols>
      <growablerows>0</growablerows>
      <object class="sizeritem">
      <object class="wxNotebook" name="nbNotebook">
        <object class="notebookpage">
          <label>Properties</label>
          <object class="wxPanel" name="pnlProperties">
            <object class="wxFlexGridSizer">
              <cols>2</cols>
              <rows>4</rows>
              <vgap>5</vgap>
              <hgap>5</hgap>
              <growablerows>1</growablerows>
              <growablecols>1</growablecols>
              <object class="sizeritem">
                <object class="wxStaticText" name="stName">
                  <label>Name</label>
                  <pos>5,7d</pos>
                </object>
                <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                <border>4</border>
              </object>
              <object class="sizeritem">
                <object class="wxTextCtrl" name="txtName">
                  <pos>70,5d</pos>
                  <size>135,-1d</size>
                </object>
                <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                <border>4</border>
              </object>
              <object class="sizeritem">
                <object class="wxStaticText" name="stWhere">
                  <label>Check</label>
                  <pos>5,22d</pos>
                </object>
                <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                <border>4</border>
              </object>
              <object class="sizeritem">
                <object class="wxTextCtrl" name="txtWhere">
                  <pos>70,20d</pos>
                  <size>135,109d</size>
                  <style>wxTE_MULTILINE</style>
                </object>
                <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                <border>4</border>
              </object>
              <object class="sizeritem">
                <object class="wxStaticText" name="stComment">
                  <label>Comment</label>
                  <pos>5,134d</pos>
                </object>
                <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                <border>4</border>
              </object>
              <object class="sizeritem">
                <object class="wxTextCtrl" name="txtComment">
                  <pos>70,132d</pos>
                  <size>135,49d</size>
                  <style>wxTE_MULTILINE</style>
                </object>
                <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                <border>4</border>
              </object>
              <object class="sizeritem">
                <object class="wxStaticText" name="stClusterSet">
                  <label>Use replication</label>
                  <pos>5,186d</pos>
                </object>
                <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                <border>4</border>
              </object>
              <object class="sizeritem">
                <object class="wxComboBox" name="cbClusterSet">
                  <content/>
                  <pos>70,184d</pos>
                  <size>135,12d</size>
                  <style>wxCB_READONLY|wxCB_DROPDOWN</style>
                </object>
                <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                <border>4</border>
              </object>
              <flag>wxTOP|wxLEFT|wxRIGHT|wxGROW</flag>
            </object>
          </object>
        </object>
        <selected>1</selected>
      </object>
        <pos>2,2d</pos>
        <size>214,215d</size>
        <flag>wxALL|wxGROW|wxALIGN_CENTRE</flag>
        <border>3</border>
      </object>
      <object class="spacer">
        <size>2,2d</size>
      </object>
      <object class="sizeritem">
        <object class="wxFlexGridSizer">
          <cols>7</cols>
          <object class="spacer">
            <size>3,3d</size>
          </object>
          <object class="sizeritem">
            <object class="wxButton" name="wxID_HELP">
              <label>Help</label>
              <pos>135,220d</pos>
            </object>
          </object>
          <object class="spacer">
            <size>3,3d</size>
          </object>
          <object class="sizeritem">
            <object class="wxButton" name="wxID_OK">
              <label>&OK</label>
              <default>1</default>
              <pos>135,220d</pos>
            </object>
          </object>
          <object class="spacer">
            <size>3,3d</size>
          </object>
          <object class="sizeritem">
            <object class="wxButton" name="wxID_CANCEL">
              <label>&Cancel</label>
              <pos>176,220d</pos>
            </object>
          </object>
          <object class="spacer">
            <size>3,3d</size>
          </object>
          <growablecols>2</growablecols>
        </object>
        <flag>wxTOP|wxLEFT|wxRIGHT|wxGROW</flag>
      </object>
      <object class="spacer">
        <size>3,3d</size>
      </object>
      <object class="sizeritem">
        <object class="unknown" name="unkStatusBar">
          <size>-1,15d</size>
        </object>
        <flag>wxGROW|wxALIGN_CENTRE</flag>
        <border>3</border>
      </object>
    </object>
  </object>
</resource>

Re: dlgCheck review

From

"Dave Page"

Date:

22 July 2008, 13:36:31

On Tue, Jul 22, 2008 at 12:26 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> A small property dialog. Works on Linux and Mac OS X.
>
> Comments?

Yup, works well. Should we have the labels top-aligned with the
multi-line textboxes though? I'm not sure.

Screenshot attached for additional opinions... (hint hint people!)

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Attachment

ss2.png

Re: dlgCheck review

From

Guillaume Lelarge

Date:

22 July 2008, 13:48:22

Dave Page a écrit :
> On Tue, Jul 22, 2008 at 12:26 AM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> A small property dialog. Works on Linux and Mac OS X.
>>
>> Comments?
>
> Yup, works well. Should we have the labels top-aligned with the
> multi-line textboxes though? I'm not sure.
>

My opinion : we should have them top-aligned for consistency sake. In
the dlgAggregate dialog, second tab, we have the wxListCtrl on the
right, and a label and a button on the left side. The label is top
aligned, the button should be bottom aligned to sit next to the add
button. If this dialog shows a label top-aligned, the others should as well.

And I find top-alignement prettier on these dialogs :)

--
Guillaume.
  http://www.postgresqlfr.org
  http://dalibo.com

Re: dlgCheck review

From

"Dave Page"

Date:

22 July 2008, 13:52:28

On Tue, Jul 22, 2008 at 2:48 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Dave Page a écrit :
>> Yup, works well. Should we have the labels top-aligned with the
>> multi-line textboxes though? I'm not sure.
>>
>
> My opinion : we should have them top-aligned for consistency sake. In the
> dlgAggregate dialog, second tab, we have the wxListCtrl on the right, and a
> label and a button on the left side. The label is top aligned, the button
> should be bottom aligned to sit next to the add button. If this dialog shows
> a label top-aligned, the others should as well.
>
> And I find top-alignement prettier on these dialogs :)

On reflection, I think you're right.


--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Re: dlgCheck review

From

Guillaume Lelarge

Date:

22 July 2008, 23:26:13

Dave Page a écrit :
> On Tue, Jul 22, 2008 at 2:48 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Dave Page a écrit :
>>> Yup, works well. Should we have the labels top-aligned with the
>>> multi-line textboxes though? I'm not sure.
>>>
>> My opinion : we should have them top-aligned for consistency sake. In the
>> dlgAggregate dialog, second tab, we have the wxListCtrl on the right, and a
>> label and a button on the left side. The label is top aligned, the button
>> should be bottom aligned to sit next to the add button. If this dialog shows
>> a label top-aligned, the others should as well.
>>
>> And I find top-alignement prettier on these dialogs :)
>
> On reflection, I think you're right.
>

Fixed.


--
Guillaume.
  http://www.postgresqlfr.org
  http://dalibo.com