Thread: Redundant double-quotes in types

Redundant double-quotes in types

From

Erwin Brandstetter

Date:

19 February 2008, 18:58:03

Hi developers! Hi Dave!


Testing pgAdmin v.1.8.2 (Feb 5 2008), rev: 7050) on WinXP; host: pg 8.2.6 on
Debian Etch


An odd detail in pgAdmin 1.8.2 in reverse engineered SQL for types (in the
"TYPES" collection). The simple type "text" is double-quoted.
Example:
CREATE TYPE t_foo AS
    (foo_id integer,
     foo "text",
     sometxt "text");

Shouldn't that be:
CREATE TYPE t_foo AS
    (foo_id integer,
     foo text,
     sometxt text);

Doesn't seem to do any harm, but is still confusing.


Regards
Erwin

Re: Redundant double-quotes in types

From

"Dave Page"

Date:

20 February 2008, 10:00:39

On Tue, Feb 19, 2008 at 7:57 PM, Erwin Brandstetter
<brandstetter@falter.at> wrote:
> Hi developers! Hi Dave!
>
>
> Testing pgAdmin v.1.8.2 (Feb 5 2008), rev: 7050) on WinXP; host: pg 8.2.6 on
> Debian Etch
>
>
> An odd detail in pgAdmin 1.8.2 in reverse engineered SQL for types (in the
> "TYPES" collection). The simple type "text" is double-quoted.
> Example:
> CREATE TYPE t_foo AS
>    (foo_id integer,
>     foo "text",
>     sometxt "text");
>
> Shouldn't that be:
> CREATE TYPE t_foo AS
>    (foo_id integer,
>     foo text,
>     sometxt text);
>
> Doesn't seem to do any harm, but is still confusing.

Thanks, fixed in SVN.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Oracle-compatible database company