Thread: Re: [pgadmin-support] copy empty table crash

frank_lupo a écrit :
> I'm usign *pgAdmin1.6.3 (Mar 23 2007, rv: 6112), *when press copy button
> toolbar a empty table pgAdmin crash.
>

Here is a patch to fix this in 1.8.

Dave, can you apply it ? I don't have access to the svn server because
I'm on the PostgreSQLfr booth at the JDLL (a free software event in
Lyon, France).

Thanks for the report.

Regards.


--
Guillaume.
http://www.postgresqlfr.org
http://docs.postgresqlfr.org
Index: pgadmin/frm/frmEditGrid.cpp
===================================================================
--- pgadmin/frm/frmEditGrid.cpp    (révision 6751)
+++ pgadmin/frm/frmEditGrid.cpp    (copie de travail)
@@ -433,7 +433,7 @@
                 wxTheClipboard->Close();
             }
         }
-        else
+        else if(sqlGrid->GetNumberRows() > 0)
         {
             int copied;
             copied = sqlGrid->Copy();
@@ -482,7 +482,7 @@
             wxTheClipboard->Close();
         }
     }
-    else
+    else if(sqlGrid->GetNumberRows() > 0)
     {
         if (toolBar->GetToolEnabled(MNU_SAVE))
         {

Guillaume Lelarge wrote:
> frank_lupo a écrit :
>> I'm usign *pgAdmin1.6.3 (Mar 23 2007, rv: 6112), *when press copy
>> button toolbar a empty table pgAdmin crash.
>>
>
> Here is a patch to fix this in 1.8.
>
> Dave, can you apply it ? I don't have access to the svn server because
> I'm on the PostgreSQLfr booth at the JDLL (a free software event in
> Lyon, France).

Cool - in the field patching :-) Applied - thanks Guillaume, and for the
report Frank.

/D