Thread: RC2 needed?
Does anyone think we need an RC2 release? The list of changes since RC1 is currently (excluding translations etc): - Icon update - Guard against checking the server version if we're not connected. - Check the PostgreSQL release before adding tablespace query, per reports from Albin Blaschka and Ariel R. Giomi. - Fix the tablespace issue on index and indexconstraint. - Avoid using a correlated subquery that Greenplum doesn't support, per report from Jon Roberts. - Prevent characters being incorrectly stripped from foreign key column names, per Alexander Kirpa - Cleanup some compiler warnings /D
Dave Page a écrit : > Does anyone think we need an RC2 release? The list of changes since RC1 > is currently (excluding translations etc): > > - Icon update > - Guard against checking the server version if we're not connected. > - Check the PostgreSQL release before adding tablespace query, per > reports from Albin Blaschka and Ariel R. Giomi. > - Fix the tablespace issue on index and indexconstraint. > - Avoid using a correlated subquery that Greenplum doesn't support, per > report from Jon Roberts. > - Prevent characters being incorrectly stripped from foreign key column > names, per Alexander Kirpa > - Cleanup some compiler warnings > I don't think we need one. Even Erwin didn't complain for a month or so :) Regards. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Guillaume Lelarge wrote: > Even Erwin didn't complain for a month or so :) :-D /D
On Mon, Oct 15, 2007 at 01:55:34PM +0100, Dave Page wrote: > Does anyone think we need an RC2 release? The list of changes since RC1 > is currently (excluding translations etc): > > - Icon update > - Guard against checking the server version if we're not connected. > - Check the PostgreSQL release before adding tablespace query, per > reports from Albin Blaschka and Ariel R. Giomi. > - Fix the tablespace issue on index and indexconstraint. > - Avoid using a correlated subquery that Greenplum doesn't support, per > report from Jon Roberts. > - Prevent characters being incorrectly stripped from foreign key column > names, per Alexander Kirpa > - Cleanup some compiler warnings The greenplum query shouds like the one that would reallyi need a bit larger testing. Meaning it has to run against a bunch of different pg versinos. But if you've done that, then I think we're fine. //Magnus
Magnus Hagander wrote: > On Mon, Oct 15, 2007 at 01:55:34PM +0100, Dave Page wrote: >> Does anyone think we need an RC2 release? The list of changes since RC1 >> is currently (excluding translations etc): >> >> - Icon update >> - Guard against checking the server version if we're not connected. >> - Check the PostgreSQL release before adding tablespace query, per >> reports from Albin Blaschka and Ariel R. Giomi. >> - Fix the tablespace issue on index and indexconstraint. >> - Avoid using a correlated subquery that Greenplum doesn't support, per >> report from Jon Roberts. >> - Prevent characters being incorrectly stripped from foreign key column >> names, per Alexander Kirpa >> - Cleanup some compiler warnings > > The greenplum query shouds like the one that would reallyi need a bit > larger testing. Meaning it has to run against a bunch of different pg > versinos. But if you've done that, then I think we're fine. I've run it against 8.2 and 8.3, but it's not a hugely complex query. Anyone running SVN-trunk got any older installs running? /D
Dave Page a écrit : > Magnus Hagander wrote: >> On Mon, Oct 15, 2007 at 01:55:34PM +0100, Dave Page wrote: >>> Does anyone think we need an RC2 release? The list of changes since RC1 >>> is currently (excluding translations etc): >>> >>> - Icon update >>> - Guard against checking the server version if we're not connected. >>> - Check the PostgreSQL release before adding tablespace query, per >>> reports from Albin Blaschka and Ariel R. Giomi. >>> - Fix the tablespace issue on index and indexconstraint. >>> - Avoid using a correlated subquery that Greenplum doesn't support, per >>> report from Jon Roberts. >>> - Prevent characters being incorrectly stripped from foreign key column >>> names, per Alexander Kirpa >>> - Cleanup some compiler warnings >> The greenplum query shouds like the one that would reallyi need a bit >> larger testing. Meaning it has to run against a bunch of different pg >> versinos. But if you've done that, then I think we're fine. > > I've run it against 8.2 and 8.3, but it's not a hugely complex query. > Anyone running SVN-trunk got any older installs running? > I have 7.4-cvs and 8.1-cvs... I'll try on those. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Guillaume Lelarge wrote: > Dave Page a écrit : >> Magnus Hagander wrote: >>> On Mon, Oct 15, 2007 at 01:55:34PM +0100, Dave Page wrote: >>>> Does anyone think we need an RC2 release? The list of changes since RC1 >>>> is currently (excluding translations etc): >>>> >>>> - Icon update >>>> - Guard against checking the server version if we're not connected. >>>> - Check the PostgreSQL release before adding tablespace query, per >>>> reports from Albin Blaschka and Ariel R. Giomi. >>>> - Fix the tablespace issue on index and indexconstraint. >>>> - Avoid using a correlated subquery that Greenplum doesn't support, per >>>> report from Jon Roberts. >>>> - Prevent characters being incorrectly stripped from foreign key column >>>> names, per Alexander Kirpa >>>> - Cleanup some compiler warnings >>> The greenplum query shouds like the one that would reallyi need a bit >>> larger testing. Meaning it has to run against a bunch of different pg >>> versinos. But if you've done that, then I think we're fine. >> I've run it against 8.2 and 8.3, but it's not a hugely complex query. >> Anyone running SVN-trunk got any older installs running? >> > > I have 7.4-cvs and 8.1-cvs... I'll try on those. Thanks. Just tried 7.3 here but it won't build on my Mac :-( /D
Dave Page wrote: > Guillaume Lelarge wrote: >> Dave Page a écrit : >>> Magnus Hagander wrote: >>>> On Mon, Oct 15, 2007 at 01:55:34PM +0100, Dave Page wrote: >>>>> Does anyone think we need an RC2 release? The list of changes since RC1 >>>>> is currently (excluding translations etc): >>>>> >>>>> - Icon update >>>>> - Guard against checking the server version if we're not connected. >>>>> - Check the PostgreSQL release before adding tablespace query, per >>>>> reports from Albin Blaschka and Ariel R. Giomi. >>>>> - Fix the tablespace issue on index and indexconstraint. >>>>> - Avoid using a correlated subquery that Greenplum doesn't support, per >>>>> report from Jon Roberts. >>>>> - Prevent characters being incorrectly stripped from foreign key column >>>>> names, per Alexander Kirpa >>>>> - Cleanup some compiler warnings >>>> The greenplum query shouds like the one that would reallyi need a bit >>>> larger testing. Meaning it has to run against a bunch of different pg >>>> versinos. But if you've done that, then I think we're fine. >>> I've run it against 8.2 and 8.3, but it's not a hugely complex query. >>> Anyone running SVN-trunk got any older installs running? >>> >> I have 7.4-cvs and 8.1-cvs... I'll try on those. > > Thanks. Just tried 7.3 here but it won't build on my Mac :-( I can try 7.3, but you'll have to tell me what to test. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
Heikki Linnakangas wrote: >> Thanks. Just tried 7.3 here but it won't build on my Mac :-( > > I can try 7.3, but you'll have to tell me what to test. Thanks Heikki. - Create a postgres database (to avoid cluttering template1) - Run pgagent.sql (should be in xtra/pgagent in the pgadmin source tree) in that database. - Start a build of pgAdmin SVN-trunk. - Add a new server, using the postgres database as the maintenance db in the server dialogue. - Connect to the server and under the server node alongside databases and roles etc. you should see a 'Jobs' node. You shouldn't have got any SQL errors at this point! - Right-click Jobs, and try adding a simple job with a step and a schedule. - Try refreshing the Jobs node a couple of times. /D
Heikki Linnakangas a écrit : > Dave Page wrote: >> Guillaume Lelarge wrote: >>> Dave Page a écrit : >>>> Magnus Hagander wrote: >>>>> On Mon, Oct 15, 2007 at 01:55:34PM +0100, Dave Page wrote: >>>>>> Does anyone think we need an RC2 release? The list of changes since RC1 >>>>>> is currently (excluding translations etc): >>>>>> >>>>>> - Icon update >>>>>> - Guard against checking the server version if we're not connected. >>>>>> - Check the PostgreSQL release before adding tablespace query, per >>>>>> reports from Albin Blaschka and Ariel R. Giomi. >>>>>> - Fix the tablespace issue on index and indexconstraint. >>>>>> - Avoid using a correlated subquery that Greenplum doesn't support, per >>>>>> report from Jon Roberts. >>>>>> - Prevent characters being incorrectly stripped from foreign key column >>>>>> names, per Alexander Kirpa >>>>>> - Cleanup some compiler warnings >>>>> The greenplum query shouds like the one that would reallyi need a bit >>>>> larger testing. Meaning it has to run against a bunch of different pg >>>>> versinos. But if you've done that, then I think we're fine. >>>> I've run it against 8.2 and 8.3, but it's not a hugely complex query. >>>> Anyone running SVN-trunk got any older installs running? >>>> >>> I have 7.4-cvs and 8.1-cvs... I'll try on those. >> Thanks. Just tried 7.3 here but it won't build on my Mac :-( > > I can try 7.3, but you'll have to tell me what to test. > First, you'll need to install some stuff : * create a postgres database ; * change the pgagent.sql file (there's a dollar quote function that disallow it to be used where pre-8.0 release) ; * launch pgagent like this : pgagent hostaddr=IP_ADDR dbname=postgres Then * launch pgAdmin * create a job (http://www.pgadmin.org/docs/dev/pgagent-jobs.html) To be honest, I don't find the pgagent interface when I use my 7.4 and 8.1 cluster. This will take more time than I first thought. Regards. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Guillaume Lelarge wrote: > First, you'll need to install some stuff : > * create a postgres database ; > * change the pgagent.sql file (there's a dollar quote function that > disallow it to be used where pre-8.0 release) ; > * launch pgagent like this : > pgagent hostaddr=IP_ADDR dbname=postgres There's no need to run pgagent itself. All the changed code is in pgAdmin. > Then > * launch pgAdmin > * create a job (http://www.pgadmin.org/docs/dev/pgagent-jobs.html) > > To be honest, I don't find the pgagent interface when I use my 7.4 and > 8.1 cluster. This will take more time than I first thought. Make sure you run the SQL file in the maintenance DB. /D
Dave Page wrote:
> Heikki Linnakangas wrote:
>>> Thanks. Just tried 7.3 here but it won't build on my Mac :-(
>> I can try 7.3, but you'll have to tell me what to test.
>
> Thanks Heikki.
>
> - Create a postgres database (to avoid cluttering template1)
>
> - Run pgagent.sql (should be in xtra/pgagent in the pgadmin source tree)
> in that database.
That step failed:
ERROR: Function array_upper(boolean[], integer) does not exist
Unable to identify a function that satisfies the given argument
types
You may need to add explicit typecasts
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Dave Page a écrit : > Guillaume Lelarge wrote: >> First, you'll need to install some stuff : >> * create a postgres database ; >> * change the pgagent.sql file (there's a dollar quote function that >> disallow it to be used where pre-8.0 release) ; >> * launch pgagent like this : >> pgagent hostaddr=IP_ADDR dbname=postgres > > There's no need to run pgagent itself. All the changed code is in pgAdmin. > >> Then >> * launch pgAdmin >> * create a job (http://www.pgadmin.org/docs/dev/pgagent-jobs.html) >> >> To be honest, I don't find the pgagent interface when I use my 7.4 and >> 8.1 cluster. This will take more time than I first thought. > > Make sure you run the SQL file in the maintenance DB. > I found the issue with your last email. The maintenance DB was still template1. I can add a job but, even after a refresh, I can't see it. I only gave a name to my job and click OK. So, it seems the SELECT DISTINCT returns nothing. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Guillaume Lelarge a écrit : > Dave Page a écrit : >> Guillaume Lelarge wrote: >>> First, you'll need to install some stuff : >>> * create a postgres database ; >>> * change the pgagent.sql file (there's a dollar quote function that >>> disallow it to be used where pre-8.0 release) ; >>> * launch pgagent like this : >>> pgagent hostaddr=IP_ADDR dbname=postgres >> There's no need to run pgagent itself. All the changed code is in pgAdmin. >> >>> Then >>> * launch pgAdmin >>> * create a job (http://www.pgadmin.org/docs/dev/pgagent-jobs.html) >>> >>> To be honest, I don't find the pgagent interface when I use my 7.4 and >>> 8.1 cluster. This will take more time than I first thought. >> Make sure you run the SQL file in the maintenance DB. >> > > I found the issue with your last email. The maintenance DB was still > template1. > > I can add a job but, even after a refresh, I can't see it. I only gave a > name to my job and click OK. So, it seems the SELECT DISTINCT returns > nothing. > > I forgot to mention that this test was done using PostgreSQL 8.1 (latest CVS checkout). -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Heikki Linnakangas wrote: > Dave Page wrote: >> Heikki Linnakangas wrote: >>>> Thanks. Just tried 7.3 here but it won't build on my Mac :-( >>> I can try 7.3, but you'll have to tell me what to test. >> Thanks Heikki. >> >> - Create a postgres database (to avoid cluttering template1) >> >> - Run pgagent.sql (should be in xtra/pgagent in the pgadmin source tree) >> in that database. > > That step failed: > > ERROR: Function array_upper(boolean[], integer) does not exist > Unable to identify a function that satisfies the given argument > types > You may need to add explicit typecasts > :-) That shows how many folks are using pgagent with 7.3 - that's been there since at least April 2005! I'm inclined to just say we don't support pgAgent on 7.3. Thanks for testing. /D
Guillaume Lelarge wrote: > Dave Page a écrit : >> Guillaume Lelarge wrote: >>> First, you'll need to install some stuff : >>> * create a postgres database ; >>> * change the pgagent.sql file (there's a dollar quote function that >>> disallow it to be used where pre-8.0 release) ; >>> * launch pgagent like this : >>> pgagent hostaddr=IP_ADDR dbname=postgres >> There's no need to run pgagent itself. All the changed code is in pgAdmin. >> >>> Then >>> * launch pgAdmin >>> * create a job (http://www.pgadmin.org/docs/dev/pgagent-jobs.html) >>> >>> To be honest, I don't find the pgagent interface when I use my 7.4 and >>> 8.1 cluster. This will take more time than I first thought. >> Make sure you run the SQL file in the maintenance DB. >> > > I found the issue with your last email. The maintenance DB was still > template1. > > I can add a job but, even after a refresh, I can't see it. I only gave a > name to my job and click OK. So, it seems the SELECT DISTINCT returns > nothing. Rats - could have sworn I tested that but I must have done something stupid. Please try with SVN trunk - it should be OK now. /D
Dave Page a écrit : > Guillaume Lelarge wrote: >> Dave Page a écrit : >>> Guillaume Lelarge wrote: >>>> First, you'll need to install some stuff : >>>> * create a postgres database ; >>>> * change the pgagent.sql file (there's a dollar quote function that >>>> disallow it to be used where pre-8.0 release) ; >>>> * launch pgagent like this : >>>> pgagent hostaddr=IP_ADDR dbname=postgres >>> There's no need to run pgagent itself. All the changed code is in pgAdmin. >>> >>>> Then >>>> * launch pgAdmin >>>> * create a job (http://www.pgadmin.org/docs/dev/pgagent-jobs.html) >>>> >>>> To be honest, I don't find the pgagent interface when I use my 7.4 and >>>> 8.1 cluster. This will take more time than I first thought. >>> Make sure you run the SQL file in the maintenance DB. >>> >> I found the issue with your last email. The maintenance DB was still >> template1. >> >> I can add a job but, even after a refresh, I can't see it. I only gave a >> name to my job and click OK. So, it seems the SELECT DISTINCT returns >> nothing. > > Rats - could have sworn I tested that but I must have done something > stupid. Please try with SVN trunk - it should be OK now. > Works on 7.4 and 8.1. I'll commit my fix on the dollar quoting stuff if you don't mind. It'll allow 7.4 users to use pgAgent. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Dave Page wrote: > Heikki Linnakangas wrote: >> Dave Page wrote: >>> Heikki Linnakangas wrote: >>>>> Thanks. Just tried 7.3 here but it won't build on my Mac :-( >>>> I can try 7.3, but you'll have to tell me what to test. >>> Thanks Heikki. >>> >>> - Create a postgres database (to avoid cluttering template1) >>> >>> - Run pgagent.sql (should be in xtra/pgagent in the pgadmin source tree) >>> in that database. >> That step failed: >> >> ERROR: Function array_upper(boolean[], integer) does not exist >> Unable to identify a function that satisfies the given argument >> types >> You may need to add explicit typecasts >> > > :-) > > That shows how many folks are using pgagent with 7.3 - that's been there > since at least April 2005! > > I'm inclined to just say we don't support pgAgent on 7.3. Agreed, in case you actually wanted a second opinion on that. //Magnus
> ------- Original Message ------- > From: Guillaume Lelarge <guillaume@lelarge.info> > To: Dave Page <dpage@postgresql.org> > Sent: 15/10/07, 17:18:28 > Subject: Re: [pgadmin-hackers] RC2 needed? > > Dave Page a écrit : > > Guillaume Lelarge wrote: > >> Dave Page a écrit : > >>> Guillaume Lelarge wrote: > >>>> First, you'll need to install some stuff : > >>>> * create a postgres database ; > >>>> * change the pgagent.sql file (there's a dollar quote function that > >>>> disallow it to be used where pre-8.0 release) ; > >>>> * launch pgagent like this : > >>>> pgagent hostaddr=IP_ADDR dbname=postgres > >>> There's no need to run pgagent itself. All the changed code is in pgAdmin. > >>> > >>>> Then > >>>> * launch pgAdmin > >>>> * create a job (http://www.pgadmin.org/docs/dev/pgagent-jobs.html) > >>>> > >>>> To be honest, I don't find the pgagent interface when I use my 7.4 and > >>>> 8.1 cluster. This will take more time than I first thought. > >>> Make sure you run the SQL file in the maintenance DB. > >>> > >> I found the issue with your last email. The maintenance DB was still > >> template1. > >> > >> I can add a job but, even after a refresh, I can't see it. I only gave a > >> name to my job and click OK. So, it seems the SELECT DISTINCT returns > >> nothing. > > > > Rats - could have sworn I tested that but I must have done something > > stupid. Please try with SVN trunk - it should be OK now. > > > > Works on 7.4 and 8.1. I'll commit my fix on the dollar quoting stuff if > you don't mind. It'll allow 7.4 users to use pgAgent. Ok, thanks. /D
> ------- Original Message ------- > From: Magnus Hagander <magnus@hagander.net> > To: Dave Page <dpage@postgresql.org> > Sent: 15/10/07, 17:52:47 > Subject: Re: [pgadmin-hackers] RC2 needed? > > > I'm inclined to just say we don't support pgAgent on 7.3. > > Agreed, in case you actually wanted a second opinion on that. They're always useful :-) /D