Thread: small patch request(pgIndex.cpp)
Hi Dave. :\HOME\pgadmin3-1.6.0-beta1\src\schema\pgIndex.cpp(117) : error C2668: 'NumToStr' xx(snip)japanesexxxxxxx Thanks.! Regards, Hiroshi Saito
Attachment
> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Hiroshi Saito
> Sent: 15 September 2006 06:36
> To: pgadmin-hackers@postgresql.org
> Subject: [pgadmin-hackers] small patch request(pgIndex.cpp)
>
> Hi Dave.
>
> :\HOME\pgadmin3-1.6.0-beta1\src\schema\pgIndex.cpp(117) :
> error C2668: 'NumToStr' xx(snip)japanesexxxxxxx
Hi Hiroshi,
I don't understand why you think we need this?
- wxT("LEFT OUTER JOIN pg_opclass o ON (o.oid = i.indclass[") +
NumToStr(i-1) + wxT("])\n") +
+ wxT("LEFT OUTER JOIN pg_opclass o ON (o.oid = i.indclass[") +
NumToStr((wxLongLong)(i-1)) + wxT("])\n") +
'i' is a long, and we have
wxString NumToStr(long value)
{
wxString result;
result.Printf(wxT("%ld"), value);
return result;
}
In base.cpp.
?
Regards, Dave
Hi Dave.
I followed the intellisense of MS-VC simply. However, it may have
desirable long at the reason columnCount is long.
--correction:-)
NumToStr((long)(i-1))
--
Thanks!
Regards,
Hiroshi Saito
> Hi Dave.
>
> :\HOME\pgadmin3-1.6.0-beta1\src\schema\pgIndex.cpp(117) :
> error C2668: 'NumToStr' xx(snip)japanesexxxxxxx
Hi Hiroshi,
I don't understand why you think we need this?
- wxT("LEFT OUTER JOIN pg_opclass o ON (o.oid = i.indclass[") +
NumToStr(i-1) + wxT("])\n") +
+ wxT("LEFT OUTER JOIN pg_opclass o ON (o.oid = i.indclass[") +
NumToStr((wxLongLong)(i-1)) + wxT("])\n") +
'i' is a long, and we have
wxString NumToStr(long value)
{
wxString result;
result.Printf(wxT("%ld"), value);
return result;
}
In base.cpp.
?
Regards, Dave
> -----Original Message----- > From: Hiroshi Saito [mailto:z-saito@guitar.ocn.ne.jp] > Sent: 19 September 2006 05:15 > To: Dave Page; pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] small patch request(pgIndex.cpp) > > Hi Dave. > > I followed the intellisense of MS-VC simply. However, it may have > desirable long at the reason columnCount is long. > > --correction:-) > NumToStr((long)(i-1)) > -- Well 'i' is already a long, therefore (i-1) is a long and shouldn't require a cast. Are you getting a compiler warning form this? Regards, Dave
Hi Dave. > Well 'i' is already a long, therefore (i-1) is a long and shouldn't > require a cast. Are you getting a compiler warning form this? --- Sorry this is japanese ---- pgIndex.cpp c:\home\pgadmin3-1.6.0-beta1\src\schema\pgindex.cpp(117) : error C2668: 'NumToStr' : オーバーロード関数の呼び出しを解決することができません。(新機能 ; ヘルプを参照) cl.exe の実行エラー pgAdmin3.exe - エラー 1、警告 0 ---- It is happen in VC6..., but it left our support. However, I am checking the difference in two or more build environments, in order to remove release uneasiness. It is the dependency of a library. Regards, Hiroshi Saito
> -----Original Message----- > From: Hiroshi Saito [mailto:z-saito@guitar.ocn.ne.jp] > Sent: 19 September 2006 11:06 > To: Dave Page; pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] small patch request(pgIndex.cpp) > > Hi Dave. > > > Well 'i' is already a long, therefore (i-1) is a long and shouldn't > > require a cast. Are you getting a compiler warning form this? > > --- Sorry this is japanese ---- > pgIndex.cpp > c:\home\pgadmin3-1.6.0-beta1\src\schema\pgindex.cpp(117) : > error C2668: 'NumToStr' : オーバーロード関数の呼び出しを解決することができません。(新機能 ; ヘルプを参照) > cl.exe の実行エラー > > pgAdmin3.exe - エラー 1、警告 0 > > ---- > It is happen in VC6..., but it left our support. > However, I am checking the difference in two or more build > environments, > in order to remove release uneasiness. It is the dependency > of a library. OK, well, go ahead and commit the change if it helps - it certainly won't hurt. :-) Regards, Dave.