Thread: Re: Bug#364787: pgadmin3: pressing delete key on selected rows doesn't
> -----Original Message----- > From: Raphaël Enrici [mailto:blacknoz@club-internet.fr] > Sent: 14 May 2006 10:56 > To: Dave Page > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] Bug#364787: pgadmin3: pressing > delete key on selected rows doesn't > > I've just tried the patch and it seems not to be working. At > least for me. Did you try it or was it a blind patch? I'll do > further testing and give feedback. I'm sure that was working, but I grant you it's not now. I'm not sure how to make it work now though - what appears to behappening is that the individual cell is capturing the delete event and using it to delete the contents rather than theselected row. Ed ran into a similar problem recently - I wonder if he has any ideas? Regards, Dave.
Quoting Dave Page <dpage@vale-housing.co.uk>: > I'm sure that was working, but I grant you it's not now. I'm not > sure how to make it work now though - what appears to be happening > is that the individual cell is capturing the delete event and using > it to delete the contents rather than the selected row. > > Ed ran into a similar problem recently - I wonder if he has any ideas? Looking at the code, there are two handlers for the Delete key. OnDelete, which tries to delete a row, and OnKey, which just deletes the current cell. It looks like the two handlers need to be merged into one. Ed ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.
Dave Page wrote: > > >> -----Original Message----- >> From: Raphaël Enrici [mailto:blacknoz@club-internet.fr] >> Sent: 14 May 2006 10:56 >> To: Dave Page >> Cc: pgadmin-hackers@postgresql.org >> Subject: Re: [pgadmin-hackers] Bug#364787: pgadmin3: pressing >> delete key on selected rows doesn't >> >> I've just tried the patch and it seems not to be working. At >> least for me. Did you try it or was it a blind patch? I'll do >> further testing and give feedback. > > I'm sure that was working, but I grant you it's not now. I'm not sure how to make it work now though - what appears tobe happening is that the individual cell is capturing the delete event and using it to delete the contents rather thanthe selected row. > > Ed ran into a similar problem recently - I wonder if he has any ideas? > > Regards, Dave. Dave, I see that the changelog for 1.4.3 reports this bug as done: <li>2006-05-02 DP 1.4.3 Add an accelerator key (Delete) for deleting rows in the edit grid, per Emil Nowak. To me it's not fixed, at least on a fresh debian build. Did you get any answer from Ed? Regards, Raph