Thread: Updated copy patch
Here's an update to the results copying patch I sent last night. This patch makes the column headers back to what we agreed on when I did the grid work, and fixes the column size retention which last night's patch broke. Ed ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.
Attachment
Though advised differently, the patch starts with removing the ListView stuff, so I won't look any further at this version. Use the macro, it won't hurt. Regards, Andreas
Quoting Andreas Pflug <pgadmin@pse-consulting.de>: > Though advised differently, the patch starts with removing the ListView > stuff, so I won't look any further at this version. Use the macro, it > won't hurt. The grid allows basic functionality that everyone who uses a database except for you considers essential. The ListView offers exactly zero advantages over the grid. Due to wxWidgets sucking and not having any design consistency across different object, it would take require adding another 100 lines or so of code to a file that's only about 350 lines long to support both. You and I also both know that if the ListView code stays in, you will make every effort to break the grid code every chance you get. Ed ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.
> -----Original Message----- > From: pgadmin-hackers-owner@postgresql.org > [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of > Edward Di Geronimo Jr. > Sent: 01 May 2006 18:53 > To: pgadmin-hackers > Subject: [pgadmin-hackers] Updated copy patch > > Here's an update to the results copying patch I sent last > night. This patch makes the column headers back to what we > agreed on when I did the grid work, and fixes the column size > retention which last night's patch broke. Thanks Ed - all features work as expected and Andreas' speed improvements remain. Patch applied. Regards, Dave