Thread: programmers-readme.txt
Hm, I could have sworn that I already added programmers-readme.txt months ago to svn. Anyway, please review it if it makes sense to you. Regards Andreas
Where is it? :-) /D -----Original Message----- From: "Andreas Pflug"<pgadmin@pse-consulting.de> Sent: 30/04/06 18:58:44 To: "Dave Page"<dpage@vale-housing.co.uk>, "pgadmin-hackers"<pgadmin-hackers@postgresql.org> Subject: programmers-readme.txt Hm, I could have sworn that I already added programmers-readme.txt months ago to svn. Anyway, please review it if it makes sense to you. Regards Andreas -----Unmodified Original Message----- Hm, I could have sworn that I already added programmers-readme.txt months ago to svn. Anyway, please review it if it makes sense to you. Regards Andreas
Nevermind, I see it. Thanks. /D -----Original Message----- From: "Andreas Pflug"<pgadmin@pse-consulting.de> Sent: 30/04/06 18:58:44 To: "Dave Page"<dpage@vale-housing.co.uk>, "pgadmin-hackers"<pgadmin-hackers@postgresql.org> Subject: programmers-readme.txt Hm, I could have sworn that I already added programmers-readme.txt months ago to svn. Anyway, please review it if it makes sense to you. Regards Andreas -----Unmodified Original Message----- Hm, I could have sworn that I already added programmers-readme.txt months ago to svn. Anyway, please review it if it makes sense to you. Regards Andreas
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 30 April 2006 18:59 > To: Dave Page; pgadmin-hackers > Subject: programmers-readme.txt > > Hm, I could have sworn that I already added > programmers-readme.txt months ago to svn. Anyway, please > review it if it makes sense to you. Back at coding now, so... With this, and the refactoring you've done in frmMain/events.cpp, the factory stuff is infinitely easier to understand and no longer the incomprehensible mess that it previously was ( :-p ) so yes, it does make sense to me! One thing I did notice - if using contextActionFactory, each item is added to the context menu twice, the first copy of which doesn't work. A basic actionFactory *does* add the item to the context menu correctly though(!). Regards, Dave.
> -----Original Message----- > From: pgadmin-hackers-owner@postgresql.org > [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of Dave Page > Sent: 02 May 2006 10:22 > To: Andreas Pflug; pgadmin-hackers > Subject: Re: [pgadmin-hackers] programmers-readme.txt > > > One thing I did notice - if using contextActionFactory, each > item is added to the context menu twice, the first copy of > which doesn't work. A basic actionFactory *does* add the item > to the context menu correctly though(!). Scrub that - it does add it to the menu, but it doesn't work. There's only one item added though. /D
> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of Dave Page
> Sent: 02 May 2006 10:24
> To: Andreas Pflug; pgadmin-hackers
> Subject: Re: [pgadmin-hackers] programmers-readme.txt
>
>
>
> > -----Original Message-----
> > From: pgadmin-hackers-owner@postgresql.org
> > [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of Dave Page
> > Sent: 02 May 2006 10:22
> > To: Andreas Pflug; pgadmin-hackers
> > Subject: Re: [pgadmin-hackers] programmers-readme.txt
> >
> >
> > One thing I did notice - if using contextActionFactory,
> each item is
> > added to the context menu twice, the first copy of which
> doesn't work.
> > A basic actionFactory *does* add the item to the context menu
> > correctly though(!).
>
> Scrub that - it does add it to the menu, but it doesn't work.
> There's only one item added though.
OK, got it working - I hadn't SVN updated to get your fix from yesterday
(sorry).
So currently:
actionFactory works exactly as contextActionFactory should, adding menu
items to the Tools menu (under the appropriate sub menu) and items to
the context menu, either directly if there is only one, or under the
submenu if more than one.
contextActionFactory does all of the above, but also adds additional
copies of each menu item to the root of the context menu so you end up
with:
Contextmenu
-> Submenu
-> Foo
-> Bar
-> Foo
-> Bar
Regards, Dave.