Thread: SVN Commit by dpage: r5000 - in trunk/pgadmin3: . src/base src/include/base
SVN Commit by dpage: r5000 - in trunk/pgadmin3: . src/base src/include/base
From
svn@pgadmin.org
Date:
Author: dpage Date: 2006-02-17 10:49:24 +0000 (Fri, 17 Feb 2006) New Revision: 5000 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5000&view=rev Log: Properly escape single quotes in connection strings. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/src/base/base.cpp trunk/pgadmin3/src/base/pgConnBase.cpp trunk/pgadmin3/src/include/base/base.h
Re: SVN Commit by dpage: r5000 - in trunk/pgadmin3: . src/base src/include/base
From
Kris Jurka
Date:
svn@pgadmin.org wrote: > Author: dpage > > Date: 2006-02-17 10:49:24 +0000 (Fri, 17 Feb 2006) > > New Revision: 5000 > > Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5000&view=rev > > Log: > Properly escape single quotes in connection strings. > > This commit generates a warning all over the place: ../src/include/base/base.h:109:47: warning: multi-line comment Index: src/include/base/base.h =================================================================== *** src/include/base/base.h (revision 5005) --- src/include/base/base.h (working copy) *************** *** 105,112 **** // Quoting ! wxString qtString(const wxString& value); // add ' and escape if necessary ! wxString qtConnString(const wxString& value); // connection strings always have ' escaped with \ // check if size/pos have reasonable values void CheckOnScreen(wxPoint &pos, wxSize &size, const int w0=100, const int h0=70); --- 105,112 ---- // Quoting ! wxString qtString(const wxString& value); // add ' and escape if necessary ! wxString qtConnString(const wxString& value); // connection strings always have ' escaped with a backslash // check if size/pos have reasonable values void CheckOnScreen(wxPoint &pos, wxSize &size, const int w0=100, const int h0=70);
Kris Jurka wrote: > svn@pgadmin.org wrote: > >> Author: dpage >> >> Date: 2006-02-17 10:49:24 +0000 (Fri, 17 Feb 2006) >> >> New Revision: 5000 >> >> Revision summary: >> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5000&view=rev >> >> Log: >> Properly escape single quotes in connection strings. >> >> > > This commit generates a warning all over the place: Fixed in svn, thanks for reporting. Regards, Andreas