Thread: pgadmin website changes

pgadmin website changes

From
Miha Radej
Date:
hi!

i've set up a copy of pgadmin's website on my local machine. i am using
apache 2.0.54 and php 5.0.4. when i tried to view the site, a bunch of
errors popped up in my php error log:

[21-Jan-2006 20:43:15] PHP Notice:  Undefined index:  _SERVER in
/net/www/www.pgadmin3.org/index.php on line 3
[21-Jan-2006 20:43:15] PHP Warning:  main(/include/page.php) [<a
href='function.main'>function.main</a>]: failed to open stream: No such
file or directory
in /net/www/www.pgadmin3.org/index.php on line 3
[21-Jan-2006 20:43:15] PHP Warning:  main() [<a
href='function.include'>function.include</a>]: Failed opening
'/include/page.php' for inclusion (include_pa
th='.:/net/www/libs/adodb:/net/www/libs/Smarty/libs') in
/net/www/www.pgadmin3.org/index.php on line 3
[21-Jan-2006 20:43:15] PHP Fatal error:  Call to undefined function
www_page() in /net/www/www.pgadmin3.org/index.php on line 23

these errors went away after i changed all occurances of
$GLOBALS["_SERVER"]["DOCUMENT_ROOT"] to $_SERVER["DOCUMENT_ROOT"].
_SERVER is also an autoglobal, used since php 4.1.0. on any php version
greater than this the change should therefore have no ill effect.

the attached diff file contains these changes. there's also a fix of a
typo (an windows installer -> a windows installer) and another small
change in the include/session.php file.

also, what happened to the language selection menu?

regards,
Miha

--
"... the small primitive tribes joined up and became huge, powerful
primitive tribes with more sophisticated weapons."
   -- Terry Pratchett, Small Gods

Attachment

Re: pgadmin website changes

From
"Dave Page"
Date:
Thanks Miha, patch applied.

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of Miha Radej
> Sent: 22 January 2006 09:44
> To: pgadmin-hackers
> Subject: [pgadmin-hackers] pgadmin website changes
>
> hi!
>
> i've set up a copy of pgadmin's website on my local machine.
> i am using
> apache 2.0.54 and php 5.0.4. when i tried to view the site, a
> bunch of
> errors popped up in my php error log:
>
> [21-Jan-2006 20:43:15] PHP Notice:  Undefined index:  _SERVER in
> /net/www/www.pgadmin3.org/index.php on line 3
> [21-Jan-2006 20:43:15] PHP Warning:  main(/include/page.php) [<a
> href='function.main'>function.main</a>]: failed to open
> stream: No such
> file or directory
> in /net/www/www.pgadmin3.org/index.php on line 3
> [21-Jan-2006 20:43:15] PHP Warning:  main() [<a
> href='function.include'>function.include</a>]: Failed opening
> '/include/page.php' for inclusion (include_pa
> th='.:/net/www/libs/adodb:/net/www/libs/Smarty/libs') in
> /net/www/www.pgadmin3.org/index.php on line 3
> [21-Jan-2006 20:43:15] PHP Fatal error:  Call to undefined function
> www_page() in /net/www/www.pgadmin3.org/index.php on line 23
>
> these errors went away after i changed all occurances of
> $GLOBALS["_SERVER"]["DOCUMENT_ROOT"] to $_SERVER["DOCUMENT_ROOT"].
> _SERVER is also an autoglobal, used since php 4.1.0. on any
> php version
> greater than this the change should therefore have no ill effect.
>
> the attached diff file contains these changes. there's also a
> fix of a
> typo (an windows installer -> a windows installer) and another small
> change in the include/session.php file.
>
> also, what happened to the language selection menu?
>
> regards,
> Miha
>
> --
> "... the small primitive tribes joined up and became huge, powerful
> primitive tribes with more sophisticated weapons."
>    -- Terry Pratchett, Small Gods
>