Thread: patch for pgadmin3

Hi all,

I've been testing Fedora Core 5, which currently doesn't have an
up-to-date version of pgadmin3, I've tried building v1.4.1 on FC5, which
uses gcc v4.1 and needed to remove superfluous scope qualifiers from a
few method names.

It's entirely possible you've already fixed this in CVS, I didn't look
so I may have wasted my own time, but attached is my patch, works for me
as they say ...

p.s. I got *lots* of warnings about "dereferencing type-punned
pointer will break strict-aliasing rules" from wxWidgets,are these in
any way to be expected? Building on x86_64 if that makes a difference.






--- old/pgadmin3-1.4.1/src/include/pgSchema.h    2005-12-10 14:24:32.000000000 +0000
+++ new/pgadmin3-1.4.1/src/include/pgSchema.h    2006-01-16 21:32:57.000000000 +0000
@@ -85,7 +85,7 @@
     pgSchemaObject(pgSchema *newSchema, int newType, const wxString& newName = wxT("")) : pgDatabaseObject(newType,
newName)
         { SetSchema(newSchema); wxLogInfo(wxT("Creating a pg") + GetTypeName() + wxT(" object")); }

-    pgSchemaObject::~pgSchemaObject()
+    ~pgSchemaObject()
         { wxLogInfo(wxT("Destroying a pg") + GetTypeName() + wxT(" object")); }

     bool GetSystemObject() const;

--- old/pgadmin3-1.4.1/xtra/pgagent/include/connection.h    2005-12-10 14:24:39.000000000 +0000
+++ new/pgadmin3-1.4.1/xtra/pgagent/include/connection.h    2006-01-16 21:44:24.000000000 +0000
@@ -41,7 +41,7 @@
     void Return();

 private:
-    bool DBconn::Connect(const wxString &connectString);
+    bool Connect(const wxString &connectString);

 protected:
     static wxString basicConnectString;

Andy Burns wrote:

> attached is my patch

I didn't make it too clear *what* this patch fixes, gcc4.1 complains
about "extra qualification" if you include the class name in the method
definition.

https://www.redhat.com/archives/fedora-devel-list/2005-December/msg00256.html
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16782

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of Andy Burns
> Sent: 16 January 2006 22:10
> To: pgadmin-hackers@postgresql.org
> Subject: [pgadmin-hackers] patch for pgadmin3
>
> Hi all,
>
> I've been testing Fedora Core 5, which currently doesn't have an
> up-to-date version of pgadmin3, I've tried building v1.4.1 on
> FC5, which
> uses gcc v4.1 and needed to remove superfluous scope
> qualifiers from a
> few method names.

Thanks Andy, patch applied.

> p.s. I got *lots* of warnings about "dereferencing type-punned
> pointer will break strict-aliasing rules" from wxWidgets,are these in
> any way to be expected? Building on x86_64 if that makes a difference.

I've never build wxWidgets with GCC4.1, never mind on 64 bit :-). You
would need to ask the wx list about this one I'm afraid.

Regards, Dave.