Thread: Re: [SUMMARY] Re: New acinclude.m4

Re: [SUMMARY] Re: New acinclude.m4

From
blacknoz@club-internet.fr
Date:
----Message d'origine----
>Copie à: "Florian G. Pflug" <fgp@phlo.org>,
>De: "Adam H.Pendleton" <fmonkey@fmonkey.net>
>Sujet: Re: [SUMMARY] Re: [pgadmin-hackers] New acinclude.m4
>Date: Thu, 19 May 2005 17:44:44 -0400
>A: Raphaël Enrici <blacknoz@club-internet.fr>
>
>
>On May 19, 2005, at 5:27 PM, Raphaël Enrici wrote:
>
>> To summarize :
>> - we reject the configure.ac.patch which removed ENABLE_STATIC and
>> should not have been included in trunk yet
>
>You mean reject my entire patch?  It did much more than just remove
>ENABLE_STATIC, so it should not be rejected.

Oh no! Your patch is _really_ fine and it does not remove ENABLE_STATIC from configure.ac! I meant to just reject the
firstone I sent yesterday evening concerning ENABLE_STATIC removal in configure.ac, not acinclude.m4. 

>> - we keep the latest "acinclude_static.patch" which re-add support for
>> pg_static_build=yes + takes care of systems where wxWid installations
>> are both static & dynamic.
>
>We should  add your patch to what is already in the trunk.

So we all agree. Thank you Adam and Florian for this thread, it just reminds me we are alive :-)

@Dave, can you apply the last patch I sent named "acinclude_static.patch" concerning acinclude.m4 and ignore my first
oneconcerning the configure.ac? Thanks. (note that if you don't find it, I can repost it). All of this should be done
oncurrent trunk keeping Adam's work. 

Regards,
Raphaël


Re: [SUMMARY] Re: New acinclude.m4

From
"Dave Page"
Date:

> -----Original Message-----
> From: blacknoz@club-internet.fr [mailto:blacknoz@club-internet.fr]
> Sent: 20 May 2005 08:00
> To: fmonkey@fmonkey.net
> Cc: fgp@phlo.org; Dave Page; pgadmin-hackers@postgresql.org
> Subject: Re: Re: [SUMMARY] Re: [pgadmin-hackers] New acinclude.m4
>
>
> @Dave, can you apply the last patch I sent named
> "acinclude_static.patch" concerning acinclude.m4 and ignore
> my first one concerning the configure.ac? Thanks. (note that
> if you don't find it, I can repost it). All of this should be
> done on current trunk keeping Adam's work.

Damn, I take one night off and the list goes insane!

Yes, I'll apply it later today to trunk and 1_2_0_PATCHES. Following
that, can everyone concerned test both versions please?

As an aside, you may have noticed that I've been working on
/xtra/pgagent/* recently - can you please take a look over the makefiles
under there and make sure the look OK (Florian in particular, for
obvious reasons)?

Regards, Dave.