Thread: CVS Commit by andreas: Unix Domain Socket additional stuff switch to

Log Message:
-----------
Unix Domain Socket additional stuff
switch to wxWidgets 2.6

Modified Files:
--------------
    pgadmin3:
        CHANGELOG.txt (r1.203 -> r1.204)
    pgadmin3/src:
        pgAdmin3.dsp (r1.126 -> r1.127)
    pgadmin3/src/schema:
        pgServer.cpp (r1.61 -> r1.62)
    pgadmin3/src/ui:
        dlgServer.cpp (r1.17 -> r1.18)

Added Files:
-----------
    pgadmin3/src:
        wx-pgadmin.dsw (r1.1)

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> cvs@developer.pgadmin.org
> Sent: 18 April 2005 15:39
> To: pgadmin-hackers@postgresql.org
> Subject: [pgadmin-hackers] CVS Commit by andreas: Unix Domain
> Socket additional stuff switch to
>
> Log Message:
> -----------
> Unix Domain Socket additional stuff

Err, would you mind unbreaking this please? I can no longer change the
port number for the socket (libpq uses it to form part of the filename),
and the trailing / that is added to the end of the path now results in
libpq trying to connect to paths such as /tmp//.s.PGSQL.5432, which
although it works, is not technically correct iirc.

Heavy night on the beer last night? :-)

/D

Dave Page wrote:
>
> Err, would you mind unbreaking this please? I can no longer change the
> port number for the socket (libpq uses it to form part of the filename),

Uh, I wasn't aware of that. Hm, whatever this is good for...

> and the trailing / that is added to the end of the path now

This is your libpq's fault, I can't see any code to add a trailing /.
Your DEFAULT_PGSOCKET_DIR is probably "/tmp/".

Regards,
Andreas

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 19 April 2005 18:35
> To: Dave Page
> Cc: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] CVS Commit by andreas: Unix
> Domain Socket additional stuff switch to
>
> Dave Page wrote:
> >
> > Err, would you mind unbreaking this please? I can no longer
> change the
> > port number for the socket (libpq uses it to form part of
> the filename),
>
> Uh, I wasn't aware of that. Hm, whatever this is good for...

Running multiple servers at once, without having to setup different
socket dirs.

> > and the trailing / that is added to the end of the path now
>
> This is your libpq's fault, I can't see any code to add a trailing /.
> Your DEFAULT_PGSOCKET_DIR is probably "/tmp/".

I can't double check this now (my Linux box is in the office), but all
of a sudden after I rebuilt with your changes I got a trailing / added,
which led to a double / in connect error messages - though I agree I
can't see any obvious cause having looked at your patch more closely.

I look tomorrow.

Cheers, Dave.