Thread: This is strange patch.(ctlComboBox.h)

This is strange patch.(ctlComboBox.h)

From
"Hiroshi Saito"
Date:
Hi Andreas.

wxWidgets which is our standard target is in confusion.
I have left behind a problem since that time in FreeBSD.:-(
However, a standard is thought to be here.
http://developer.pgadmin.org/snapshots/wxWidgets/
wxWidgets-pgAdmin3-20040907-2.tar.bz2

The problem that I met with make of the windows was strange.??
It complains that wxGetWindowText isn't found that I don't put this.
Do I forget anything, and lose it?

--- src/include/ctlComboBox.h.orig      Fri Oct 29 16:10:27 2004
+++ src/include/ctlComboBox.h   Fri Oct 29 16:11:33 2004
@@ -18,6 +18,9 @@


 #ifdef __WXMSW__
+
+#include <wx/msw/private.h>
+
 class wxComboBoxFix : public wxComboBox
 {
 public:


Thank you.

regards,
Hiroshi Saito


Re: This is strange patch.(ctlComboBox.h)

From
"Dave Page"
Date:

> -----Original Message-----
> From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp]
> Sent: 29 October 2004 08:26
> To: Andreas Pflug
> Cc: pgadmin-hackers@postgresql.org; Dave Page
> Subject: This is strange patch.(ctlComboBox.h)
>
> Hi Andreas.
>
> wxWidgets which is our standard target is in confusion.
> I have left behind a problem since that time in FreeBSD.:-(
> However, a standard is thought to be here.
> http://developer.pgadmin.org/snapshots/wxWidgets/
> wxWidgets-pgAdmin3-20040907-2.tar.bz2
>
> The problem that I met with make of the windows was strange.??
> It complains that wxGetWindowText isn't found that I don't put this.
> Do I forget anything, and lose it?

Hi Hiroshi,

We now use the standard wxWidgets 2.5.3 from www.wxwidgets.org. No more
custom versions :-)

I suspect your problem may have been the result of a work around Andreas
added for a bug in 2.5.3. He added it to pgAdmin's code to avoit the
need for a new snapshot.

Regards, Dave.

Re: This is strange patch.(ctlComboBox.h)

From
"Hiroshi Saito"
Date:
Hi Dave.

>
> Hi Hiroshi,
>
> We now use the standard wxWidgets 2.5.3 from www.wxwidgets.org. No more
> custom versions :-)

Ahhh...
I must do the preparation of running after it, too.

>
> I suspect your problem may have been the result of a work around Andreas
> added for a bug in 2.5.3. He added it to pgAdmin's code to avoit the
> need for a new snapshot.

Thank you. will be fine tomorrow.!

regards,
Hiroshi Saito

Re: This is strange patch.(ctlComboBox.h)

From
Andreas Pflug
Date:
>>From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp]
>>It complains that wxGetWindowText isn't found that I don't put this.

This is win32 code only, I wonder why you got caught from that; this may
not happen.

Dave Page wrote:

> Hi Hiroshi,
>
> We now use the standard wxWidgets 2.5.3 from www.wxwidgets.org. No more
> custom versions :-)

As long as workarounds are viable...

> I suspect your problem may have been the result of a work around Andreas
> added for a bug in 2.5.3. He added it to pgAdmin's code to avoit the
> need for a new snapshot.

Yup; still, the fix is gtk neutral (at least it should be).

Regards,
Andreas