Thread: CVS Commit by andreas: more pgFrame refactoring

CVS Commit by andreas: more pgFrame refactoring

From
cvs@cvs.pgadmin.org
Date:
Log Message:
-----------
more pgFrame refactoring

Modified Files:
--------------
    pgadmin3/src/include:
        dlgClasses.h (r1.12 -> r1.13)
        frmMain.h (r1.56 -> r1.57)
        frmQuery.h (r1.26 -> r1.27)
        menu.h (r1.19 -> r1.20)


Attachment

Re: CVS Commit by andreas: more pgFrame refactoring

From
"Dave Page"
Date:

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> cvs@cvs.pgadmin.org
> Sent: 10 October 2004 18:27
> To: pgadmin-hackers@postgresql.org
> Subject: [pgadmin-hackers] CVS Commit by andreas: more
> pgFrame refactoring
>

Hi Andreas,

What's all this refactoring for? It's a bit late in the beta stage for
non-bug fixes, or did I miss one?

Regards, Dave

Re: CVS Commit by andreas: more pgFrame refactoring

From
Andreas Pflug
Date:
Dave Page wrote:
>
>

>
> Hi Andreas,
>
> What's all this refactoring for? It's a bit late in the beta stage for
> non-bug fixes, or did I miss one?

Just some moving of methods down into the base class, looks much more
drastic than it is.

Actually, I got much more on my machine, waiting for 1.3. The
postgresql.conf editor is nearly done, re-using those common methods.

Regards,
Andreas


Attachment

Re: CVS Commit by andreas: more pgFrame refactoring

From
"Dave Page"
Date:

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 10 October 2004 21:53
> To: Dave Page
> Cc: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] CVS Commit by andreas: more
> pgFrame refactoring
>
>
> Just some moving of methods down into the base class, looks
> much more drastic than it is.

OK.

> Actually, I got much more on my machine, waiting for 1.3. The
> postgresql.conf editor is nearly done, re-using those common methods.

Cool. Looking forward to seeing it.

Ready for another beta yet or should we bite the bllet and go for a
release?

Regards,Dave.

Release or new beta? (Was:Re: CVS Commit by andreas: more pgFrame refactoring)

From
Devrim GUNDUZ
Date:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Hi,

On Sun, 10 Oct 2004, Dave Page wrote:

> Ready for another beta yet or should we bite the bllet and go for a
> release?

Please hold on for a release. We have a SSL problem in FC2, I know how to
fix it, but I'm really out of time. 2-3 will be enough for me. It's a
problem with my PostgreSQL installation I think, but I just want to be
sure.

Well, an RC1 could be better, IMHO.

Regards,
- --
Devrim GUNDUZ
devrim~gunduz.org                devrim.gunduz~linux.org.tr
             http://www.tdmsoft.com
             http://www.gunduz.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFBaaSZtl86P3SPfQ4RAjYVAJ9WIS9ktGSfDAOiIm1t64ZvvjnHJgCgmBqb
S9rObW4B62q7KZQ4Ic/hjV4=
=RdOB
-----END PGP SIGNATURE-----

Re: CVS Commit by andreas: more pgFrame refactoring

From
Andreas Pflug
Date:
Dave Page wrote:

>
> Cool. Looking forward to seeing it.

:-)
Kind-of done on postgresql.conf. I've put quite some effort in editing
the file chirurgically, retaining as much previous information as possible.


> Ready for another beta yet or should we bite the bllet and go for a
> release?

OOH, I'd like to have a release asap, so I can push the config editors.
OTOH, some more feedback (preferrably not the beta-1 bug..) would be
nice. The recent "owner code" fix is typical for stuff I'd expect to be
buried in pgadmin with several other flavours too.

If nothing happens the next few days, I'd opt for freezing RC1, and
forking off 1.3. If there's really more stuff in RC1 after that, we
probably can apply the fix on two versions without too much duplicate work.

That RC1 is another good timestamp to announce.

After the fork, you may touch BCE (backend configuration editor)
yourself. It does configuration using direct file access as well as
using sql.

Regards,
Andreas