Thread: CVS Commit by dpage: Dynamically link libpq/OpenSSL for sensible

CVS Commit by dpage: Dynamically link libpq/OpenSSL for sensible

From
cvs@cvs.pgadmin.org
Date:
Log Message:
-----------
Dynamically link libpq/OpenSSL for sensible installation with Win32 PostgreSQL.
Libs can be downloaded from http://developer.pgadmin.org/snapshots/postgresql/libs-win32-20040927.zip

Modified Files:
--------------
    pgadmin3/src:
        pgAdmin3.dsp (r1.113 -> r1.114)


Attachment

Re: CVS Commit by dpage: Dynamically link libpq/OpenSSL

From
Alexander Borkowski
Date:
cvs@cvs.pgadmin.org wrote:

> Log Message:
> -----------
> Dynamically link libpq/OpenSSL for sensible installation with Win32 PostgreSQL.
> Libs can be downloaded from http://developer.pgadmin.org/snapshots/postgresql/libs-win32-20040927.zip

Can you remove the references to ssleay32.lib and libeay23.lib from
pgAdmin3.dsp as well? It builds o.k. without them, but I don't know
whether it will run alright or not (I don't have an SSL server to check
against, but it works for me with non-SSL servers).

Regards,

Alex




Re: CVS Commit by dpage: Dynamically link libpq/OpenSSL for sensible

From
"Dave Page"
Date:
No, they need to be there - there the import libraries that contain the stubs for the functions in the dlls.

Regards, Dave


-----Original Message-----
From: Alexander Borkowski [mailto:alexander.borkowski@abri.une.edu.au]
Sent: Thu 10/7/2004 5:27 AM
To: Dave Page
Cc: pgadmin-hackers@postgresql.org
Subject: Re: [pgadmin-hackers] CVS Commit by dpage: Dynamically link libpq/OpenSSL for sensible

cvs@cvs.pgadmin.org wrote:

> Log Message:
> -----------
> Dynamically link libpq/OpenSSL for sensible installation with Win32 PostgreSQL.
> Libs can be downloaded from http://developer.pgadmin.org/snapshots/postgresql/libs-win32-20040927.zip

Can you remove the references to ssleay32.lib and libeay23.lib from
pgAdmin3.dsp as well? It builds o.k. without them, but I don't know
whether it will run alright or not (I don't have an SSL server to check
against, but it works for me with non-SSL servers).

Regards,

Alex





Re: CVS Commit by dpage: Dynamically link libpq/OpenSSL

From
Alexander Borkowski
Date:
Dave Page wrote:

> No, they need to be there - there the import libraries that contain the stubs for the functions in the dlls.

Please correct me if I get this totally confused, but aren't the stubs
for the SSL stuff already in libpq.dll (looking at
postgresql-8.0.0beta3/src/interfaces/libpq/win32.mak with USE_SSL
defined)? And as far as I can tell pgAdmin III is not using any of the
SSL functions directly anyway since they are hidden behind the libpq API
(pgConn.cpp lines 196 to 207), so why link against the SSL libraries
(static or dynamic) in this case?

Regards,

Alex

Re: CVS Commit by dpage: Dynamically link libpq/OpenSSL for sensible

From
"Dave Page"
Date:

> -----Original Message-----
> From: Alexander Borkowski
> [mailto:alexander.borkowski@abri.une.edu.au]
> Sent: 07 October 2004 08:23
> To: Dave Page
> Cc: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] CVS Commit by dpage:
> Dynamically link libpq/OpenSSL for sensible
>
> Dave Page wrote:
>
> > No, they need to be there - there the import libraries that
> contain the stubs for the functions in the dlls.
>
> Please correct me if I get this totally confused, but aren't
> the stubs for the SSL stuff already in libpq.dll (looking at
> postgresql-8.0.0beta3/src/interfaces/libpq/win32.mak with
> USE_SSL defined)? And as far as I can tell pgAdmin III is not
> using any of the SSL functions directly anyway since they are
> hidden behind the libpq API (pgConn.cpp lines 196 to 207), so
> why link against the SSL libraries (static or dynamic) in this case?

Ahh, no you're right. There was an SSL call in pgAdmin, but that's gone
now. I've added it to my todo.

Regards, Dave.