Thread: acinclude Patch
Could the port maintainers please apply this patch to acinclude.m4 and
let my know if anyone has any problems? This patch is against CVS HEAD,
but it should apply to any recent acinclude.
ahp
--- pgadmin3/acinclude.m4 2003-10-09 16:40:21.000000000 -0400
+++ pgadmin3.new/acinclude.m4 2003-10-15 12:01:17.000000000 -0400
@@ -111,7 +111,7 @@
fi
if test "$pg_static_build" = "yes"
then
- LIBS="${LIBPQ_HOME}/lib/libpq.a -lcrypt $LIBS -lssl -lcrypto"
+ LIBS="${LIBPQ_HOME}/lib/libpq.a $LIBS -lssl -lcrypto"
else
LIBS="$LIBS -lssl -lcrypto -lpq"
fi
Hi Adam, I can see what the patch does, but why? Regards, Dave. > -----Original Message----- > From: Adam H. Pendleton [mailto:fmonkey@fmonkey.net] > Sent: 15 October 2003 17:03 > To: pgadmin-hackers > Subject: [pgadmin-hackers] acinclude Patch > > Could the port maintainers please apply this patch to > acinclude.m4 and let my know if anyone has any problems? > This patch is against CVS HEAD, but it should apply to any > recent acinclude. > > ahp >
Dave Page wrote: >Hi Adam, > >I can see what the patch does, but why? > > > On the Mac platform, there is no libcrypt, so compilation fails if the static mode is selected. If it's not necessary to link against that library on any of our platforms, then I can take it out, instead of creating a Mac-specific LIBS string. ahp
Thanks, patch applied. > -----Original Message----- > From: Adam H. Pendleton [mailto:fmonkey@fmonkey.net] > Sent: 16 October 2003 13:15 > To: Dave Page > Cc: pgadmin-hackers > Subject: Re: [pgadmin-hackers] acinclude Patch > > Dave Page wrote: > > >Hi Adam, > > > >I can see what the patch does, but why? > > > > > > > On the Mac platform, there is no libcrypt, so compilation > fails if the static mode is selected. If it's not necessary > to link against that library on any of our platforms, then I > can take it out, instead of creating a Mac-specific LIBS string. > > ahp > >
> -----Original Message----- > From: Adam H. Pendleton [mailto:fmonkey@fmonkey.net] > Sent: 16 October 2003 13:15 > To: Dave Page > Cc: pgadmin-hackers > Subject: Re: [pgadmin-hackers] acinclude Patch > > Dave Page wrote: > > >Hi Adam, > > > >I can see what the patch does, but why? > > > > > > > On the Mac platform, there is no libcrypt, so compilation > fails if the static mode is selected. If it's not necessary > to link against that library on any of our platforms, then I > can take it out, instead of creating a Mac-specific LIBS string. Hi Adam, I have backed out this patch because it is breaking the Slackware build :-( Looks like we need something platform specific.... Regards, Dave.
Dave Page wrote: > >Hi Adam, > >I have backed out this patch because it is breaking the Slackware build >:-( > >Looks like we need something platform specific.... > > > Yeah, I figured as much. Okay, I'll go back to the drawing board. :-) ahp