Thread: Trigger addition wierdness
Hi Andreas, I was working in a db earlier today, and added a new trigger to a table that already had one. When the new node was added to the treeview, it took the name of the existing trigger, not the new one. A refresh cleared it up. I had a quick look at the code but couldn't see anything obvious - any ideas? Regards, Dave.
Dave Page wrote: >Hi Andreas, > >I was working in a db earlier today, and added a new trigger to a table >that already had one. When the new node was added to the treeview, it >took the name of the existing trigger, not the new one. A refresh >cleared it up. > >I had a quick look at the code but couldn't see anything obvious - any >ideas? > No idea, needs deep debugging unless it was just a bug running over your monitor ;-) Regards, Andreas
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 30 September 2003 00:04 > To: Dave Page > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] Trigger addition wierdness > > > Dave Page wrote: > > >Hi Andreas, > > > >I was working in a db earlier today, and added a new trigger > to a table > >that already had one. When the new node was added to the > treeview, it > >took the name of the existing trigger, not the new one. A refresh > >cleared it up. > > > >I had a quick look at the code but couldn't see anything > obvious - any > >ideas? > > > No idea, needs deep debugging unless it was just a bug > running over your > monitor ;-) Hmm, shouldn't be a bug, the exterminator said he got all of those last week... I'll have to have a play. Meanwhile, I'm hacking the Query Builder about at the moment so don't be alarmed if that reappears in menus etc. Regards, Dave.
Hi Dave.
The humor of today's cvs is ill.:-)
regards,
Hiroshi Saito
From: "Dave Page" <dpage@vale-housing.co.uk>
(snip)
> Hmm, shouldn't be a bug, the exterminator said he got all of those last
> week...
>
> I'll have to have a play. Meanwhile, I'm hacking the Query Builder about
> at the moment so don't be alarmed if that reappears in menus etc.
bsd5% DIFF src/include/frmQueryBuilder.h.orig src/include/frmQueryBuilder.h
--- src/include/frmQueryBuilder.h.orig Wed Oct 1 00:14:56 2003
+++ src/include/frmQueryBuilder.h Wed Oct 1 00:15:04 2003
@@ -20,7 +20,7 @@
#include "frmMain.h"
#include "frmChildTableViewFrame.h"
#include "dlgAddTableView.h"
-#include "ctlSQLresult.h"
+#include "ctlSQLResult.h"
struct JoinStruct
{
Thanks Hiroshi. Applied with another fix to allow use of trigger functions not in the search path. I'm also going to apply both fixes to the 1.0.0 patches branch. Regards, Dave. > -----Original Message----- > From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp] > Sent: 30 September 2003 20:13 > To: Dave Page > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] Trigger addition wierdness > > > Hi Dave. > > It is repaired in this.:-) > Please Apply it. > > regards, > Hiroshi Saito > > > From: "Dave Page" <dpage@vale-housing.co.uk> > > (snip) > > >I was working in a db earlier today, and added a new trigger > > to a table > > >that already had one. When the new node was added to the > > treeview, it > > >took the name of the existing trigger, not the new one. A refresh > > >cleared it up. > > > > > >I had a quick look at the code but couldn't see anything > > obvious - any > > >ideas? >
Ooops! sorry. Fixed now - thanks :-)
I wrote that on Windows so didn't notice the problem of course...
Regards, Dave.
> -----Original Message-----
> From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp]
> Sent: 30 September 2003 16:17
> To: Dave Page
> Cc: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Trigger addition wierdness
>
>
> Hi Dave.
>
> The humor of today's cvs is ill.:-)
>
> regards,
> Hiroshi Saito
>
> From: "Dave Page" <dpage@vale-housing.co.uk>
> (snip)
> > Hmm, shouldn't be a bug, the exterminator said he got all of those
> > last week...
> >
> > I'll have to have a play. Meanwhile, I'm hacking the Query Builder
> > about at the moment so don't be alarmed if that reappears in menus
> > etc.
>
>
> bsd5% DIFF src/include/frmQueryBuilder.h.orig
> src/include/frmQueryBuilder.h
> --- src/include/frmQueryBuilder.h.orig Wed Oct 1 00:14:56 2003
> +++ src/include/frmQueryBuilder.h Wed Oct 1 00:15:04 2003
> @@ -20,7 +20,7 @@
> #include "frmMain.h"
> #include "frmChildTableViewFrame.h"
> #include "dlgAddTableView.h"
> -#include "ctlSQLresult.h"
> +#include "ctlSQLResult.h"
>
> struct JoinStruct
> {
>
>
Hi Dave. It is repaired in this.:-) Please Apply it. regards, Hiroshi Saito > From: "Dave Page" <dpage@vale-housing.co.uk> > (snip) > >I was working in a db earlier today, and added a new trigger > to a table > >that already had one. When the new node was added to the > treeview, it > >took the name of the existing trigger, not the new one. A refresh > >cleared it up. > > > >I had a quick look at the code but couldn't see anything > obvious - any > >ideas?