Thread: Re: [pgadmin-support] Aborted viewing operation

Re: [pgadmin-support] Aborted viewing operation

From
"Dave Page"
Date:
Sorry, minor brain fart - that did cross my mind when I applied it but
for some reason then thought it was right!

Regards, Dave

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 24 September 2003 16:03
> To: Dave Page
> Cc: Hiroshi Saito; pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-support] Aborted viewing operation
>
>
> The fix is no fix but a bug and needs to be reverted; I
> removed it from CVS. PQfnumber is a libpq API func, not SQL
> and thus doesn't need quoting.
>
> Regards,
> Andreas
>
>
> Dave Page wrote:
>
> >Thanks Hiroshi, patch applied.
> >
> >Regards, Dave
> >
> >
> >
> >>-----Original Message-----
> >>From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp]
> >>Sent: 24 September 2003 02:40
> >>To: oreomitch@prism.co.za
> >>Cc: pgadmin-support@postgresql.org;
> >>pgadmin-hackers@postgresql.org; Dave Page
> >>Subject: Re: [pgadmin-support] Aborted viewing operation
> >>
> >>
> >>Dear Mitchell.
> >>
> >>This was a bug.
> >>Probably, it doesn't seem to be the problem of two and more
> >>columns. It is repaired by the application of this patch. Do
> >>you apply this, and can you try it?
> >>
> >>Hi Dave.
> >>Please Apply it.
> >>
> >>Regards,
> >>Hiroshi Saito
> >>
> >>
> >>
>
>
>

Re: [pgadmin-support] Aborted viewing operation

From
"Hiroshi Saito"
Date:
Why?
PQfnumber is improper if QUOTE isn't done.
See libpq.
It disposes of all tolowers.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Dave Page" <dpage@vale-housing.co.uk>
To: "Andreas Pflug" <pgadmin@pse-consulting.de>
Cc: "Hiroshi Saito" <saito@inetrt.skcapi.co.jp>; <pgadmin-hackers@postgresql.org>
Sent: Thursday, September 25, 2003 12:12 AM
Subject: RE: [pgadmin-support] Aborted viewing operation


Sorry, minor brain fart - that did cross my mind when I applied it but
for some reason then thought it was right!

Regards, Dave

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 24 September 2003 16:03
> To: Dave Page
> Cc: Hiroshi Saito; pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-support] Aborted viewing operation
>
>
> The fix is no fix but a bug and needs to be reverted; I
> removed it from CVS. PQfnumber is a libpq API func, not SQL
> and thus doesn't need quoting.
>
> Regards,
> Andreas
>
>
> Dave Page wrote:
>
> >Thanks Hiroshi, patch applied.
> >
> >Regards, Dave
> >
> >
> >
> >>-----Original Message-----
> >>From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp]
> >>Sent: 24 September 2003 02:40
> >>To: oreomitch@prism.co.za
> >>Cc: pgadmin-support@postgresql.org;
> >>pgadmin-hackers@postgresql.org; Dave Page
> >>Subject: Re: [pgadmin-support] Aborted viewing operation
> >>
> >>
> >>Dear Mitchell.
> >>
> >>This was a bug.
> >>Probably, it doesn't seem to be the problem of two and more
> >>columns. It is repaired by the application of this patch. Do
> >>you apply this, and can you try it?
> >>
> >>Hi Dave.
> >>Please Apply it.
> >>
> >>Regards,
> >>Hiroshi Saito


Re: [pgadmin-support] Aborted viewing operation

From
Andreas Pflug
Date:
Hiroshi Saito wrote:

>Why?
>PQfnumber is improper if QUOTE isn't done.
>See libpq.
>It disposes of all tolowers.
>
>

Seems that Hiroshi is right and we have to turn back the turning back :-)
Doc doesn't say anything about it, but apparently libpq really tolowers
the col name.
There's also a fix for view required now.

Regards,
Andreas