Thread: Small modification
Hi Andreas.
1)
pgobject.cpp(666) : error C2668: 'wxString::wxString'
This happens with MSW.
' ' -> wxT(" ") change
2)
ui\frmmain.cpp(23) : fatal error
wx/tbarsmpl.h...
It seems that it was moved with recent wxWindows-cvs to contrib.
had better take it.
Even if it is not here, it is all right with wxWindows-pgAdmin3-20030722
Regards,
Hiroshi Saito
Attachment
Hi Hiroshi,
Hiroshi Saito wrote:
>1)
>pgobject.cpp(666) : error C2668: 'wxString::wxString'
>This happens with MSW.
>' ' -> wxT(" ") change
>
This fix is wrong, the current code is correct. The used constructor
will create a string of indent spaces.
>
>2)
>ui\frmmain.cpp(23) : fatal error
>wx/tbarsmpl.h...
>It seems that it was moved with recent wxWindows-cvs to contrib.
>had better take it.
>Even if it is not here, it is all right with wxWindows-pgAdmin3-20030722
>
Can't say anything about that, please continue using the frozen
wxWindows-pgAdmin3-20030722 version. Any later version is unpredictable
until we have a wx2.5 release.
Regards,
Andreas
From: "Andreas Pflug" <pgadmin@pse-consulting.de> > Hi Hiroshi, (snip) [> Can't say anything about that, please continue using the frozen > wxWindows-pgAdmin3-20030722 version. Any later version is unpredictable > until we have a wx2.5 release. > > Regards, > Andreas Ok. The problem that it was flown here doesn't occur in 20030722 version. But, I am not satisfied with this version. A language choice can't be done freely by one as a big problem in FreeBSD. https://sourceforge.net/tracker/?func=detail&atid=309863&aid=775994&group_id =9863 It wants this edition which coped with it at least. Regards, Hiroshi Saito
Hiroshi Saito wrote: >From: "Andreas Pflug" <pgadmin@pse-consulting.de> > > > >>Hi Hiroshi, >> >> >(snip) >[> Can't say anything about that, please continue using the frozen > > >>wxWindows-pgAdmin3-20030722 version. Any later version is unpredictable >>until we have a wx2.5 release. >> >>Regards, >>Andreas >> >> > >Ok. >The problem that it was flown here doesn't occur in 20030722 version. > >But, I am not satisfied with this version. >A language choice can't be done freely by one as a big problem in FreeBSD. >https://sourceforge.net/tracker/?func=detail&atid=309863&aid=775994&group_id >=9863 >It wants this edition which coped with it at least. > I understand this, but upgrading to a new version means some debugging because cvs usually has several bugs in it (as you noticed). Actually, I believe the way the locale is chosen is very unfortunate. Dave, could you apply the appended patch to our 20030722 version of src/common/intl.cpp? It will make Hiroshi happy :-) Regards, Andreas @@ -683,27 +683,11 @@ static wxWCharBuffer wxSetlocaleTryUTF(int c, const wxChar *lc) { wxMB2WXbuf l = wxSetlocale(c, lc); + if ( !l && lc && lc[0] != 0 ) - if ( lc && lc[0] != 0 && !l ) { wxString buf(lc); + wxString buf2; + buf2 = buf + wxT(".UTF-8"); + l = wxSetlocale(c, buf2.c_str()); + if ( !l ) + { + buf2 = buf + wxT(".utf-8"); + l = wxSetlocale(c, buf2.c_str()); + } + if ( !l ) + { + buf2 = buf + wxT(".UTF8"); + l = wxSetlocale(c, buf2.c_str()); + } + if ( !l ) + { + buf2 = buf + wxT(".utf8"); + l = wxSetlocale(c, buf2.c_str()); + } - buf += wxT(".utf8"); - l = wxSetlocale(c, buf.c_str()); } return l; }
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 19 August 2003 09:50 > To: Hiroshi Saito > Cc: pgadmin-hackers@postgresql.org; Dave Page > Subject: Re: [pgadmin-hackers] Small modification > > Dave, could you apply the appended patch to our 20030722 version of > src/common/intl.cpp? It will make Hiroshi happy :-) OK, I'm working on this. What libpq should we be using now anyway? 7.4b1+SSL? Regards, Dave.
Hi Dave. From: "Dave Page" <dpage@vale-housing.co.uk> > -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 19 August 2003 09:50 > To: Hiroshi Saito > Cc: pgadmin-hackers@postgresql.org; Dave Page > Subject: Re: [pgadmin-hackers] Small modification > > Dave, could you apply the appended patch to our 20030722 version of > src/common/intl.cpp? It will make Hiroshi happy :-) > > OK, I'm working on this. Thank you very much.:-) But, The date of tarball seems to cause confusion. Do it so that a checkout date may be indicated clearly? Or, indicate cvs-date to README clearly. 20030819 isn't at least meaningful. It isn't understood how to take diff. > > What libpq should we be using now anyway? 7.4b1+SSL? 7.3.4 thinks it the best at the time of the present. Then, it thinks it necessity to have 7.3 used for the target. Users provide the most accurate problem. Probably. Regards, Hiroshi Saito
> -----Original Message----- > From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp] > Sent: 19 August 2003 13:29 > To: Dave Page; Andreas Pflug > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] Small modification > > > Hi Dave. > > From: "Dave Page" <dpage@vale-housing.co.uk> > > -----Original Message----- > > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > > Sent: 19 August 2003 09:50 > > To: Hiroshi Saito > > Cc: pgadmin-hackers@postgresql.org; Dave Page > > Subject: Re: [pgadmin-hackers] Small modification > > > > Dave, could you apply the appended patch to our 20030722 version of > > src/common/intl.cpp? It will make Hiroshi happy :-) > > > > OK, I'm working on this. > > Thank you very much.:-) > > But, > The date of tarball seems to cause confusion. > Do it so that a checkout date may be indicated clearly? > Or, indicate cvs-date to README clearly. > 20030819 isn't at least meaningful. > It isn't understood how to take diff. 20030819 is the date the tarball was updated by us. The README.pgAdmin file within the tarball tells you the date that the CVS snapshot was taken. Regards, Dave.
From: "Dave Page" <dpage@vale-housing.co.uk> > > 20030819 is the date the tarball was updated by us. The README.pgAdmin > file within the tarball tells you the date that the CVS snapshot was > taken. Ah. It was impolite!! written to pgadmin.README I has sleepiness a little.... Regards, Hiroshi Saito
Dave Page wrote: >What libpq should we be using now anyway? 7.4b1+SSL? > > 7.4b1 is fine for me. Regards, Andreas
Hi Andreas. From: "Andreas Pflug" <pgadmin@pse-consulting.de> > Dave Page wrote: > > >What libpq should we be using now anyway? 7.4b1+SSL? > > > > > 7.4b1 is fine for me. Is it to confirm FE/BE protocol No3? 7.4 complying with is seen here and there besides, too. You have been already confident. Let's associate. Regards, Hiroshi Saito
Hiroshi Saito wrote: >Hi Andreas. > >From: "Andreas Pflug" <pgadmin@pse-consulting.de> > > > > >>Dave Page wrote: >> >> >> >>>What libpq should we be using now anyway? 7.4b1+SSL? >>> >>> >>> >>> >>7.4b1 is fine for me. >> >> > >Is it to confirm FE/BE protocol No3? >7.4 complying with is seen here and there besides, too. >You have been already confident. >Let's associate. > > > It should work with all backends, hopefully. Regards, Andreas
----- Original Message ----- From: "Andreas Pflug" <pgadmin@pse-consulting.de> To: "Hiroshi Saito" <saito@inetrt.skcapi.co.jp> Cc: <pgadmin-hackers@postgresql.org> Sent: Tuesday, August 19, 2003 8:01 PM Subject: Re: [pgadmin-hackers] Small modification > Hiroshi Saito wrote: > > >Hi Andreas. > > > >From: "Andreas Pflug" <pgadmin@pse-consulting.de> > > > > > > > > > >>Dave Page wrote: > >> > >> > >> > >>>What libpq should we be using now anyway? 7.4b1+SSL? > >>> > >>> > >>> > >>> > >>7.4b1 is fine for me. > >> > >> > > > >Is it to confirm FE/BE protocol No3? > >7.4 complying with is seen here and there besides, too. > >You have been already confident. > >Let's associate. > > > > > > > It should work with all backends, hopefully. > > Regards, > Andreas It works with protocol 2.0 and protocol 3.0, so it should work with older servers. If I understand the code in fe-connect.c, it tries to connect with protocol 3.0, but if that fails, retries with 2.0. Regards !