Thread: SystemObject show patch more.
Hi Andreas. The SystemObject expression of pgTable It is OK? Regards, Hiroshi-Saito
Attachment
Hi Andreas. One more. pgLanguage patch. Check it. I take a break until the night... Regards, Hiroshi-Saito
Attachment
Hiroshi Saito wrote: >Hi Andreas. > >The SystemObject expression of pgTable >It is OK? > > > This is not necessary, as pgTable is a pgSchemaObject, and GetSystemObject is already handled there. Regards, Andreas
> -----Original Message----- > From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp] > Sent: 16 July 2003 06:58 > To: Hiroshi Saito > Cc: pgadmin-hackers@postgresql.org; Dave Page > Subject: Re: [pgadmin-hackers] SystemObject show patch more. > > > Hi Andreas. > > One more. > pgLanguage patch. > > Check it. > Hi Hiroshi, I beleive the SQL changes you have made are incorrect. The validator is optional (not the handler) so should use the left outer join, and we want lanispl = TRUE to get only user defined procedural languages. In actual fact, I think that's best removed altogether, and SystemObject = (lanispl == FALSE); so that with SystemObjects on, we see SQL & C etc. What do you think? Regards, Dave.
Dave Page wrote: > > >>-----Original Message----- >>From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp] >>Sent: 16 July 2003 06:58 >>To: Hiroshi Saito >>Cc: pgadmin-hackers@postgresql.org; Dave Page >>Subject: Re: [pgadmin-hackers] SystemObject show patch more. >> >> >>Hi Andreas. >> >>One more. >>pgLanguage patch. >> >>Check it. >> >> >> > >Hi Hiroshi, > >I beleive the SQL changes you have made are incorrect. The validator is >optional (not the handler) so should use the left outer join, and we >want lanispl = TRUE to get only user defined procedural languages. In >actual fact, I think that's best removed altogether, and SystemObject = >(lanispl == FALSE); so that with SystemObjects on, we see SQL & C etc. > > > I thought about it, but the languages with lanispl=false would have to be handled separatlely (lanistrusted is meaningless), and you can't learn anything from built-in languages. We know pgsql can SQL, don't we? Regards, Andreas
From: "Andreas Pflug" <pgadmin@pse-consulting.de> > Hiroshi Saito wrote: > > >Hi Andreas. > > > >The SystemObject expression of pgTable > >It is OK? > This is not necessary, as pgTable is a pgSchemaObject, and > GetSystemObject is already handled there. I am sorry. It may have distracted. Sigh... Regards, Hiroshi-Saito
It's rumoured that Hiroshi Saito once said: > From: "Andreas Pflug" <pgadmin@pse-consulting.de> > >> Hiroshi Saito wrote: >> >> >Hi Andreas. >> > >> >The SystemObject expression of pgTable >> >It is OK? >> This is not necessary, as pgTable is a pgSchemaObject, and >> GetSystemObject is already handled there. > > I am sorry. > It may have distracted. > Sigh... :-) Happens to us all!!